[HOLD for payment 2023-07-14] [$4000] Text selection options disappears abruptly

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to split bill
2. Enter some amount
3. Double click on amount to select -> Look for option above text.

Expected Result:

Text formatting option should be visible properly

Actual Result:

Text formatting option disappears abruptly

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.91-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RZAZ8092.1.MP4

RPReplay_Final1680083580.MP4

Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680084554334659

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d391e71cd8a32e4c
• Upwork Job ID: 1644015735567663104
• Last Price Increase: 2023-06-01

[MelvinBot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

Double click on amount to select -> Look for option above text.

@DinalJivani and @kavimuru , I don't know this to be expected behavior. I always tap and hold to select. I tried to double-tap text in Safari on multiple pages and nothing happens, I have to tap and hold. Am I missing something? Can either of you point me to documentation that states double tapping should select text?

[MelvinBot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

@DinalJivani and @kavimuru , can you reply to the above? If not (which is fine) I'll close this once it goes overdue again

[DinalJivani]

@mallenexpensify
Basically the thing is when it’s static text it will be selected on tap and hold but when its text box (which is in our case) you can double tap to select the text inside or triple tap to select the whole text present inside the text box!

Check below video for same!

RPReplay_Final1680720951.mp4

[MelvinBot]

📣 @DinalJivani! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[DinalJivani]

Contributor details
Your Expensify account email: dinaljivani@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01a356bfeda21bbb61?s=996364627857502209

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[DinalJivani]

Can either of you point me to documentation that states double tapping should select text?

@mallenexpensify
Here's the official link which might be helpful!

[mallenexpensify]

Thanks @DinalJivani , I figured out what I was doing wrong. I was double tapping on words 'anywhere' vs in compose boxes. I was able to reproduce the issue. This is a tiny bug but I reckon we should fix it for consistency's sake

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01d391e71cd8a32e4c

[MelvinBot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[MelvinBot]

Triggered auto assignment to @madmax330 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[MelvinBot]

@madmax330, @s77rt, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@madmax330, @s77rt, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[madmax330]

Doesn't look like we have any proposals for this yet

[melvin-bot]

📣 @parasharrajat You have been assigned to this job!
Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @DinalJivani You have been assigned to this job!
Please apply to this job in Upwork here and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[mallenexpensify]

Assigned @parasharrajat as C+ and removed @s77rt . (let me know if that isn't right)

[mountiny]

Not deployed just merged, not sure why this got closed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix #16696] Rewrite BaseTextInput to function component #20186

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat / @narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat / @narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat / @narefyev91] Determine if we should create a regression test for this bug.
• [@parasharrajat / @narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

@parasharrajat , can you please complete the above checklist? Also, can you please accept the job
https://www.upwork.com/jobs/~01a98bd9a501a5056a

[mountiny]

Rajat is paid in product

[DinalJivani]

@mallenexpensify @mountiny
I see this Upwork job is not available to apply for reporting bonus.

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: It's a new refactor. we moved away from uncontrolled Input to controlled.
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Open the app on iOS and log in with an account.
2. Press the Plus FAB button.
3. Open "request money".
4. Enter a number.
5. Select text, and observe that selection menu.

Do you agree 👍 or 👎 ?

[mountiny]

@mallenexpensify will be able to help with that

[mallenexpensify]

@DinalJivani invited! Can you please accept and comment here when you have? https://www.upwork.com/jobs/~01a98bd9a501a5056a

Rajat is paid in product

Thanks for the reminder @mountiny !

[DinalJivani]

@mallenexpensify
Offer Accepted

[parasharrajat]

I will request in NewDot and update you @mallenexpensify

[parasharrajat]

Payment requested on NewDot @mallenexpensify

[mallenexpensify]

@parasharrajat for payments via NewDot for C+, Anu will take care of them so there's no action needed.
@DinalJivani is paid, thanks!
TestRail update https://github.com/Expensify/Expensify/issues/300616

[anmurali]

Approved $4000 to Rajat based on the last comment