[HOLD for payment 2023-08-10] [$250] Migrate withDelayToggleButtonState.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/withDelayToggleButtonState.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: componentWillUnmount

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f71d79044993f634
• Upwork Job ID: 1685090997633961984
2023-07-29
• Automatic offers:
• s77rt | Reviewer | 25857026
• rayane-djouah | Contributor | 25857028

[s-alves10]

I'd love to work on this.

[dayana7204]

I am ready to work on this ticket. :)

[melvin-bot]

📣 @dayana7204! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[vdem0115]

I would like to work on this issue.

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this?

[mejed-alkoutaini]

I'm able to work on this if needed!

[KrAbhas]

Allow me!

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f71d79044993f634

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[rayane-djouah]

Thank you for the review @s77rt

[rayane-djouah]

@s77rt PR #23860 is ready for review 🚀

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[rayane-djouah]

PR approved by C+ and waiting for review from @PauloGasparSv

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @rayane-djouah, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @rayane-djouah got assigned: 2023-07-31 13:21:22 Z
• when the PR got merged: 2023-07-31 19:51:32 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.49-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate withDelayToggleButtonState.js to function component #23860

If no regressions arise, payment will be issued on 2023-08-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @rayane-djouah requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[PauloGasparSv]

Not overdue, still on hold till tomorrow

[Christinadobrzyn]

Paying now.

Payouts due:

Issue Reporter: NA
Contributor: $250 @rayane-djouah
Contributor+: $250 @s77rt

Eligible for 50% #urgency bonus? No per #16219 (comment)

Upwork job is here

[Christinadobrzyn]

Let me know if I'm missing anything! Closing GH.

[s77rt]

@Christinadobrzyn Functional migration issues are not eligible for the urgency bonus https://expensify.slack.com/archives/C02NK2DQWUX/p1691672264412869. I have refunded the +50%.

[Christinadobrzyn]

Ah thank you @s77rt! @rayane-djouah sounds like the $125 bonus on your payment doesn't apply to this if you can refund it. Sorry for the confusion!

Updated this comment with the payment - #16219 (comment)

[rayane-djouah]

@Christinadobrzyn I have refunded the $125 bonus