[HOLD for payment 2023-06-13] [$250] Migrate LogInWithShortLivedAuthTokenPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/LogInWithShortLivedAuthTokenPage.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: componentDidMount

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aa6985456f56863c
• Upwork Job ID: 1669019963113058304
• Last Price Increase: 2023-06-14

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[marcaaron]

Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

[abdulrahuman5196]

@francoisl Kindly assign me this issue for C+ review

[muxriddinmuqimov77]

I'd like to work on this issue

[francoisl]

Hi @muxriddinmuqimov77, thanks for your interest in this issue. It has already been worked on and a pull request has been merged already.
If you want to find issues to work on, I'd recommend looking for issues with the label Help Wanted, and more generally refer to our contribution guide. Cheers!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor LogInWithShortLivedAuthTokenPage to a functional component #20112

If no regressions arise, payment will be issued on 2023-06-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[abdulrahuman5196]

@francoisl Can we add a BZ member here for payment processing?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aa6985456f56863c

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

@francoisl the AutoAssignerTriage label has been deprecated. Please use Bug for issue triage. See https://stackoverflowteams.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[francoisl]

@adelekennedy FYI this was handled internally, we just need to pay @abdulrahuman5196 for reviewing the PR. Thanks!

[adelekennedy]

@abdulrahuman5196 I just made the job public - will you apply? So i can pay you out?

[abdulrahuman5196]

@adelekennedy Thank you. Applied for the job.

[adelekennedy]

Done!