[HOLD for payment 2023-06-21] mWeb - Workspaces are not immediately displayed when transitioning from OD to ND

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to OD and log in with an account that has a existing workspace
2. Click on Create a company for free

Expected Result:

The user is redirected to the Workspaces list in NewDot and all existing workspaces are displayed

Actual Result:

The user is redirected to NewDot Create a Workspace screen but the existing workspaces are not displayed immediately, it takes >10 seconds to load

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.24-4

Reproducible in staging?: Yes
Reproducible in production?: No - New flow introduced in this PR #20112

If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

SVID_20230606_112406_1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[isagoico]

Issue was found while executing PR #20112 (comment). Added the deploy blocked as I'm unsure if this should be treated as one or not as the prod and stg flows are different atm.

[bondydaa]

@francoisl @srikarparsi assigning you since it looks like it coming from this PR #20112 (comment)

[abdulrahuman5196]

Just copy pasting from here - #20112 (comment)

I think it's the behaviour even without this change(Have to double check though). I think the time delay is for the api to return information about the workspaces present. Even during c+ review same behaviour was observed.
Correct me if wrong @francoisl

[francoisl]

Yeah, this is also how it works on production. The delay is indeed probably because the app has to load workspaces data. As an improvement, we can look into keeping the loading indicator visible while the data is loading, but it's not a blocker / regression.

Production	Staging
screen-20230606-130517.mp4	screen-20230606-130352.mp4

[kevinksullivan]

@francoisl is this a broader performance issue? Should we be tackling it here and/or with a contributor?

[francoisl]

This is just a "visual" issue if you will, we're showing the wrong state of the workspaces list page while data is still loading. I'll handle internally.

[mollfpr]

@francoisl @kevinksullivan Could you assign the issue to me since I got assigned to the PR? Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use withPolicyAndFullscreenLoading in WorkspacesListPage #20543

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR: N/A
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/295030

[kevinksullivan]

@mollfpr offer sent

https://www.upwork.com/jobs/~01147597d87da7cb51

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR. This is a visual improvement while transitioning.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.

Yes!

[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Only available for mWeb

1. Make sure you're signed out of NewDot
2. On OldDOt, sign in to an account that has at least 1 existing workspace
3. After entering your magic code / OTP, tap on "Set up my company for free"
4. Verify A new tab opens to NewDot, and you get automatically signed in
5. Verify you do not see the "Create a new workspace" view for a brief moment before your existing workspaces get listed
6. 👍 or 👎

[francoisl]

👍 but small correction, this flow only happens on mobile web – not web, so the regression steps also only apply to mobile web.

[mollfpr]

Updated the test proposal. Thanks for the correction @francoisl 👍

[francoisl]

Internal issue for regression testing opened here. @kevinksullivan can you take care of payment so we can close this please?

[kevinksullivan]

All set