Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-17] [$250] Migrate ReportActionsView.js to function component #16267

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 42 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. NewFeature Something to build that is a new item.

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

  • src/pages/home/report/ReportActionsView.js
    • type: React.Component
    • has state values: true
    • has refs: true
    • has context: false
    • lifecycle methods: componentDidMount,componentWillUnmount,componentDidUpdate,shouldComponentUpdate

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a5211f387b070380
  • Upwork Job ID: 1673399672865730560
  • Last Price Increase: 2023-06-26
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate ReportActionsView.js to function component [HOLD][$250] Migrate ReportActionsView.js to function component Apr 13, 2023
@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@muxriddinmuqimov77
Copy link

I'd like to work on this issue

@marcaaron marcaaron changed the title [HOLD][$250] Migrate ReportActionsView.js to function component [$250] Migrate ReportActionsView.js to function component Jun 26, 2023
@marcaaron marcaaron added NewFeature Something to build that is a new item. Daily KSv2 labels Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

@melvin-bot melvin-bot bot added the Weekly KSv2 label Jun 26, 2023
@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label Jun 26, 2023
@melvin-bot melvin-bot bot removed the Daily KSv2 label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a5211f387b070380

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 26, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

@Vishrut19
Copy link
Contributor

Dibs?

@rayane-d
Copy link
Contributor

can I work on this?

@olexyt
Copy link
Contributor

olexyt commented Jun 26, 2023

I love to work on this issue

@shawnborton shawnborton removed their assignment Jun 26, 2023
@asadath1395
Copy link

I would love to work on this. Can i get this assigned?

@muttmuure
Copy link
Contributor

We prefer if people focus on 1 issue at a time, so I'm going to assign @rayane-djouah.

@melvin-bot
Copy link

melvin-bot bot commented Jul 3, 2023

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account 🎉

Contributor - [$250] Migrate ReportActionsView.js to function component Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@rayane-d
Copy link
Contributor

rayane-d commented Jul 3, 2023

@muttmuure, can we address this issue regarding the payment amount? I have discovered that this particular component refactor requires a significant amount of work compared to other React class component migration issues.

@rayane-d
Copy link
Contributor

rayane-d commented Jul 4, 2023

@muttmuure

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jul 4, 2023
@rayane-d
Copy link
Contributor

rayane-d commented Jul 4, 2023

PR ready for review.

@rayane-d
Copy link
Contributor

rayane-d commented Jul 4, 2023

@muttmuure @narefyev91 could you review the PR please?

@bernhardoj
Copy link
Contributor

@rayane-djouah please apply the suggestion here #16267 (comment)

@rayane-d
Copy link
Contributor

rayane-d commented Jul 5, 2023

@bernhardoj I applied your suggestion, thanks!

@rayane-d
Copy link
Contributor

rayane-d commented Jul 5, 2023

@narefyev91 could you review the PR please?

@muttmuure
Copy link
Contributor

muttmuure commented Jul 5, 2023

@rayane-djouah feel free to DM me in Slack with more details and I'll chat with the team about this

@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@rayane-d
Copy link
Contributor

rayane-d commented Jul 5, 2023

@neil-marcellini could you review the PR please?

@rayane-d
Copy link
Contributor

rayane-d commented Jul 6, 2023

PR merged

@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 10, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate ReportActionsView.js to function component [HOLD for payment 2023-07-17] [$250] Migrate ReportActionsView.js to function component Jul 10, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 17, 2023
@muttmuure
Copy link
Contributor

All done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

15 participants