-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-07-17] [$250] Migrate ReportActionsView.js to function component #16267
Comments
Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required. |
I'd like to work on this issue |
Triggered auto assignment to @muttmuure ( |
Triggered auto assignment to Design team member for new feature review - @shawnborton ( |
Job added to Upwork: https://www.upwork.com/jobs/~01a5211f387b070380 |
Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 ( |
Dibs? |
can I work on this? |
I love to work on this issue |
I would love to work on this. Can i get this assigned? |
We prefer if people focus on 1 issue at a time, so I'm going to assign @rayane-djouah. |
📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account 🎉 Contributor - [$250] Migrate ReportActionsView.js to function component Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 |
@muttmuure, can we address this issue regarding the payment amount? I have discovered that this particular component refactor requires a significant amount of work compared to other React class component migration issues. |
PR ready for review. |
@muttmuure @narefyev91 could you review the PR please? |
@rayane-djouah please apply the suggestion here #16267 (comment) |
@bernhardoj I applied your suggestion, thanks! |
@narefyev91 could you review the PR please? |
@rayane-djouah feel free to DM me in Slack with more details and I'll chat with the team about this |
Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@neil-marcellini could you review the PR please? |
PR merged |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-07-17. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
All done. |
Class Component Migration
Filenames
React.Component
componentDidMount
,componentWillUnmount
,componentDidUpdate
,shouldComponentUpdate
Task
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: