[HOLD for payment 2023-06-21] [$250] Migrate PaymentMethodList.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/settings/Payments/PaymentMethodList.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a18aae3959b556ca
• Upwork Job ID: 1665813414986407936
• Last Price Increase: 2023-06-05

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[marcaaron]

Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

[dhairyasenjaliya]

I can work on this if goes to external

[multijump]

I would like to work on this issue

[melvin-bot]

@aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[aldo-expensify]

Will make the PR ready for review today.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a18aae3959b556ca

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

[muxriddinmuqimov77]

I'd like to work on this issue

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[aldo-expensify]

@sakluger , this is a code refactor issue, and you only have to handle the payment to the C+ for reviewing the PR #20217

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate PaymentMethodList from class to functional component #20217

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[rushatgabhane]

No cheklist required here because it's a refactor and not a bug.

[sakluger]

Sorry for the delay - @rushatgabhane I've just sent you the offer through Upwork.

[rushatgabhane]

@sakluger accepted, thanks!

[sakluger]

All paid, thanks!