Migrate PaymentMethodList from class to functional component #20217

aldo-expensify · 2023-06-05T22:37:22Z

Details

Fixed Issues

$ #16286

Tests

Click on your Avatar (go to settings)
Click on "Payments" menu entry
Add a paypal account
Add a bank account (Wells fargo / checking or saving)
Add another bank account (Wells fargo / checking or saving)
Add a debit card (testing numbers: https://stripe.com/docs/testing)
Change the bank account set as default method

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-05.at.5.16.32.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…hod-list-to-functional

melvin-bot · 2023-06-06T00:10:26Z

@rushatgabhane @amyevans One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2023-06-06T00:19:53Z

Added Web video, I don't think the others are necessary since this is only a refactor.

aldo-expensify · 2023-06-06T17:07:44Z

src/pages/settings/Payments/PaymentMethodList.js

+    const {actionPaymentMethodType, activePaymentMethodID, bankAccountList, cardList, filterType, network, onPress, payPalMeData, shouldShowSelectedState, selectedMethodID, translate} =
+        props;


Deconstructing props to avoid this type of warning:

rushatgabhane · 2023-06-08T05:22:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

rushatgabhane

@amyevans LGTM

rushatgabhane · 2023-06-08T05:22:27Z

src/pages/settings/Payments/PaymentMethodList.js

+function isPaymentMethodActive(actionPaymentMethodType, activePaymentMethodID, paymentMethod) {
+    return paymentMethod.accountType === actionPaymentMethodType && paymentMethod.methodID === activePaymentMethodID;
+}
+function PaymentMethodList(props) {


Confirmed that we're following the style guide 🎉

https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#should-i-declare-my-components-with-arrow-functions-const-or-the-function-keyword

amyevans

Feel free to self-merge if you don't want to address the NAB

amyevans · 2023-06-08T16:07:07Z

src/pages/settings/Payments/PaymentMethodList.js

-     * @param {String|Number} paymentMethod.methodID
-     * @param {String} paymentMethod.accountType
-     * @return {Boolean}
+     * Show add first payment copy when payment methods are


NAB since you aren't the original author, but can we make this sentence more coherent 😄

Changed to: "Render placeholder when there are no payments methods"

amyevans · 2023-06-08T16:45:26Z

Looks like there's a prettier diff

aldo-expensify · 2023-06-08T17:24:26Z

Looks like there's a prettier diff

Oops, yes, trailing empty space.

OSBotify · 2023-06-08T17:44:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-13T00:33:20Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-13T01:07:29Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

isagoico · 2023-06-13T21:17:51Z

This PR is failing because of this issue - #12913
We're able to reproduce the same message when adding a test debit card

aldo-expensify · 2023-06-13T21:37:48Z

Looks like an unrelated fail, the mentioned issue is very old. Are you saying this is preventing QA? or that this PR caused a regression?

OSBotify · 2023-06-14T21:23:36Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

aldo-expensify added 2 commits June 5, 2023 12:47

Migration to functional component WIP

6a9f0e7

Refactor from class component to Functional component

4431241

aldo-expensify self-assigned this Jun 5, 2023

aldo-expensify added 2 commits June 5, 2023 15:43

Fix watching props warnings

c8f9da3

Merge branch 'main' of github.com:Expensify/App into aldo_payment-met…

b430ef9

…hod-list-to-functional

aldo-expensify marked this pull request as ready for review June 6, 2023 00:09

aldo-expensify requested a review from a team as a code owner June 6, 2023 00:09

melvin-bot bot requested review from amyevans and rushatgabhane and removed request for a team June 6, 2023 00:10

aldo-expensify commented Jun 6, 2023

View reviewed changes

rushatgabhane approved these changes Jun 8, 2023

View reviewed changes

amyevans previously approved these changes Jun 8, 2023

View reviewed changes

Update comment

82545a6

aldo-expensify dismissed amyevans’s stale review via 82545a6 June 8, 2023 16:32

Remove empty space

02e9d77

amyevans approved these changes Jun 8, 2023

View reviewed changes

amyevans merged commit ca59239 into main Jun 8, 2023

amyevans deleted the aldo_payment-method-list-to-functional branch June 8, 2023 17:38

OSBotify mentioned this pull request Jun 12, 2023

Deploy Checklist: New Expensify 2023-06-12 #20640

Closed

71 tasks

aldo-expensify mentioned this pull request Jun 13, 2023

[HOLD for payment 2023-06-21] [$250] Migrate PaymentMethodList.js to function component #16286

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate PaymentMethodList from class to functional component #20217

Migrate PaymentMethodList from class to functional component #20217

aldo-expensify commented Jun 5, 2023 •

edited

Loading

melvin-bot bot commented Jun 6, 2023

aldo-expensify commented Jun 6, 2023

aldo-expensify Jun 6, 2023

rushatgabhane commented Jun 8, 2023 •

edited

Loading

rushatgabhane left a comment

rushatgabhane Jun 8, 2023

amyevans left a comment

amyevans Jun 8, 2023

aldo-expensify Jun 8, 2023

amyevans commented Jun 8, 2023

aldo-expensify commented Jun 8, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

OSBotify commented Jun 13, 2023

isagoico commented Jun 13, 2023

aldo-expensify commented Jun 13, 2023

OSBotify commented Jun 14, 2023

		const {actionPaymentMethodType, activePaymentMethodID, bankAccountList, cardList, filterType, network, onPress, payPalMeData, shouldShowSelectedState, selectedMethodID, translate} =
		props;

Migrate PaymentMethodList from class to functional component #20217

Migrate PaymentMethodList from class to functional component #20217

Conversation

aldo-expensify commented Jun 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 6, 2023

aldo-expensify commented Jun 6, 2023

aldo-expensify Jun 6, 2023

Choose a reason for hiding this comment

rushatgabhane commented Jun 8, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

rushatgabhane Jun 8, 2023

Choose a reason for hiding this comment

amyevans left a comment

Choose a reason for hiding this comment

amyevans Jun 8, 2023

Choose a reason for hiding this comment

aldo-expensify Jun 8, 2023

Choose a reason for hiding this comment

amyevans commented Jun 8, 2023

aldo-expensify commented Jun 8, 2023

OSBotify commented Jun 8, 2023

OSBotify commented Jun 13, 2023

OSBotify commented Jun 13, 2023

isagoico commented Jun 13, 2023

aldo-expensify commented Jun 13, 2023

OSBotify commented Jun 14, 2023

aldo-expensify commented Jun 5, 2023 •

edited

Loading

rushatgabhane commented Jun 8, 2023 •

edited

Loading