[HOLD for payment 2023-04-03] [HOLD for payment 2023-03-31] Chat - Members names overlapping the group conversation header.

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login in staging.new.expensify.com and log in with expensifail account
2. Tap on Fub menu
3. Select New Group
4. Select 8 expensifail participants without name
5. Create a Group

Expected Result:

All text should be correct displayed in page.

Actual Result:

The email address of the participants are overlapping the top header of the group conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.88.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Issue is not reproduced in Production, adding Deploy Blocker

Screen_Recording_20230321_193619_Chrome.mp4

[marcaaron]

This was introduced on this line

https://github.com/tienifr/App/blob/da2a31de533a2aa11dacd25fd0bba3a845b04f97/src/components/DisplayNames/index.js#L103

By the PR here: https://github.com/Expensify/App/pull/15646/files

[avi-shek-jha]

Seems like the same issue was reported here earlier.
#16371

[alex-mechler]

Working on a revert of the offending PR

[alex-mechler]

@tienifr can you comment here so I can assign you?

[tienifr]

Oke. Thanks

[AndrewGable]

Is this resolved? If so can you remove the label and check this off here please? #16345

[alex-mechler]

Yes, this is resolved. Removing the label and checking off

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.88-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix/15438: regression test #16397

If no regressions arise, payment will be issued on 2023-03-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[tienifr]

Regression Test Proposal

Bug: Chat - Members names overlapping the group conversation header.

Proposed Test Steps:

1. Open app
2. Tap on Fub menu
3. Select New Group
4. Select 8 participants without name
5. Create a Group
6. Verify that members names are displayed in the correct position and aren't overlapping the group conversation header.

Do we 👍 or 👎

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix/15438: regression test #16397

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

@alex-mechler, @marcaaron, @adelekennedy, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[marcaaron]

I think it's not overdue - just waiting for the regression period to be over.

[marcaaron]

I think the regression period is over now.

[alex-mechler]

This was a regression from #15646, so I don't believe there is any payments due here. This was caught by applause

[MelvinBot]

@alex-mechler, @marcaaron, @adelekennedy, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@alex-mechler, @marcaaron, @adelekennedy, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[marcaaron]

Ok, so I think we can close it then. Reopen if anyone disagrees.