Deploy Checklist: New Expensify 2023-03-21

[OSBotify]

Release Version: 1.2.88-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix new IOU and Split Bill chats not being unread #15052
• feat: added conditional styles for chat focus mode #15319
• Feat: New Date Picker Design #15343
• fix 15438 maintain white space in display name #15646
• Clear Personal Bank Account Onyx keys in componentWillUnmount #15679
• Show user's thumbnail avatar in the LHN (in Settings button at the top) #15680
• Fix login page urls #15731
• fix avatar border opacity #15736
• Fix navigation to Concierge chat after sign-up/sign-in #15788
• fix: get last actor details from last report action if not present in personal details #15895
• Add square mask for workspace image upload #15975
• Update Spanish translation for sign-in page's welcome text #16003
• update react native picker select #16045
• Make r small within Add reaction tooltip #16047
• Updating secondary action validation to use markdown email regex #16056
• fix/15948: Typing emoji in CAPS doesn’t highlight the text on the emoji suggestion list #16068
• [Snyk] Security upgrade electron from 22.2.0 to 22.3.3 #16071
• Fix: Clicking ctrl+A in the chat also selects the tooltip #16075
• fix codeFence linebreak missing when convert to markdown #16320
• Fix return value for long press #16340
• fix/15438: regression test #16397
• Fix getSmallSizeAvatar to block url is not from cloudfront #16441

Internal QA:

• Update root AASA content-type #16077 - @justinpersaud

Deploy Blockers:

• [PAID] [$1000] Setting - Console error appears and avatar is broken when uploading a photo to the profile #16354
• Android - Profile-Previously selected data is highlighted with circle, but newly selected-with square #16375
• [HOLD for payment 2023-04-03] [HOLD for payment 2023-03-31] Chat - Members names overlapping the group conversation header. #16376

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

[marcochavezf]

Checking off #16077, the file was updated correctly on staging.

[mvtglobally]

@AndrewGable We do not have Android build yet. Can you check if there is an issue with Google

[AndrewGable]

Yes, there was an issue

[AndrewGable]

Should be good now @mvtglobally !

[mvtglobally]

@AndrewGable all good, we are testing

[mvtglobally]

@AndrewGable We are still working on the regression. Below is the interim summary

Deploy Blocker
#16376

Action needed
PR #15343 is failing #16358 & #16375. not repro in PROD, but we didn't add Blocker label as its new feature. pls double check
PR #15975 is failing #16354 NOT repro in prod. pls double check if not a blocker as it seems a new update

Just FYI
PR #16003 is failing #16374. Repro in PROD checking off
PR #16340 old KI is still repro. Checking off
PR #15731 is failing #16357. repro in PROD checking off
PR #15736 is failing #16377. repro in PROD checking off

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.88-1 🚀

[mvtglobally]

Regression is completed @AndrewGable

Final status
PR #15679 is failing #16386 and blocked on iOS
PR #15343 is failing #16358 & #16375. not repro in PROD, but we didn't add Blocker label as its new feature. pls double check
PR #15975 is failing #16354 NOT repro in prod. pls double check if not a blocker as it seems a new update

And we are checking CP #16397 once it's deployed

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.88-1 has been deployed to staging 🎉

[mvtglobally]

Checking off #16937

[alex-mechler]

Checking off #16376

[mvtglobally]

@AndrewGable can we push this through a bit. Would love to get a new checklist today

[AndrewGable]

Added deploy blockers to those issues that we felt were blockers, waiting on those to be finished.

[AndrewGable]

Letting one CP finish then going to deploy

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.88-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.88-2 has been deployed to staging 🎉

[AndrewGable]