Fix new IOU and Split Bill chats not being unread #15052

puneetlath · 2023-02-10T19:38:43Z

Details

Previously, when you send an IOU or split bill request to a person/group you've never chatted with before the chat was not showing as unread for the recipients. This fixes that.

Fixed Issues

$ #13913

Tests

In separate windows/apps sign into accountA and accountB who have never chatted
While both accounts are open, send an IOU request from accountB to accountA
The chat with the IOU request should show up in the LHN for accountA as unread
Sign into accountC that has never chatted with A or B (while A or B is still open in another window/app)
Send a split bill request to A and B
The split bill group chat should show up in the LHN for account A and B as unread

Verify that no errors appear in the JS console

Offline tests

Not applicable. You need to be online to receive the request from the other user.

QA Steps

In separate windows/apps sign into accountA and accountB who have never chatted
While both accounts are open, send an IOU request from accountB to accountA
The chat with the IOU request should show up in the LHN for accountA as unread
Sign into accountC that has never chatted with A or B (while A or B is still open in another window/app)
Send a split bill request to A and B
The split bill group chat should show up in the LHN for account A and B as unread

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

MelvinBot · 2023-02-10T20:12:43Z

@parasharrajat @aldo-expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

puneetlath · 2023-02-10T20:26:50Z

Wait. Not quite ready for review. Got a failing Jest test.

puneetlath · 2023-02-10T21:03:45Z

Ok @parasharrajat @aldo-expensify we should be good to go now!

src/libs/actions/Report.js

puneetlath · 2023-02-11T20:00:01Z

src/libs/actions/Report.js

@@ -660,7 +661,7 @@ function handleReportChanged(report) {
    // A report can be missing a name if a comment is received via pusher event
    // and the report does not yet exist in Onyx (eg. a new DM created with the logged in person)
    if (report.reportID && report.reportName === undefined) {
-        openReport(report.reportID);
+        reconnectToReport(report.reportID);


@parasharrajat this is the change that solves the issue. When the IOU transaction comes in from pusher, we were previously calling openReport, even though the user wasn't actually opening the report, which would mark the report as read.

I instead updated that to call reconnectToReport which fetches the report data without marking it as read.

Yeah, I noticed after adding the comment. But wanted to know your expected scope for this change. I will test it.

src/libs/actions/Report.js

puneetlath · 2023-02-14T01:05:04Z

@parasharrajat @aldo-expensify ready for another review.

puneetlath · 2023-02-14T16:23:03Z

Bump @parasharrajat

src/libs/actions/Report.js

aldo-expensify

Looks good to me!

puneetlath · 2023-02-15T15:05:29Z

@parasharrajat bump on review please!

parasharrajat · 2023-02-15T15:27:11Z

I will test it in a few minutes.

parasharrajat · 2023-02-15T20:54:06Z

Reviewing now.

It seems the openReport call was added in #12157. Basically, we wanted to move to the open API. The old logic was fetching the report data from the backend. But not marking it as read.

So it seems the changes here are correct.

It seems we added this handleReportChanged handler as fall-safe based on the design that always considers report data incomplete on the client side.

Now, I need to make sure that there is no user action that used to depend on this logic to fetch the correct report data including marking the report read.

It could be opening a report directly but we already have tons of checks to mark the report read, like the report becomes visible, the page comes to focus, and the report changed.

puneetlath · 2023-02-16T15:46:50Z

That makes sense @parasharrajat. What did you find when testing? Does everything work as expected?

parasharrajat · 2023-02-16T17:07:08Z

Still testing a few things. I will complete it today itself and we can merge it if no bugs.

parasharrajat · 2023-02-16T23:21:58Z

It seems to not work for me. Any thought?

screen-2023-02-17_04.50.38.mp4

aldo-expensify · 2023-02-16T23:47:55Z

It seems to not work for me. Any thought?

:( this is a pain in the ass to test. I tested on web, and it worked for me, not sure why it may not be working there... maybe the behaviour is not consistent and I was just lucky

puneetlath · 2023-02-17T00:18:54Z

That seems to be the case at least on dev. I'll test against the staging API as well.

parasharrajat · 2023-02-17T20:55:51Z

Test cases

Open the newly created report directly via URL in a new browser session after creating it from another device.
Open two browser sessions at a time affixed together. Do not focus on the receiver window. Send an IOU message from the first focused window to a new chat.
Try for requests, split bills, and send money.
Try with normal messages.
Keep the app open on Android|iOS with a new account. Send a message from another device. Notice unread messages on android|iOS.
Try shrinking the browser window width to mobile view, or from mobile view to desktop view,
Blur a window session and send a new chat message to the blurred window. Focus it.
Switch tabs on the same browser.
Try Offline for all above.

puneetlath · 2023-03-08T21:01:21Z

Merged the Auth PR. So this should be ready for testing again soon.

puneetlath · 2023-03-09T15:53:19Z

Ok the Auth PR has been deployed and I've merged main. Thanks for your patience here.

@parasharrajat can you please re-review/re-test?

parasharrajat · 2023-03-09T15:53:51Z

Sure.

puneetlath · 2023-03-14T16:22:29Z

@parasharrajat just wanted to get a sense of when you think you'll be able to review/test this one.

parasharrajat · 2023-03-14T17:02:38Z

Oops, I missed it. I will review this today

aldo-expensify

LGTM

Split bill / request money

Screen.Recording.2023-03-14.at.10.28.54.AM.mov

Send normal message

Screen.Recording.2023-03-14.at.10.32.05.AM.mov

parasharrajat · 2023-03-15T15:27:28Z

Still testing but it will be completed today.

puneetlath · 2023-03-16T15:04:06Z

@parasharrajat how is the testing going?

parasharrajat · 2023-03-16T15:05:33Z

Just started for today...It will be completed in 2 hours with the checklist.

parasharrajat · 2023-03-16T20:20:24Z

Screenshots

🔲 iOS / native

screen-2023-03-17_04.00.08.mp4

🔲 MacOS / Chrome

screen-2023-03-17_01.46.37.mp4

screen-2023-03-17_02.43.38.mp4

🔲 Android / Chrome

screen-2023-03-17_02.46.54.mp4

parasharrajat · 2023-03-16T20:32:43Z

No, it is working this time. Just posting screenshots.

aldo-expensify · 2023-03-16T20:43:47Z

No, it is working this time. Just posting screenshots.

Oh, sorry, I saw poorly your video hehe, now I see it shows bolded (unread) 🎉

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

cc: @aldo-expensify

🎀 👀 🎀 C+ reviewed

parasharrajat · 2023-03-16T22:38:50Z

I found one issue where displayName is not correct the first time when the report is created. It is the email of the user but that user has a custom displayName.

Check this video https://user-images.githubusercontent.com/24370807/225768184-d9f1a38e-864f-4811-9efa-28766d2162c8.mp4

Ignore the first money request as I used the wrong email thus report was not shown on iOS App.

puneetlath · 2023-03-19T21:33:40Z

Hmm, yes you're right. I just tried on main and that also seems to be a problem there. So I'm going to go ahead and merge this. Could you report that as a separate issue in #expensify-bugs please? Thanks!

OSBotify · 2023-03-19T21:37:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-21T16:06:25Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.2.88-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-21T18:11:16Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.2.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-24T23:59:58Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-03-27T09:46:22Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Use reconnect instead of openReport in handleReportChanged

efc79b1

puneetlath self-assigned this Feb 10, 2023

puneetlath marked this pull request as ready for review February 10, 2023 20:12

puneetlath requested a review from a team as a code owner February 10, 2023 20:12

melvin-bot bot requested review from aldo-expensify and parasharrajat and removed request for a team February 10, 2023 20:12

Merge branch 'main' into iou-unread

9952752

puneetlath added 2 commits February 10, 2023 15:56

Add report name to optimistic data in reconnectToReport

d002ab7

Rename reconnect to reconnectToReport to match API call

29095d8

parasharrajat reviewed Feb 10, 2023

View reviewed changes

src/libs/actions/Report.js Show resolved Hide resolved

puneetlath commented Feb 11, 2023

View reviewed changes

src/libs/actions/Report.js Outdated Show resolved Hide resolved

Change function name back to reconnect

b22e7f7

puneetlath requested a review from parasharrajat February 14, 2023 01:04

aldo-expensify reviewed Feb 14, 2023

View reviewed changes

src/libs/actions/Report.js Show resolved Hide resolved

Add comment explaining why we call reconnect

9baa084

aldo-expensify approved these changes Feb 14, 2023

View reviewed changes

Merge branch 'main' into iou-unread

20dee61

aldo-expensify self-requested a review March 8, 2023 21:31

Merge branch 'main' into iou-unread

ddd671a

aldo-expensify approved these changes Mar 14, 2023

View reviewed changes

This comment was marked as resolved.

Sign in to view

parasharrajat approved these changes Mar 16, 2023

View reviewed changes

puneetlath merged commit 382d167 into main Mar 19, 2023

puneetlath deleted the iou-unread branch March 19, 2023 21:33

OSBotify mentioned this pull request Mar 21, 2023

Deploy Checklist: New Expensify 2023-03-21 #16345

Closed

28 tasks

MelvinBot mentioned this pull request Mar 24, 2023

[HOLD for payment 2023-03-31] IOU and Split Bill chats not showing as unread #13913

Closed

6 tasks

Fix new IOU and Split Bill chats not being unread #15052

Fix new IOU and Split Bill chats not being unread #15052

Conversation

puneetlath commented Feb 10, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Feb 10, 2023

puneetlath commented Feb 10, 2023

puneetlath commented Feb 10, 2023

puneetlath Feb 11, 2023

Choose a reason for hiding this comment

parasharrajat Feb 12, 2023

Choose a reason for hiding this comment

puneetlath commented Feb 14, 2023

puneetlath commented Feb 14, 2023

aldo-expensify left a comment

Choose a reason for hiding this comment

puneetlath commented Feb 15, 2023

parasharrajat commented Feb 15, 2023

parasharrajat commented Feb 15, 2023 • edited Loading

puneetlath commented Feb 16, 2023

parasharrajat commented Feb 16, 2023 • edited Loading

parasharrajat commented Feb 16, 2023

aldo-expensify commented Feb 16, 2023

puneetlath commented Feb 17, 2023

parasharrajat commented Feb 17, 2023

puneetlath commented Mar 8, 2023

puneetlath commented Mar 9, 2023

parasharrajat commented Mar 9, 2023

puneetlath commented Mar 14, 2023

parasharrajat commented Mar 14, 2023

aldo-expensify left a comment

Choose a reason for hiding this comment

parasharrajat commented Mar 15, 2023

puneetlath commented Mar 16, 2023

parasharrajat commented Mar 16, 2023

parasharrajat commented Mar 16, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 MacOS / Chrome

🔲 Android / Chrome

This comment was marked as resolved.

parasharrajat commented Mar 16, 2023 • edited Loading

aldo-expensify commented Mar 16, 2023

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

parasharrajat commented Mar 16, 2023 • edited Loading

puneetlath commented Mar 19, 2023

OSBotify commented Mar 19, 2023

OSBotify commented Mar 21, 2023

OSBotify commented Mar 21, 2023

OSBotify commented Mar 24, 2023

OSBotify commented Mar 27, 2023

puneetlath commented Feb 10, 2023 •

edited

Loading

parasharrajat commented Feb 15, 2023 •

edited

Loading

parasharrajat commented Feb 16, 2023 •

edited

Loading

parasharrajat commented Mar 16, 2023 •

edited

Loading

parasharrajat commented Mar 16, 2023 •

edited

Loading

parasharrajat commented Mar 16, 2023 •

edited

Loading