Remove deprecated createOrFetchReport method #12157

stitesExpensify · 2022-10-26T20:50:34Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/238801

Tests

Create a new chat with a single user and make sure there are no errors
Create a new chat with multiple users and make sure there are no errors
Open an existing chat from the LeftHandNav and make sure the report opens correctly
Open the search panel, find an existing chat and choose it. Make sure the report opens correctly
Send an IOU and make sure there are no errors
Go to that IOU on another account and pay it off

Verify that no errors appear in the JS console

QA Steps

Create a new chat with a single user and make sure there are no errors
Create a new chat with multiple users and make sure there are no errors
Open an existing chat from the LeftHandNav and make sure the report opens correctly
Open the search panel, find an existing chat and choose it. Make sure the report opens correctly
Send an IOU and make sure there are no errors
Go to that IOU on another account and pay it off

Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

2022-11-03_13-59-15.mp4

Mobile Web - Chrome

2022-11-03_13-57-20.mp4

Mobile Web - Safari

2022-11-03_15-17-07.mp4

Desktop

2022-11-03_14-18-12.mp4

iOS

2022-11-03_15-16-00.mp4

Android

2022-11-03_14-14-04.mp4

…xist, and call openReport to get new messages if they exist

…xist

roryabraham

Heads up – there were a few extra changes from this PR that we should include over here

…ateOrFetch

stitesExpensify · 2022-11-02T20:07:50Z

src/libs/Navigation/AppNavigator/AuthScreens.js

@@ -86,7 +86,6 @@ class AuthScreens extends React.Component {
        super(props);

        Timing.start(CONST.TIMING.HOMEPAGE_INITIAL_RENDER);
-        Timing.start(CONST.TIMING.HOMEPAGE_REPORTS_LOADED);


This timer was being started but never stopped / recorded, because the stop for it was in fetchAllReports, which was no longer being called anywhere.

stitesExpensify · 2022-11-02T20:11:54Z

cc @Julesssss since you graciously volunteered to make sure I didn't break IOUs with this <3

melvin-bot · 2022-11-02T20:14:08Z

Looks like you modified deprecatedAPI.js! To be clear, you should not be adding any code to this file.

Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands.

Unsure if your change is okay? Drop a note in #expensify-open-source!

stitesExpensify · 2022-11-02T20:14:19Z

Also if anyone can think of other test cases based on the code this touches, please suggest it!

Julesssss

Testing well for me 👍

stitesExpensify · 2022-11-09T16:52:32Z

Awesome! @roryabraham @thienlnam if you guys could review so we can merge this after today's web deploy that would be great!

roryabraham

According to the React Native Upgrade Helper, it looks like we shouldn't commit that contents.xcworkspacedata file. I don't really know if it matters, but I'd suggest just adding it to the .gitignore since it was explicitly removed from the template app at some point.

stitesExpensify · 2022-11-09T18:26:43Z

Nice catch. Remove the file!

stitesExpensify · 2022-11-09T18:27:11Z

Just need @thienlnam for the final review!

JmillsExpensify · 2022-11-09T21:33:51Z

Who's taking care of the PR Reviewer checklist?

thienlnam · 2022-11-09T23:28:59Z

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

OSBotify · 2022-11-09T23:46:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-11-11T03:39:54Z

🚀 Deployed to staging by @thienlnam in version: 1.2.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-11-15T21:10:38Z

🚀 Deployed to production by @roryabraham in version: 1.2.27-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2022-11-16T00:18:31Z

🚀 Deployed to production by @roryabraham in version: 1.2.27-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

neil-marcellini · 2022-11-19T01:12:54Z

src/libs/actions/Report.js

@@ -708,6 +510,7 @@ function openReport(reportID, participantList = [], newReportObject = {}) {
                isLoadingMoreReportActions: false,
                lastVisitedTimestamp: Date.now(),
                lastReadSequenceNumber: getMaxSequenceNumber(reportID),
+                reportName: CONST.REPORT.DEFAULT_REPORT_NAME,


This caused a regression. Whenever a report is opened the name is reset to the default, and it's only set back to the proper name, like #admins, when the response comes back.

Thanks for letting me know and taking care of it!

parasharrajat · 2023-03-30T19:26:23Z

src/libs/actions/Report.js

@@ -969,7 +791,7 @@ function handleReportChanged(report) {
    // A report can be missing a name if a comment is received via pusher event
    // and the report does not yet exist in Onyx (eg. a new DM created with the logged in person)
    if (report.reportID && report.reportName === undefined) {
-        fetchChatReportsByIDs([report.reportID]);
+        openReport(report.reportID);


Calling OpenReport here caused a regression #13913 . OpenReport also marks the report as read.

stitesExpensify added 7 commits October 26, 2022 12:49

Just navigate to the concierge chat right away since it will always e…

6ed4868

…xist, and call openReport to get new messages if they exist

Move navigating or creating logic to report actions

b49f4de

Just navigate to the concierge chat right away since it will always e…

e90b58c

…xist

Remove uses of fetchOrCreateReport

e8b3448

Remove unused fetchAllReports method

7bccf56

Remove deprecated fetchOrCreateChatReport method

17bda6f

Switch to navigate method

3a7c17c

stitesExpensify self-assigned this Oct 26, 2022

stitesExpensify added 5 commits October 26, 2022 15:09

remove fetchChatReportsByIDs

9ff5456

Fix comment

1ef2f2e

Remove unused method fetchIOUReportID

977b22f

Remove unused imports

1417e8f

Update name to better represent action taken

adaa619

roryabraham mentioned this pull request Nov 1, 2022

Remove unused report functions #12357

Closed

92 tasks

roryabraham reviewed Nov 2, 2022

View reviewed changes

stitesExpensify added 5 commits November 2, 2022 14:03

Merge branch 'main' of github.com:Expensify/App into stites-removeCre…

02f5ed6

…ateOrFetch

Remove unused method

95e3e8d

Fix documentation since fetchOrCreate has been removed

0a8b57b

Remove timing because it is no longer being ended

93a778f

Remove unused constants

bf8f0c7

stitesExpensify commented Nov 2, 2022

View reviewed changes

stitesExpensify marked this pull request as ready for review November 2, 2022 20:11

stitesExpensify requested a review from a team as a code owner November 2, 2022 20:11

melvin-bot bot requested review from rushatgabhane and thienlnam and removed request for a team November 2, 2022 20:11

stitesExpensify requested a review from Julesssss November 2, 2022 20:12

Julesssss previously approved these changes Nov 9, 2022

View reviewed changes

roryabraham previously approved these changes Nov 9, 2022

View reviewed changes

Remove unused file

d827fc4

stitesExpensify dismissed stale reviews from roryabraham and Julesssss via d827fc4 November 9, 2022 18:26

thienlnam approved these changes Nov 9, 2022

View reviewed changes

thienlnam changed the title ~~[Hold https://github.com/Expensify/Web-Expensify/pull/35476] Remove deprecated createOrFetchReport method~~ Remove deprecated createOrFetchReport method Nov 9, 2022

thienlnam merged commit 97e75a8 into main Nov 9, 2022

thienlnam deleted the stites-removeCreateOrFetch branch November 9, 2022 23:41

OSBotify mentioned this pull request Nov 11, 2022

Deploy Checklist: New Expensify 2022-11-11 #12662

Closed

27 tasks

dangrous mentioned this pull request Nov 11, 2022

Android - Chat - App is crashed after sent the message #12666

Closed

Puneet-here mentioned this pull request Nov 16, 2022

[$250] Unable to create a chat when offline from search page reported by @Puneet-here #12378

Closed

Ollyws mentioned this pull request Nov 17, 2022

[Hold for Payment: 2022-12-09] [$250] LHN - Opening <EXPENSIFY_URL>/concierge, system redirected to LHN #12776

Closed

This was referenced Nov 19, 2022

Prevent calling OpenReport on optimistic rooms #12874

Closed

BUG: Chat Report shown instead of room title when created offline #12629

Closed

neil-marcellini reviewed Nov 19, 2022

View reviewed changes

parasharrajat mentioned this pull request Feb 15, 2023

Fix new IOU and Split Bill chats not being unread #15052

Merged

54 tasks

parasharrajat reviewed Mar 30, 2023

View reviewed changes

parasharrajat mentioned this pull request Mar 30, 2023

[HOLD for payment 2023-03-31] IOU and Split Bill chats not showing as unread #13913

Closed

6 tasks

abdulrahuman5196 mentioned this pull request Jun 21, 2023

[HOLD for payment 2023-06-19] [$1000] Title gets updated after a brief moment if edited right after creating the task #19478

Closed

6 tasks

ntdiary mentioned this pull request Apr 25, 2024

Fix blank screen is shown when opening a report screen after relaunching app #37596

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated createOrFetchReport method #12157

Remove deprecated createOrFetchReport method #12157

stitesExpensify commented Oct 26, 2022 •

edited

Loading

roryabraham left a comment

stitesExpensify Nov 2, 2022

stitesExpensify commented Nov 2, 2022

melvin-bot bot commented Nov 2, 2022

stitesExpensify commented Nov 2, 2022

Julesssss left a comment

stitesExpensify commented Nov 9, 2022

roryabraham left a comment

stitesExpensify commented Nov 9, 2022

stitesExpensify commented Nov 9, 2022

JmillsExpensify commented Nov 9, 2022

thienlnam commented Nov 9, 2022

PR Reviewer Checklist

OSBotify commented Nov 9, 2022

OSBotify commented Nov 11, 2022

OSBotify commented Nov 15, 2022

OSBotify commented Nov 16, 2022

neil-marcellini Nov 19, 2022

stitesExpensify Nov 28, 2022

parasharrajat Mar 30, 2023

Remove deprecated createOrFetchReport method #12157

Remove deprecated createOrFetchReport method #12157

Conversation

stitesExpensify commented Oct 26, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Review Checklist

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

roryabraham left a comment

Choose a reason for hiding this comment

stitesExpensify Nov 2, 2022

Choose a reason for hiding this comment

stitesExpensify commented Nov 2, 2022

melvin-bot bot commented Nov 2, 2022

stitesExpensify commented Nov 2, 2022

Julesssss left a comment

Choose a reason for hiding this comment

stitesExpensify commented Nov 9, 2022

roryabraham left a comment

Choose a reason for hiding this comment

stitesExpensify commented Nov 9, 2022

stitesExpensify commented Nov 9, 2022

JmillsExpensify commented Nov 9, 2022

thienlnam commented Nov 9, 2022

PR Reviewer Checklist

OSBotify commented Nov 9, 2022

OSBotify commented Nov 11, 2022

OSBotify commented Nov 15, 2022

OSBotify commented Nov 16, 2022

neil-marcellini Nov 19, 2022

Choose a reason for hiding this comment

stitesExpensify Nov 28, 2022

Choose a reason for hiding this comment

parasharrajat Mar 30, 2023

Choose a reason for hiding this comment

stitesExpensify commented Oct 26, 2022 •

edited

Loading