Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new IOU and Split Bill chats not being unread #15052

Merged
merged 8 commits into from
Mar 19, 2023
+4 −3
Merged

Fix new IOU and Split Bill chats not being unread #15052

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
efc79b1
Use reconnect instead of openReport in handleReportChanged
puneetlath Feb 10, 2023
9952752
Merge branch 'main' into iou-unread
puneetlath Feb 10, 2023
d002ab7
Add report name to optimistic data in reconnectToReport
puneetlath Feb 10, 2023
29095d8
Rename reconnect to reconnectToReport to match API call
puneetlath Feb 10, 2023
b22e7f7
Change function name back to reconnect
puneetlath Feb 14, 2023
9baa084
Add comment explaining why we call reconnect
puneetlath Feb 14, 2023
20dee61
Merge branch 'main' into iou-unread
puneetlath Feb 23, 2023
ddd671a
Merge branch 'main' into iou-unread
puneetlath Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/libs/actions/Report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ function reconnect(reportID) {
value: {
isLoadingReportActions: true,
isLoadingMoreReportActions: false,
reportName: lodashGet(allReports, [reportID, 'reportName'], CONST.REPORT.DEFAULT_REPORT_NAME),
puneetlath marked this conversation as resolved.
Show resolved Hide resolved
},
}],
successData: [{
Expand Down Expand Up @@ -657,10 +658,10 @@ function handleReportChanged(report) {
}
}

// A report can be missing a name if a comment is received via pusher event
// and the report does not yet exist in Onyx (eg. a new DM created with the logged in person)
// A report can be missing a name if a comment is received via pusher event and the report does not yet exist in Onyx (eg. a new DM created with the logged in person)
// In this case, we call reconnect so that we can fetch the report data without marking it as read
if (report.reportID && report.reportName === undefined) {
openReport(report.reportID);
reconnect(report.reportID);
puneetlath marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down