-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD 16078][$1000] [Android mWeb] Expanded composer is smaller than initial composer on full screen with keyboard #16446
Comments
Triggered auto assignment to @conorpendergrast ( |
Bug0 Triage Checklist (Main S/O)
|
Using this to test on Android - https://stackoverflowteams.com/c/expensify/questions/14817 |
Couldn't reproduce via BrowserStack, will try and get some help to reproduce tomorrow |
Thanks so much Sheena! @tienifr Do you recall any more specific reproduction details that might help us out here? |
If you're using GBoard, try to make the keyboard as tall as possible.
Try to use a small screen device. Mine is Pixel XL with 5.5". I think that this only happens when the expanded composer may overlap the Report Page underneath. |
@conorpendergrast Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I've tried reproducing on a Pixel 3 XL via BrowserStack, with the GBoard, with number row enabled and keyboard height set to extra tall, and the expanded composer is still larger. @strepanier03 Could you try once more on a physical device again? |
All I can test on is a Google Pixel 6 pro which has a 6.7 inch screen, I don't have a smaller option. I am already using Gboard (it's the default for my phone) and after setting the keyboard to extra tall I am still unable to recreate the behavior. The expanded composer is still larger than the composer not expanded. |
@strepanier03 Could you help try again on mWeb on Google Pixel 6 pro? If you still can't reproduce it, we should close this GH issue |
Sure thing @tienifr I'll give that a go now. |
@conorpendergrast, @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@conorpendergrast - Not sure if you want to raise this internally for more discussion or move forward but it seems a bit more on the edge case side of things to me. |
Yeah, I can do that, thanks for reproducing it Sheena! Unassigning you |
Actually, I do think we should fix this - it's a reproducible bug (albeit one that probably almost no one will encounter). Let's do it! |
same sameeeee |
Held |
@MonilBhavsar still on hold? |
Yes! Latest update was here #16078 (comment) |
cool cool, ty!! |
held |
Held |
@MonilBhavsar any updates>? |
Still HELD |
sameeee |
hold |
Same |
1 similar comment
Same |
sameee |
Same unfortunately, though not a high priority |
held |
This seems like a dupe of #18528 (comment) to me, so I'm going to close. But let me know if I've misunderstood. |
On Hold for #16078
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The expanding composer shouldn’t be smaller than the composer when not expanding
Actual Result:
The expanding composer is smaller than the composer when not expanding
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.88-0
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
untitled_8cYI9g0K.mp4
336487508_6064504626972700_1043818239111593346_n.1.mp4
336326475_6003994583025969_8435466939690746951_n.mp4
Expensify/Expensify Issue URL:
Issue reported by: @tienifr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679330011130849?thread_ts=1679302259.813049&cid=C049HHMV9SM
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: