Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD 16078][$1000] [Android mWeb] Expanded composer is smaller than initial composer on full screen with keyboard #16446

Closed
1 of 6 tasks
kavimuru opened this issue Mar 23, 2023 · 100 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Improvement Item broken or needs improvement. Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Mar 23, 2023

On Hold for #16078

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open chat
  3. Open Keyboard
  4. Enter multiple lines
  5. Expand the composer
  6. Observe the full composer is smaller than before

Expected Result:

The expanding composer shouldn’t be smaller than the composer when not expanding

Actual Result:

The expanding composer is smaller than the composer when not expanding

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native ( only reproduced on phone which have the big keyboard)
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.88-0
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

  • Samsung A30, Android 10
  • Samsung A53, Android 13
  • pixel xl
untitled_8cYI9g0K.mp4
336487508_6064504626972700_1043818239111593346_n.1.mp4
336326475_6003994583025969_8435466939690746951_n.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tienifr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679330011130849?thread_ts=1679302259.813049&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f2b3ecb55fe13e7b
  • Upwork Job ID: 1643602791840743424
  • Last Price Increase: 2023-04-05
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 23, 2023
@MelvinBot
Copy link

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 23, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kavimuru kavimuru added the Needs Reproduction Reproducible steps needed label Mar 23, 2023
@conorpendergrast
Copy link
Contributor

Using this to test on Android - https://stackoverflowteams.com/c/expensify/questions/14817

@conorpendergrast
Copy link
Contributor

Couldn't reproduce via BrowserStack, will try and get some help to reproduce tomorrow

@conorpendergrast
Copy link
Contributor

Seeking assistance here

@strepanier03
Copy link
Contributor

I tested this for Conor and I cannot recreate.

Testing notes

Phone: Pixel 6
OS: Android
Keyboard: Standard Android keyboard

Screenshots

Screenshot_20230324-110520


Screenshot_20230324-110557

@conorpendergrast
Copy link
Contributor

Thanks so much Sheena!

@tienifr Do you recall any more specific reproduction details that might help us out here?

@tienifr
Copy link
Contributor

tienifr commented Mar 27, 2023

If you're using GBoard, try to make the keyboard as tall as possible.

  1. Click on GBoard Settings icon > Preferences
  2. Turn on Number row
  3. Click Keyboard height
  4. Select Extra-tall

Try to use a small screen device. Mine is Pixel XL with 5.5".

I think that this only happens when the expanded composer may overlap the Report Page underneath.

@melvin-bot melvin-bot bot added the Overdue label Mar 27, 2023
@MelvinBot
Copy link

@conorpendergrast Whoops! This issue is 2 days overdue. Let's get this updated quick!

@conorpendergrast
Copy link
Contributor

I've tried reproducing on a Pixel 3 XL via BrowserStack, with the GBoard, with number row enabled and keyboard height set to extra tall, and the expanded composer is still larger.

@strepanier03 Could you try once more on a physical device again?

@strepanier03
Copy link
Contributor

All I can test on is a Google Pixel 6 pro which has a 6.7 inch screen, I don't have a smaller option.

I am already using Gboard (it's the default for my phone) and after setting the keyboard to extra tall I am still unable to recreate the behavior. The expanded composer is still larger than the composer not expanded.

Screenshot_20230329-171606

@tienifr
Copy link
Contributor

tienifr commented Mar 30, 2023

@strepanier03 Could you help try again on mWeb on Google Pixel 6 pro? If you still can't reproduce it, we should close this GH issue

@strepanier03
Copy link
Contributor

Sure thing @tienifr I'll give that a go now.

@strepanier03
Copy link
Contributor

strepanier03 commented Mar 31, 2023

So oddly, on mWeb I can recreate this. The expanded compose field is just the barest tiniest bit smaller than unexpanded. It's almost not a noticeable change. Below is another side-by-side.

Screenshot_20230330-202950

@melvin-bot melvin-bot bot added the Overdue label Apr 3, 2023
@MelvinBot
Copy link

@conorpendergrast, @strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03
Copy link
Contributor

@conorpendergrast - Not sure if you want to raise this internally for more discussion or move forward but it seems a bit more on the edge case side of things to me.

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2023
@conorpendergrast
Copy link
Contributor

Yeah, I can do that, thanks for reproducing it Sheena! Unassigning you

@conorpendergrast conorpendergrast removed the Needs Reproduction Reproducible steps needed label Apr 5, 2023
@conorpendergrast
Copy link
Contributor

conorpendergrast commented Apr 5, 2023

Actually, I do think we should fix this - it's a reproducible bug (albeit one that probably almost no one will encounter). Let's do it!

@conorpendergrast conorpendergrast added the External Added to denote the issue can be worked on by a contributor label Apr 5, 2023
@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@dylanexpensify
Copy link
Contributor

same sameeeee

@dylanexpensify
Copy link
Contributor

Held

@dylanexpensify
Copy link
Contributor

@MonilBhavsar still on hold?

@MonilBhavsar
Copy link
Contributor

Yes! Latest update was here #16078 (comment)

@dylanexpensify
Copy link
Contributor

cool cool, ty!!

@dylanexpensify
Copy link
Contributor

held

@dylanexpensify
Copy link
Contributor

Held

@dylanexpensify
Copy link
Contributor

@MonilBhavsar any updates>?

@melvin-bot melvin-bot bot removed the Overdue label Apr 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2024
@MonilBhavsar
Copy link
Contributor

Still HELD

@melvin-bot melvin-bot bot removed the Overdue label Apr 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@dylanexpensify
Copy link
Contributor

sameeee

@melvin-bot melvin-bot bot removed the Overdue label Apr 29, 2024
@melvin-bot melvin-bot bot added the Overdue label May 7, 2024
@dylanexpensify
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@dylanexpensify
Copy link
Contributor

Same

1 similar comment
@dylanexpensify
Copy link
Contributor

Same

@dylanexpensify
Copy link
Contributor

sameee

@dylanexpensify
Copy link
Contributor

Same unfortunately, though not a high priority

@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2024
@dylanexpensify
Copy link
Contributor

held

@melvin-bot melvin-bot bot removed the Overdue label Jun 17, 2024
@puneetlath
Copy link
Contributor

This seems like a dupe of #18528 (comment) to me, so I'm going to close. But let me know if I've misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Improvement Item broken or needs improvement. Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests