Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field #18528

Closed
1 of 6 tasks
kbecciv opened this issue May 6, 2023 · 45 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented May 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with any account
  3. Navigate to any conversation
  4. Focus on the compose box and start typing in a quick manner
  5. Type several lines until a button appears to expand the input field

Expected Result:

User can enlarge the compose box and view the text.

Actual Result:

Compose box does not increase when user is trying to expand the input field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.11.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6044941_Screen_Recording_20230506_181042_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0153ba2368067fa39f
  • Upwork Job ID: 1664776867304271872
  • Last Price Increase: 2024-06-20
Issue OwnerCurrent Issue Owner: @
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 6, 2023

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 6, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label May 8, 2023
@mallenexpensify
Copy link
Contributor

mallenexpensify commented May 8, 2023

I was unable to reproduce at first, unless it's supposed to expand more.

2023-05-08_14-40-14.mp4

Then, after, I kept playing around with and I think I maybe/sorta reproduced?

2023-05-08_14-41-35.mp4

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2023
@mallenexpensify
Copy link
Contributor

Checking in #QA on what expected behaviour is
https://expensify.slack.com/archives/C9YU7BX5M/p1683582657416369

@isagoico
Copy link

isagoico commented May 9, 2023

When comparing the app behavior with the mWeb behavior I see there's a size difference caused by the fact that the app doesn't have the URL header from mWeb
image

Nevertheless, mWeb does have a funky behavior. I would expect that the compose box expands a moderate amount when using the resize button. Here's a size comparison when the compose box is expanded and not expanded in iOS, the function even inverts the functionality when the message is large.

image

Note that the issue is also reproducible in mWeb iOS / Chrome

Regarding the documented behavior of this feature, I looked for the PR that introduced this feature and the behavior in mWeb is different to what is now - Check the videos here #11608

@mallenexpensify
Copy link
Contributor

@aimane-chnaif , since you worked on the PR for this feature, any idea what might be going on? Expanding is def functioning differently that in your screenshots in the OP of the PR.

Thanks @isagoico for the sleuthing, screenshot and link to the PR.

@aimane-chnaif
Copy link
Contributor

My PR is too old.
Recently, we limited composer not to take full height to support emoji suggestions.
This issue is more related to #16446

@mallenexpensify
Copy link
Contributor

Thanks @aimane-chnaif , I commented on that issue, it looks like it might be getting put on hold pending another

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mallenexpensify
Copy link
Contributor

mallenexpensify commented May 17, 2023

Looks like we're holding on the below based on - #16446 (comment)

@aimane-chnaif , that look right?

Bumped to weekly and removed Bug since it's on hold.

@melvin-bot melvin-bot bot removed the Overdue label May 17, 2023
@mallenexpensify mallenexpensify changed the title mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field [HOLD #16078] mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field May 17, 2023
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels May 17, 2023
@aimane-chnaif
Copy link
Contributor

@aimane-chnaif , that look right?

right

@melvin-bot melvin-bot bot added the Overdue label May 25, 2023
@mallenexpensify
Copy link
Contributor

mallenexpensify commented May 26, 2023

Looks like the above just hit production!
PR is here

Bumping back to Daily to test on Mon/Tues once back.

@melvin-bot melvin-bot bot removed the Overdue label May 26, 2023
@mallenexpensify mallenexpensify added Daily KSv2 and removed Weekly KSv2 labels May 26, 2023
@roryabraham
Copy link
Contributor

looks like progress might be accelerating in #16078

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 23, 2024
@roryabraham
Copy link
Contributor

still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Feb 23, 2024
@mallenexpensify mallenexpensify changed the title [$1000] [HOLD #16078] mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field [HOLD #16078][$1000] mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field Mar 7, 2024
@mallenexpensify
Copy link
Contributor

Still holding on the below, not much action the past few weeks.

Added to #vip-vsb cuz it doesn't involve money.

@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@mallenexpensify
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2024
@mallenexpensify
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2024
@puneetlath puneetlath changed the title [HOLD #16078][$1000] mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field [$1000] mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field Jun 20, 2024
@puneetlath puneetlath changed the title [$1000] mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field [$250] mWeb -Chat - Compose box - Compose box does not increase when user is trying to expand the input field Jun 20, 2024
Copy link

melvin-bot bot commented Jun 20, 2024

Upwork job price has been updated to $250

@puneetlath puneetlath added Weekly KSv2 and removed External Added to denote the issue can be worked on by a contributor Monthly KSv2 labels Jun 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 20, 2024
@puneetlath puneetlath added the External Added to denote the issue can be worked on by a contributor label Jun 20, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 20, 2024
Copy link

melvin-bot bot commented Jun 20, 2024

Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Overdue labels Jun 20, 2024
@puneetlath
Copy link
Contributor

puneetlath commented Jun 20, 2024

Reopening this for proposals. Now that we have inline auto-suggestion, we should be able to make the compose box expand to take up the full available space. And we should be able to have that happen on all platforms.

@puneetlath
Copy link
Contributor

Actually, I think #15596 is the best place to handle this. Going to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants