[DO NOT PAY - REGRESSION] "Most recent" description in Spanish not in multiple lines and its truncated at the end

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Change language to Spanish in settings
2. Switch the priority to most recent
3. Observe the description

Expected Result:

There should be no truncation

Actual Result:

Truncated at the end

Workaround:

Visual

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [] Android / native
• [] Android / Chrome
• [] iOS / native
• [] iOS / Safari
• MacOS / Chrome / Safari
• [] MacOS / Desktop

Version Number: 1.2.89-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

mode-2023-03-26_10.59.52.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1679807831421289
View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jliexpensify]

Asking about this here - https://expensify.slack.com/archives/C01SKUP7QR0/p1679869826758849

It looks like this is designed to wrap, but starting a conversation to see if we want to change this.

[PrashantMangukiya]

@jliexpensify This may be regression from this pr #15646

App/src/components/OptionRow.js

Line 127 in 4aec557

const alternateTextStyle = StyleUtils.combineStyles(textStyle, styles.optionAlternateText, styles.textLabelSupporting, this.props.style, styles.pre);

Remove styles.pre from line 127 it solve the problem. OR Replace styles.pre with styles.preWrap it also solve the problem. Not sure which one is best, this is just suggestion.

Result

[MariaHCD]

Noting here that I think https://expensify.slack.com/archives/C049HHMV9SM/p1679812350450349 might also be a regression from the same PR. Changing this to syles.preWrap fixes the issue:

App/src/components/MenuItem.js

Line 61 in 5c3a6e8

styles.pre,

[jliexpensify]

Thanks @PrashantMangukiya - appreciate it! Confirmed it's a regression so assigning this issue to @tienifr to fix.

[tienifr]

Assign it to me

[tienifr]

@jliexpensify @MariaHCD The PR is ready for review

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.93-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix/16524: "Most recent" description in Spanish not in multiple lines and its truncated at the end #16657

If no regressions arise, payment will be issued on 2023-04-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@tienifr ] The PR that introduced the bug has been identified. Link to the PR: fix 15438 maintain white space in display name #15646
• [@tienifr ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/Expensify/issues/273785
• [@tienifr ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@tienifr] Determine if we should create a regression test for this bug.
• [@tienifr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/273785

[jliexpensify]

@MariaHCD No payment for @tienifr as he's fixing a regression, right?

Also, do we still need to complete the checklist? (first time assigning a regression, unsure of this!)

[MariaHCD]

I think we'll still need the checklist here

[jliexpensify]

@tienifr I linked the PR to this issue and assigned you the bulk of the checklist, can you update it when you have a chance? Thanks!

[tienifr]

Regression Test Proposal

Bug: "Most recent" description in Spanish not in multiple lines and its truncated at the end

Proposed Test Steps:

1. Change language to Spanish in settings
2. Go to the Priority Page
3. Switch the priority to the most recent
4. Verify that the description of the most recent field is fully displayed

Do we 👍 or 👎

[tienifr]

@jliexpensify I just created regression test for this issue, but how I can edit the bulk of the checklist?

[jliexpensify]

@tienifr I can tick off the list for you - I'll pop your steps into a new TestRail GH

I think you can click on the 3 dots (top right) on the checklist and edit?

[tienifr]

@jliexpensify It seems that I don't have access to edit. Could you help to tick off 2 lines
[@tienifr ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@tienifr ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

[jliexpensify]

@tienifr cool, do you have links for both?

[tienifr]

@jliexpensify I think we should fill like this

[@tienifr ] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: #16524 (comment)
[@tienifr ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA

[jliexpensify]

Done, and since the PR is deployed to Prod - closing! Thanks @tienifr !

[priya-zha]

@jliexpensify I am the external reporter for this. I haven't been yet paid for this. Thank you

[jliexpensify]

@priya-zha - I'll spin up a job in Upworks shortly and get that sorted, thanks for the bump!

[jliexpensify]

@priya-zha - invited to you to https://www.upwork.com/ab/applicants/1643473274997719040/job-details

[priya-zha]

@jliexpensify Accepted the offer and submitted the work. Thank you

[jliexpensify]

Paid!