[$1000] IPAD - Sign in - Unable to scroll to the footer in Sign in page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Navigate to the sign-in page
3. Scroll to footer

Expected Result:

Able to scroll to the footer in Sign in page

Actual Result:

Unable to scroll to the footer in Sign in page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop
• IPAD/ native

Version Number: 1.2.90.6

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1680004382.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012487f8fbde090567
• Upwork Job ID: 1643074169889533952
• Last Price Increase: 2023-04-04

[MelvinBot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~012487f8fbde090567

[MelvinBot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[stephanieelliott]

Was able to repro

[MelvinBot]

Triggered auto assignment to @alex-mechler (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When viewing the sign in screen on iPad devices, a user is unable to scroll down to see the footer at the bottom of the right-hand side of the page.

What is the root cause of that problem?

It appears that the style for ScrollView component's contentContainerStyle is not allocating enough vertical space to allow for proper scrolling to the end of the container.
https://github.com/Expensify/App/blob/main/src/pages/signin/SignInPageLayout/index.js#L53

What changes do you think we should make in order to solve the problem?

Changing the contentContainerStyle to [styles.flexGrow1] should fix the problem.

What alternative solutions did you explore? (Optional)

None.

[MelvinBot]

📣 @akinwale! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[akinwale]

Contributor details
Your Expensify account email: akinwale@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0131f1f7eb5b5af4cd

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[hellohublot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

IPAD - Sign in - Unable to scroll to the footer in Sign in page

What is the root cause of that problem?

When we set contentContainerStyle, because scrollView.contentSize.height = scrollView.height, it cannot be scrolled on ipad

What changes do you think we should make in order to solve the problem?

We better removeScrollView.contentContainerStyle, this property makes ScrollView like a normal View

https://github.com/Expensify/App/blob/main/src/pages/signin/SignInPageLayout/index.js#L53

-   contentContainerStyle={[styles.flex1]}

What alternative solutions did you explore? (Optional)

Not Yet

[bhupindersharma2020]

Proposal

Hey, Greetings for the day.

I am a React Native developer with over 4+ years of professional experience.
About the Github issue: #16612

I have looked into the issue and ran the project from the production branch. Was able to replicate the issue above.
Have debugged, and found the solution, actually, we need to adjust (actually remove contentContainerStyle) in the SignUp Page UI of the ScrollView component.
Here I have linked the video with the issue fixed:
https://drive.google.com/file/d/1IX5ZgCl6mUwJHmGSjJGUWfrnaUFtsFz0/view?usp=sharing

Please review and let me know if you have any concerns or doubts.
Hoping to hear back from you.

Thanks and Regards
Bhupinder Sharma

[MelvinBot]

📣 @bhupindersharma2020! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[bhupindersharma2020]

Contributor details
Your Expensify account email: bhupindersharma.itwaves@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~013f34deab0f72f0be

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[devanshujain95]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When viewing the sign in screen on iPad devices, users are unable to scroll down and also not able to see the footer and its options.

What is the root cause of that problem?

It appears that the style for ScrollView component present at SignInPageLayout component contentContainerStyle is not allocating enough vertical space to allow for proper scrolling to the end of the container. The reason behind this is when we set contentContainerStyle, scrollView.contentSize.height is equals to scrollView.height and hence it can't be scrolled.

What changes do you think we should make in order to solve the problem?

Remove contentContainerStyle prop from the ScrollView component in SignInPageLayout.

What alternative solutions did you explore? (Optional)

We can also give flexGrow: 1 property instead of giving flex as 1. This should also make sure that our SignInPageLayout component gets enough space of ScrollView so as to get proper scrolling.

Screen.Recording.2023-04-04.at.2.09.57.PM.mov

[parasharrajat]

@aimane-chnaif An internal discussion https://expensify.slack.com/archives/C02NK2DQWUX/p1680597914268959

[aimane-chnaif]

@stephanieelliott @alex-mechler can you please confirm if this is worth fixing since it's iPad/android tablet issue?
Btw, while reviewing code in signin page, I found significant issue in scrollview / keyboard handling, which introduced this bug.

[parasharrajat]

We earlier decided to not focus on IPAD issues and It seems that this is still the case. Slack talks the same.

[alex-mechler]

IPad is not an officially supported platform yet. Going to close this out.