Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] On weaker connection, app flickers main chat page when changing legal name android chome #16832

Closed
1 of 6 tasks
kavimuru opened this issue Mar 31, 2023 · 38 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@kavimuru
Copy link

kavimuru commented Mar 31, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app in android chrome (happens occasionally only with weaker connection)
  2. Open settings
  3. Open profile
  4. Open personal details
  5. Open legal name and observe that app displays main chat page for brief moment
  6. Click on legal first name and observe that app displays main chat page for brief moment

Expected Result:

App should not display any other page while opening legal name and legal first name

Actual Result:

App displays main chat page for brief moment while opening legal name and legal first name on poor connection

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.93-4
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

gltch.in.opening.legal.first.name.and.name.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680287101491289

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014188ec656f125b19
  • Upwork Job ID: 1644390136635744256
  • Last Price Increase: 2023-06-07
@kavimuru kavimuru added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 31, 2023
@MelvinBot
Copy link

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 31, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Apr 3, 2023
@NicMendonca
Copy link
Contributor

NicMendonca commented Apr 3, 2023

@kbecciv @dhanashree-sawant -- how do I simulate a "weaker connection" so that I can try and reproduce this?

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2023
@dhanashree-sawant
Copy link

Hi @NicMendonca , at my end, the connection is actually weak at times, not sure how you can reproduce on android chrome at your end. It is also visible at times in force offline mode if that helps.

@NicMendonca
Copy link
Contributor

Okay, I'll try on offline mode!

@NicMendonca
Copy link
Contributor

@dhanashree-sawant I can't reproduce this on offline mode 😞 Is there a scenario where this is reliably happening?

@NicMendonca
Copy link
Contributor

assigning @Christinadobrzyn to watch over this while I am OOO!

@dhanashree-sawant
Copy link

Hi @NicMendonca , sorry I don't know any other reliable way to reproduce it

@Christinadobrzyn
Copy link
Contributor

I found a few other GHs related to "flickering" GHs/job, I wonder if either of these GHs 1 or 2 are linked to the same issue? Or if this falls under our Fabric Architeture project?

Asking the team for some guidance here https://expensify.slack.com/archives/C049HHMV9SM/p1680800397672419?thread_ts=1680287101.491289&cid=C049HHMV9SM

I think I am able to replicate this flickering but it's not as visible as what @dhanashree-sawant can see.

2023-04-06_10-46-37 (3)

@Christinadobrzyn
Copy link
Contributor

@Christinadobrzyn
Copy link
Contributor

Follow up from BZ eng - this isn't related to the Fabric project so I think we should move forward with a fix for this. Going to add the External!

@Christinadobrzyn Christinadobrzyn added External Added to denote the issue can be worked on by a contributor and removed Needs Reproduction Reproducible steps needed labels Apr 7, 2023
@melvin-bot melvin-bot bot changed the title On weaker connection, app at times displays main chat page for brief moment while opening legal name, legal first name fields on android chome [$1000] On weaker connection, app at times displays main chat page for brief moment while opening legal name, legal first name fields on android chome Apr 7, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~014188ec656f125b19

@MelvinBot
Copy link

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 7, 2023
@MelvinBot
Copy link

Triggered auto assignment to @cristipaval (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Christinadobrzyn
Copy link
Contributor

@s77rt or @Puneet-here could you just double-check that this issue wouldn't be fixed by #16082

@s77rt
Copy link
Contributor

s77rt commented Apr 7, 2023

@Christinadobrzyn The flicker issue seen here #16832 (comment) will be fixed. But the issue reported in OP looks different i.e. LHN is briefly shown and flickers. Can you reproduce that issue?

@cristipaval
Copy link
Contributor

Still on hold.

@NicMendonca
Copy link
Contributor

still holding: #11768

@melvin-bot melvin-bot bot added the Overdue label May 10, 2023
@NicMendonca
Copy link
Contributor

@cristipaval just to confirm, we're still holding yeah?

@melvin-bot melvin-bot bot removed the Overdue label May 10, 2023
@cristipaval
Copy link
Contributor

yes, still on hold

@melvin-bot melvin-bot bot added the Overdue label May 19, 2023
@cristipaval
Copy link
Contributor

we're close, but still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2023
@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@cristipaval
Copy link
Contributor

Almost there, I think navigation reboot is under testing atm.

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 6, 2023
@cristipaval
Copy link
Contributor

This is off hold now.

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@cristipaval cristipaval changed the title [HOLD for #11768] [$1000] On weaker connection, app flickers main chat page when changing legal name android chome [$1000] On weaker connection, app flickers main chat page when changing legal name android chome Jun 7, 2023
@cristipaval cristipaval added Daily KSv2 and removed Weekly KSv2 labels Jun 7, 2023
@cristipaval
Copy link
Contributor

Let's see if this is still reproducible

@cristipaval
Copy link
Contributor

I can't reproduce it with the latest dev.
@s77rt @NicMendonca @0xmiroslav Could you also please try on your end?

@0xmiros
Copy link
Contributor

0xmiros commented Jun 7, 2023

I am not able to reproduce on any env - dev/staging/production

@cristipaval
Copy link
Contributor

Alright then, I am not sure what payments should be made for this one, so I won't close this one yet.
On you @NicMendonca.
Thanks!

@s77rt
Copy link
Contributor

s77rt commented Jun 7, 2023

Not reproducible from my end either

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@NicMendonca
Copy link
Contributor

I think we're good here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

9 participants