[HOLD for #16078][$1000] Expanding chat box hides the recipient’s time stamp

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open an existing chat > Shift + Enter
2. Click on expand icon that is located in the chat box
3. Observe that the chat box hides the recipient’s time-teller text on expanding

Expected Result:

The recipient's time-teller text shouldn’t be hidden

Actual Result:

The recipient's time-teller text is hidden

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.93-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-04-01.01.01.11.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680300734009719

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010abb411bbe9343be
• Upwork Job ID: 1642723911634702336
• Last Price Increase: 2023-04-10

[MelvinBot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kadiealexander]

Reproduced in staging web:

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010abb411bbe9343be

[MelvinBot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[MelvinBot]

Triggered auto assignment to @robertjchen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[PrashantMangukiya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expanding chat box hides the recipient’s time stamp.

What is the root cause of that problem?

Recipient local time conditionally rendered via line below:

App/src/pages/home/report/ReportActionCompose.js

Line 696 in 4ee21e9

{shouldShowReportRecipientLocalTime && <ParticipantLocalTime participant={reportRecipient} />}

We are deciding shouldShowReportRecipientLocalTime value via line below:

App/src/pages/home/report/ReportActionCompose.js

Lines 680 to 681 in 4ee21e9

	const shouldShowReportRecipientLocalTime = ReportUtils.canShowReportRecipientLocalTime(this.props.personalDetails, this.props.report)
	&& !this.props.isComposerFullSize;

At line 681 we put condition i.e. && !this.props.isComposerFullSize so it will not show recipient local time if composer is in full size. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

We have to remove && !this.props.isComposerFullSize from that condition, so code looks below:

  const shouldShowReportRecipientLocalTime = ReportUtils.canShowReportRecipientLocalTime(this.props.personalDetails, this.props.report);

It will solve the problem as shown in result video.

What alternative solutions did you explore? (Optional)

Result

RecipientHide.mov

[gautambishal]

@PrashantMangukiya solution seems to be solving the issue. What was the business requirement to put that condition in the first place?

[s77rt]

I don't think this is a bug. It was intended since the input used to take full screen height. Now it's not but based on this #15596 (comment) (cc @cristipaval) that change may be reverted.

I think we should hold this on #16078
cc @kadiealexander

[muxriddinmuqimov77]

I have a solution

[MelvinBot]

📣 @muxriddinmuqimov77! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[muxriddinmuqimov77]

Contributor details
My Expensify account email: muxriddinmuqimov007@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01d01aef4263378596

Hi
I have a solution for this task.

[s77rt]

@muxriddinmuqimov77 We have a proposal template to follow. Please read the contributing guide.

[s77rt]

Not overdue. @cristipaval Can we get a confirmation on this #16843 (comment).

[robertjchen]

Changing to Weekly while #16843 (comment) is clarified.

[cristipaval]

I don't think this is a bug. It was intended since the input used to take full screen height. Now it's not but based on this #15596 (comment) (cc @cristipaval) that change may be reverted.

I think we should hold this on #16078 cc @kadiealexander

Yes I confirm, this issue should be held on #16078, according to this Slack message.

[robertjchen]

still on hold

[kadiealexander]

Still on hold!

[s77rt]

Still on hold

[kadiealexander]

Still on hold, shifting to monthly.

[s77rt]

Still on hold

[s77rt]

Still on hold

[s77rt]

Same ^

[quinthar]

taking into #vip-vsb

[quinthar]

Oh actually, I think this comment is accurate:

I don't think this is a bug. It was intended since the input used to take full screen height. Now it's not but based on this #15596 (comment) (cc @cristipaval) that change may be reverted.

The expander is supposed to go full screen, but doesn't currently due to a limitation of our auto-complete. So anything we do here will be negated when this is finished. Closing this one.