[HOLD #15310][$1000] Inconsistent default scrolling on the personal message section on Android that in turn hides the first line of texts, unlike mweb chrome

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on mweb chrome
2. Go to any workspace and change the name to a longer name
3. Go to invite members and notice that the personal message texts are shown from the top itself
4. But now follow the same steps on android and notice that the first line of text is not shown properly since it's automatically scrolled to bottom

Expected Result:

Android and mweb chrome personal message in invite members should have consistent behavior and the first lines of texts should also be shown on android properly

Actual Result:

The First line of text in personal message on invite members page on android scrolls to bottom automatically and the first line of text is not shown properly. But behaves different in mweb chrome

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.94-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

workspace.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680599826934579

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010511c30c967553b5
• Upwork Job ID: 1645879250401800192
• Last Price Increase: 2023-04-18

[MelvinBot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@sonialiap Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@sonialiap Eep! 4 days overdue now. Issues have feelings too...

[sonialiap]

Reproducible

[MelvinBot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

Making it external

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010511c30c967553b5

[MelvinBot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[MelvinBot]

Current assignee @luacmartins is eligible for the External assigner, not assigning anyone new.

[Ollyws]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On Android, the personal message textInput is scrolled to the bottom when opened.

What is the root cause of that problem?

This is the default behaviour of the textInput on native Android, if you remove the selection prop from Composer (for example) you will also see similar behaviour there.

What changes do you think we should make in order to solve the problem?

Implement the selection prop and use state for the textInput on the workspaceInvitePage and use the onSelectionChange callback to set the state.
This means we will need to add selection: {start:0, end: 0} to the state field in the constructor, a setSelection function:

setSelection(selection) {
        this.setState({selection});
}

and add the onSelectionChange callback to the textInput:

onSelectionChange={event => this.setSelection(event.nativeEvent.selection)}

What alternative solutions did you explore? (Optional)

None

[fedirjh]

Thanks @Ollyws for your proposal . Why native Android has a different behaviour ? is that expected ? Why adding selection fixes it ? For me It looks like a bug that should be fixed upstream.

[luacmartins]

We got one proposal from @Ollyws, but we have these outstanding questions.

[MelvinBot]

@sonialiap @luacmartins @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[Ollyws]

Just having a dig in the RN source code, will answer those questions soon.

[MelvinBot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sonialiap]

@Ollyws have you had a chance to take a look at the questions?

[Ollyws]

@fedirjh Seems like we already opened a PR for this but it has been sitting there for ages now without approval.

[fedirjh]

@Ollyws Thanks for the update. The same PR Expensify/react-native#45 was merged on our RN fork and it’s being handled in #15310.

@sonialiap I think we should hold this issue in favour of #15310

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[luacmartins]

maybe we can close this one after the 2nd week?

[luacmartins]

Waiting to see if we can still reproduce this during the next KI retest

[luacmartins]

Still waiting on KI tests

[luacmartins]

Waiting on KI

[luacmartins]

Still waiting on KI

[luacmartins]

I couldn't reproduce this. Both platforms were consistent and had the cursor set to the end of the text field. Closing.