Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] A message that is sent and deleted in offline mode, disappears first, then reappears then disappears again #17081

Closed
1 of 6 tasks
kavimuru opened this issue Apr 6, 2023 · 46 comments
Closed
1 of 6 tasks

[HOLD] A message that is sent and deleted in offline mode, disappears first, then reappears then disappears again #17081

kavimuru opened this issue Apr 6, 2023 · 46 comments
Assignees
@parasharrajat @maddylewis @hayata-suenaga
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff

Comments

@kavimuru
Copy link

kavimuru commented Apr 6, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Open an existing chat
  2. Open dev tools > open networks tab > apply offline mode
  3. Enter text in chat box and click on send button
  4. Hover over the newly sent comment, and click on ‘trash bin’ icon to delete the comment
  5. Open dev tools > open networks tab > apply No throttling

Expected Result:

comment should disappear, and then remain disappeared

Actual Result:

comment disappears, reappears, and disappears again
Notes: click on refresh button if the comment did not disappear again

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.96-3
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-04-04.20.01.21.mp4
Recording.145.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680628786189869

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ff9c9060e88e5a71
  • Upwork Job ID: 1645813037538856960
  • Last Price Increase: 2023-04-11
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 6, 2023
@MelvinBot
Copy link

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Apr 6, 2023 •
edited by maddylewis
Loading

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Natnael-Guchima
Copy link

Few notes to reproduce the issue:

  • wait a few seconds after you deleted the comment, and applied no throttling for the comment to reappear
  • once the comment reappears click on the refresh button for the comment to disappear again

@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@MelvinBot
Copy link

@maddylewis Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MelvinBot
Copy link

@maddylewis Whoops! This issue is 2 days overdue. Let's get this updated quick!

@maddylewis
Copy link
Contributor

reviewing now!

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2023
@maddylewis
Copy link
Contributor

reproducible:

2023-04-11_11-15-17.mp4

@MelvinBot
Copy link

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@maddylewis
Copy link
Contributor

i believe this can be External but wanted to double-check with engineering before adding the label. @hayata-suenaga - lmk if you think this bug can be fixed externally - thank you!

@hayata-suenaga
Copy link
Contributor

There might be a slight possibility that we might need to change backend Onyx, so I'll mark this internal and work on this issue myself.

@hayata-suenaga hayata-suenaga added the Internal Requires API changes or must be handled by Expensify staff label Apr 11, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01ff9c9060e88e5a71

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@hayata-suenaga hayata-suenaga added the Improvement Item broken or needs improvement. label Apr 11, 2023
@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Apr 13, 2023 •
edited
Loading

Putting HOLD on this issue as the solution is discussed in this tracking issue. The issue is added to that tracking issue.

@hayata-suenaga hayata-suenaga changed the title A message that is sent and deleted in offline mode, disappears first, then reappears then disappears again [HOLD] A message that is sent and deleted in offline mode, disappears first, then reappears then disappears again Apr 13, 2023
@hayata-suenaga hayata-suenaga mentioned this issue Apr 13, 2023
Closed
@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@MelvinBot
Copy link

@parasharrajat, @maddylewis, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@maddylewis
Copy link
Contributor

switching to weekly while this issue is on hold.

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2023
@maddylewis maddylewis added the Weekly KSv2 label Apr 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 11, 2023
@maddylewis
Copy link
Contributor

still holding!

@melvin-bot melvin-bot bot removed the Overdue label Jul 12, 2023
@hayata-suenaga
Copy link
Contributor

The fix issue itself is still on hold on an Onyx issue. So this is also on hold...

@melvin-bot melvin-bot bot added the Overdue label Jul 20, 2023
@hayata-suenaga
Copy link
Contributor

hold

@melvin-bot melvin-bot bot removed the Overdue label Jul 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 31, 2023
@hayata-suenaga
Copy link
Contributor

still on hold on this

@melvin-bot melvin-bot bot removed the Overdue label Jul 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2023
@hayata-suenaga
Copy link
Contributor

still hold

@melvin-bot melvin-bot bot removed the Overdue label Aug 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@maddylewis
Copy link
Contributor

still holding / moving to monthly until the other issue is off hold #17081 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@maddylewis maddylewis added Monthly KSv2 and removed Weekly KSv2 labels Aug 21, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 22, 2023
@maddylewis
Copy link
Contributor

still on hold

@melvin-bot melvin-bot bot removed the Overdue label Sep 22, 2023
@maddylewis
Copy link
Contributor

holding still - #15550 (comment)

@maddylewis
Copy link
Contributor

@hayata-suenaga - are we still holding on some thing specific? or, can this be closed out? lmk - ty!

@maddylewis maddylewis added Daily KSv2 and removed Monthly KSv2 labels Nov 13, 2023
@hayata-suenaga
Copy link
Contributor

@parasharrajat it's been a long time since this issue was created. Can you check if this issue is still present?

@maddylewis
Copy link
Contributor

ill go ahead and close this out for now. and we can follow up in slack if its still an issue 👍

@parasharrajat
Copy link
Member

It is solved, I guess. I can't reproduce.

@strepanier03 strepanier03 mentioned this issue Apr 3, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parasharrajat parasharrajat

@maddylewis maddylewis

@hayata-suenaga hayata-suenaga

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@MelvinBot @parasharrajat @neil-marcellini @maddylewis @kavimuru @Natnael-Guchima @hayata-suenaga