[HOLD for payment 2023-05-05] [$1000] Connect Bank Account -Selecting the oldest available date gives an error "Must be over 18 years old"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go Settings -> Workspaces -> [Select your workspace] -> Issue cards -> Connect Bank Account -> Connect manually
4. Fill out the 1 and 2 steps of the form
5. Proceed to Personal Information Step -> DOB date picker dates -> Select the oldest available date (150 years back from now)

Expected Result:

Correct error message appears

Actual Result:

An error "Must be over 18 years old" appears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.0.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6016945_17072_Web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01711912703871f499
• Upwork Job ID: 1651530211315400704
• Last Price Increase: 2023-04-27

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[laurenreidexpensify]

Thanks @kbecciv - can you confirm what happens if someone picks a date that is >100 years old? Does this error only show for 150 years, or is it specific to a certain amount of years?

[francoisl]

It's if you select the oldest possible date (or most recent one, too). It's not directly due to any changes from #17072. I see the issue, I'll send a fix in a bit.

[laurenreidexpensify]

No payment required on this: applause report and Francois is fixing.

[0xmiros]

PR requires C+ review and I am currently reviewing

[francoisl]

@laurenreidexpensify do you think it's weird if we introduce a new error message that says something like "Must be under 150 years old"? It could come off as an arbitrary restriction, when in fact we mostly want to prevent from entering a wrong date. Maybe an alternative could be something like "The date must be less than 150 years ago"?

[laurenreidexpensify]

@francoisl sorry missed this yesterday.

I think we can put something more generic like Please select a valid date at which point the user should realise they are not a vampire and 150 years old lol and see the keystroking error

[MelvinBot]

@francoisl, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01711912703871f499

[MelvinBot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @0xmiroslav is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Current assignee @francoisl is eligible for the External assigner, not assigning anyone new.

[laurenreidexpensify]

PR has been merged - will pay @0xmiroslav for C+ review 7 days after prod deploy. Sent offer in Upwork.

[gulfam110]

The error "Must be over 18 years old" typically occurs when the birthdate entered is less than 18 years ago. In the case of selecting the oldest available date while connecting a bank account in React Native, it's likely that the date selected is more recent than 18 years ago.

To resolve this issue, you can try selecting a birthdate that is at least 18 years ago from the current date. If that doesn't work, you can also check if there are any restrictions or limitations on the bank account connection based on age or other factors, and make sure that you meet those requirements.

It's also possible that there may be a bug or issue in the React Native code that is causing this error to be displayed incorrectly. If that's the case, you may need to debug the code and fix any issues that are causing the error to occur.

[laurenreidexpensify]

Deployed to staging yesterday - will hit prod next week

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.7-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix meetsAgeRequirements for min/max dates #17474

If no regressions arise, payment will be issued on 2023-05-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[laurenreidexpensify]

@0xmiroslav I've issued payment. Can you confirm steps above and whether we need a regression test? If none, then we are fine to close this.

[0xmiros]

No PRs caused regression. This existed long time after we add birthdate validation in #5615.
This bug would have been caught and fixed earlier in #15316 which fixes #15228 if we look for all instances of birthdate validation across the app.
But as this is edge case (no one is older than 150 years 😮), no one is able to catch this easily and so no need regression test. So we can just close this.

[melvin-bot]

@francoisl, @laurenreidexpensify, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[francoisl]

Agreed with the suggestion above. Looks like we're all set with the payment, closing.