[HOLD for payment 2023-03-09] [$1000] Wrong validation error message on choose date of birth.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Settings -> Profile -> Personal Details.
2. Click on Date of birth.
3. Choose date 17/2/2018.( Testing this scenario on 02/16)
4. Press on save button.
5. Error message will be display "Date should be before 2018-02-16."
6. Now select 16/2/2018, it will works.

Expected Result:

Either message should be "Date should be on or before 2018-02-16.". Or don't allow to select 16/2/2018

Actual Result:

Incorrect error message allowing to select 16/2/2018 but error message says date should be before 16/2/2018

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.72-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

date-validation.mov

Recording.1538.mp4

Expensify/Expensify Issue URL:
Issue reported by: @jatinsonijs
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676539597780339

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d2cc56f9c3202414
• Upwork Job ID: 1626535149478653952
• Last Price Increase: 2023-02-17

[MelvinBot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

Cannot reproduce on staging, @kavimuru can you share what platforms this occurs on and if still occurring? 🙇

[dylanexpensify]

Was able to reproduce, but we need to update steps to say set to today's date not Feb 17 cc @kavimuru

[dylanexpensify]

Thread

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01d2cc56f9c3202414

[MelvinBot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Triggered auto assignment to @danieldoglas (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jatinsonijs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Validation message is incorrect or we can say incomplete

What is the root cause of that problem?

We are allowing ages between 5 to 150 so we are doing some validation to check age is between these numbers or not. but message is incorrect in translation:

App/src/languages/en.js

Line 617 in 90b9efa

dateShouldBeBefore: ({dateString}) => `Date should be before ${dateString}.`,

What changes do you think we should make in order to solve the problem?

We have to just change message in translation to indicate before or equal to date

[situchan]

Should we put this on HOLD for New Date Picker Design?

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The validation error message says that we can not select a particular date during DOB selection but in actual, we can select that date without any error.

What is the root cause of that problem?

The root cause of this problem is that current date that we use for comparison includes hours of the day as well. The selected date however, does not include the hours of the day. eg 18-01-01 translates to 01 Jan 2018 00:00:00. This causes the check to pass as this date is before the current date.

What changes do you think we should make in order to solve the problem?

We can solve the problem by making sure that we're comparing against the current date with start of the day selected. The following needs to be changed:
https://github.com/Expensify/App/blob/main/src/libs/ValidationUtils.js#L218-L219
to

    const recentDate = moment().startOf('day').subtract(minimumAge, 'years');
    const longAgoDate = moment().startOf('day').subtract(maximumAge, 'years');

We also need to change the following:
https://github.com/Expensify/App/blob/main/src/libs/ValidationUtils.js#L227
to

    if (testDate.isSameOrAfter(recentDate)) {

What alternative solutions did you explore? (Optional)

• Changing the validation message. This however does not consider the root cause.
• We can also change the testDate to not start from the beginning of the day. Instead, it can include hours. However, doing this might still cause problems as the testDate might be evaluated before currentDate and the difference between the two might be some milliseconds which will effect the result.

[dylanexpensify]

@rushatgabhane can we get a review of @allroundexperts proposal please?

[rushatgabhane]

@danieldoglas i prefer @allroundexperts' proposal because it fixes the root cause #15228 (comment)

C+ reviewed 🎀 👀 🎀

[danieldoglas]

Makes sense to me. Assigning @allroundexperts

[MelvinBot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dylanexpensify]

lol

[MelvinBot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dylanexpensify]

@mallenexpensify I'm heading OOO! Would you mind finishing the last bits for me?? 🙇

[mallenexpensify]

@jatinsonijs @rushatgabhane @allroundexperts can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01d2cc56f9c3202414

This bug is specific to the date being exactly 5 years from the current date, right?

[allroundexperts]

@jatinsonijs @rushatgabhane @allroundexperts can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~01d2cc56f9c3202414

This bug is specific to the date being exactly 5 years from the current date, right?

Currently we have it set up for 5 years.

[allroundexperts]

I've applied @mallenexpensify.

[mallenexpensify]

Currently we have it set up for 5 years.

Thanks @allroundexperts . @isagoico , when you're back from ECX, can you take a look at this? I'm unsure it should be added to TestRail because it's an extreme edge case that anyone (outside of @jatinsonijs , ha) would add a birthday of exactly 5 years.

[jatinsonijs]

@mallenexpensify applied

[isabelastisser]

@mallenexpensify , you meant to tag @isagoico . :)

[mallenexpensify]

@isabelastisser I swear I updated it right after I posted it! (honestly, I probably have done it more than once this week, sorry)

[mallenexpensify]

Everyone is paid!! Leaving open and bumping to weekly til @isagoico is back and can review.

[allroundexperts]

@mallenexpensify Thanks for the payment. The PR for this was merged within 3 days. Am I eligible for the bonus here?

[allroundexperts]

@mallenexpensify Thanks for the payment. The PR for this was merged within 3 days. Am I eligible for the bonus here?

I take my comment back. This was merged ~12 hours late.

[rushatgabhane]

i have a checklist todo here

[isagoico]

Currently we have it set up for 5 years.

Thanks @allroundexperts . @isagoico , when you're back from ECX, can you take a look at this? I'm unsure it should be added to TestRail because it's an extreme edge case that anyone (outside of @jatinsonijs , ha) would add a birthday of exactly 5 years.

Lol agree here, I don't think this would be a valuable addition since there's a extremely low chance of this happening to any user. So I would say :donothing: in TestRail for this case.

[mallenexpensify]

Thanks for confirming @isagoico , closing