[$1000] Web - Send/Split/Request - Having long spaces in the description shows ... at the end while sending money

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Action Performed:
2. Go to web chrome
3. Go to any chat
4. Click on send money
5. Input a number
6. Click on save
7. Go to description and just enter spaces till the end
8. Click on save and notice that even when nothing is displayed , it displays ... dots at the end and makes it look weird. It should not allow all the spaces on the description field. Or even if it does, since nothing is shown on the display, it shouldn't display three dots at the end.

Expected Result:

There should not be three dots present at the end in the description field if only all long spaces are entered

Actual Result:

The three dots are present at the end even when there's nothing to display if multiple long spaces are entered in the description field.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.1.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

error-2023-04-18_20.24.53.mp4

Recording.2523.mp4

Expensify/Expensify Issue URL:

Issue reported by:@priya-zha

**Slack conversation:**https://expensify.slack.com/archives/C049HHMV9SM/p1681828858614329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01948d3eba1156fa22
• Upwork Job ID: 1648987297480835072
• Last Price Increase: 2023-04-20

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[laurenreidexpensify]

I played around with this a bit and can reproduce. It does look like if you enter text after a long series of spaces it also shows an ellipsis on the preview pane, and then if you delete it the ellipsis disappears.

I think it's fine for us to clean this up.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01948d3eba1156fa22

[MelvinBot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[MelvinBot]

Triggered auto assignment to @deetergp (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[gadhiyamanan]

@laurenreidexpensify i think it's duplicate of #17485

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send/Split/Request - Having long spaces in the description shows ... at the end while sending money

What is the root cause of that problem?

We don't trim the space of the description, that's why we see the space with the truncate at the end.

What changes do you think we should make in order to solve the problem?

Trim the space of the IOU description inside updateComment function of MoneyRequestDescriptionPage

    updateComment(value) {
        IOU.setMoneyRequestDescription(value.moneyRequestComment.trim());
        Navigation.goBack();
    }

What alternative solutions did you explore? (Optional)

We can also add a simple validation for description along with trim the space.

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[huzaifa-99]

I agree with @gadhiyamanan that its a duplicate of #17485

[0xmiros]

This is duplicated with #17485 but this GH is opened to external earlier.
So not sure which issue to close.

If we go ahead this GH:
This is straight forward fix. @hungvu193's proposal looks good to me.
This field is optional so we don't need to add required validation.

cc: @deetergp
🎀 👀 🎀 C+ reviewed

[allroundexperts]

@0xmiroslav Since we're accepting proposals posted before the Help wanted label now, I actually proposed the same solution 2 days ago here.

[0xmiros]

@0xmiroslav Since we're accepting proposals posted before the Help wanted label now, I actually proposed the same solution 2 days ago here.

You proposed before that PR was merged so not sure if it's acceptable.
@deetergp or @laurenreidexpensify will decide.

[allroundexperts]

@0xmiroslav Since we're accepting proposals posted before the Help wanted label now, I actually proposed the same solution 2 days ago here.

You proposed before that PR was merged so not sure if it's acceptable. @deetergp or @laurenreidexpensify will decide.

I actually posted this after the agreement was reached on Slack thread and the PR creation.

[laurenreidexpensify]

The other issue was opened before this, so am closing in favour of #17485.

Thanks for the dupe flag @huzaifa-99

[hungvu193]

This is duplicated with #17485 but this GH is opened to external earlier. So not sure which issue to close.

If we go ahead this GH: This is straight forward fix. @hungvu193's proposal looks good to me. This field is optional so we don't need to add required validation.

cc: @deetergp 🎀 👀 🎀 C+ reviewed

@laurenreidexpensify can you please check this comment as well? Since my proposal was approved, and this issue was opened to external earlier.