[HOLD for payment 2023-05-16] [$1000] Inconsistent margin above 'Payment methods' title

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings
2. Click on Payments

Expected Results:

There should be consistent margin above 'Payment methods' title

Actual Results:

Margin is inconsistent above 'Payment methods' title compared to other screens

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-23.at.3.39.19.AM.mov

Recording.331.mp4

Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682204992873729

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0153926c14e0c2607c
• Upwork Job ID: 1650657974409625600
• Last Price Increase: 2023-04-25

[MelvinBot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent margin above the payment methods title in payment methods page.

What is the root cause of that problem?

The root cause is that we're using margin incorrectly here.

What changes do you think we should make in order to solve the problem?

We need to remove the margin top that is defined here. I think this is not needed even when the canUseWallet is enabled. This is because it adds it own set of margin. However, if extra margin is needed, we can remove the margin here conditionally if canUseWallet is not enabled.

We also need to add styles.mt3 here.

We also need to add a styles.mb3 around a wrapping View here.

Result

What alternative solutions did you explore? (Optional)

None

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0153926c14e0c2607c

[arielgreen]

Good to go external

[MelvinBot]

Current assignee @arielgreen is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Triggered auto assignment to @yuwenmemon (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent margin above 'Payment methods' title

What is the root cause of that problem?

The extra margin space come from this line

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Line 375 in 17c1dd8

style={[styles.ph5, styles.mt6, styles.textLabelSupporting, styles.mb1]}

Where we add margin-top to the Payment methods title

This style is added via this commit. It seems we want to add it to make spaces with Transfer button in this LOC

What changes do you think we should make in order to solve the problem?

In those LOC:

1. We should remove styles.mt6 out of Payment title styles
2. Then wrap KYCWall insides a View and adding style.mb6 for it. So when it's rendered, it will add spaces with the bellow component. Otherwise, do nothing.

<View style={[styles.mb6]}>
    <KYCWall>
        ....
    </KYCWall>
</View>

Results:

[rushatgabhane]

i don't see the inconsistency !!!! im blind

[rushatgabhane]

can someone attach screenshots using the inspect elements? of how it looks before and after?

[allroundexperts]

@rushatgabhane

BEFORE

AFTER

[hoangzinh]

Preference page

Payment page
Before

After

[allroundexperts]

Ah... Apologies @rushatgabhane. I forgot to inspect the elements. @hoangzinh Thanks for covering up!

[rushatgabhane]

@yuwenmemon let's go with @allroundexperts' proposal because they were first

C+ reviewed 🎀 👀 🎀

[hoangzinh]

@rushatgabhane it's not only remove current margin-top but also how we handle margin-top in some special cases. Does that mean you prefer @allroundexperts proposal than my proposal?

[allroundexperts]

@rushatgabhane @hoangzinh is correct about my proposal. I missed a case. I've updated my proposal with that new condition. I think we should use mb3 instead of mt6 because it will be consistent with the margin of the top title. This is also included in my proposal.

[MelvinBot]

📣 @allroundexperts You have been assigned to this job by @yuwenmemon!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[allroundexperts]

@yuwenmemon @rushatgabhane PR created.

[rushatgabhane]

PR merged yesterday

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: payment page title spacing #18253

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @DinalJivani
• Contributor that fixed the issue @allroundexperts
• Contributor+ that helped on the issue and/or PR @rushatgabhane

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@arielgreen] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[arielgreen]

@allroundexperts @DinalJivani @rushatgabhane offers sent in Upwork

[rushatgabhane]

Hi @arielgreen, I applied using account - https://www.upwork.com/freelancers/~01212e8255b02ae924
Could you please hire me there, thanks!

All context here - https://expensify.slack.com/archives/C02NK2DQWUX/p1683614947522329

[arielgreen]

@rushatgabhane can you please re-link the context? That link isn't working for me.

[rushatgabhane]

@arielgreen maybe this works -
https://expensify.slack.com/archives/C02NK2DQWUX/p1683639845797519?thread_ts=1683614947.522329&cid=C02NK2DQWUX

[arielgreen]

@rushatgabhane yes, that link works. Thank you. Offer sent.

Can you please also complete the checklist here?

[arielgreen]

Calculating payments:

• 5/1 issue assigned to @allroundexperts
• 5/3 PR merged

2 business days = 50% bonus

$250 to @DinalJivani - paid
$1000 + 50% = $1500 to @allroundexperts - paid
$1000 + 50% = $1500 to @rushatgabhane - offer sent, payment pending acceptance

[arielgreen]

@rushatgabhane bump on the checklist pleas

[arielgreen]

awaiting checklist

[arielgreen]

Bumped Rushat in Slack here.

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: This is the closest PR I could find, but it's 1 year old and it's a 2px visual improvement with other pages. Let's do nothing.

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: same as above

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: don't think we should because it's a tiny UX polish

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

Sorry for the delay @arielgreen, completed the checklist!

[arielgreen]

Thank you! All payments issued. This is complete.