-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-15] [HOLD for payment 2023-11-13] [$4000] mWeb - Request/Split Bill - After pressing the back arrow to "Send/Request money" screen, the keyboard flashes #17866
Comments
Triggered auto assignment to @Christinadobrzyn ( |
Bug0 Triage Checklist (Main S/O)
|
I think this is a dupe of #17805 @parasharrajat or @dangrous would you be able to confirm? |
I don't think it is a duplicate. Here we are saying that Numberpad on the Amount page is pushed up due to the keyboard while going back. |
Thanks @parasharrajat and @s77rt - will we try to fix this in #16443 or should we open this up as a new job? |
That depends on whether this will be solved on #16443 or not. |
Given that the exact instance was highlighted in the video below (from linked issue) I think it should be fixed on that PR Bug5942090_Viewport___buttons_are_moving_when_navigating_the_menu.mp4 |
Actually the behaviour is slightly different. It looks better than it used to be, so I don't know for sure. It may be best to hear from PR reviewers/assignees. |
Checking on a regression here #16443 (comment) - if not a regression we'll continue with this as a separate job |
Sounds like this isn't a regression from the other fix but I'm not able to reproduce this. Steps:
The keyboard loads at the bottom of the screen as expected. I'll see if anyone else can reproduce this. https://expensify.slack.com/archives/C9YU7BX5M/p1682716124592779 |
@Christinadobrzyn I am able to reproduce on SG21/Chrome with build 1.3.8.5 Screen_Recording_20230428_171802_Chrome.mp4 |
Job added to Upwork: https://www.upwork.com/jobs/~01c69f6c8136159450 |
Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
I'm able to reproduce it! Adding external |
Triggered auto assignment to @tgolen ( |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.9-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-15. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Preparing for payment - here is the previous payment summary before the latest regression - #17866 (comment) Payouts due: Issue Reporter: NA Eligible for 50% #urgency bonus? N Upwork job is here. |
@Christinadobrzyn I can't still apply for this job, because "Only invited users can find, view and apply to the job". |
Ah sorry @sarious I just adjusted the visibility for the Upwork job - let me know if that helps! https://www.upwork.com/ab/applicants/1734722622674395136/job-details |
Well, but now I see another problem "Sorry, we can't let you in" |
@sarious can you send me a link to your upwork profile? |
cc @Christinadobrzyn is this ready for payment? |
@fedirjh @Christinadobrzyn sorry, but I haven't got a payment yet. |
@sarious It seems @Christinadobrzyn is currently OOO. |
Sorry I'm back, @sarious I created a new job in Upwork because the other closed. I sent an offer to you for the job so hopefully you can accept it? here's the job https://www.upwork.com/jobs/~01cee72a36de20c18b |
Hi, I think it's just a CSS issue and I can fix it in a short time. Thanks |
📣 @webstar027! 📣
|
Contributor details |
Nice, thanks! I've applied to the job by this link. |
hey @webstar027 - we've already completed this job, it's just waiting to be paid out so no need to work on this. Feel free to check out any other jobs here - https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3A%22Help+Wanted%22+label%3AExternal |
Awesome! Paid @sarious through Upwork based on this payment summary closing this out! Let me know if you need anything! |
@Christinadobrzyn Could you please process the payment for me as well ? https://www.upwork.com/nx/wm/workroom/35322243/overview |
Ah sorry, @fedirjh I thought you were paid through a different Upwork job profile. I just paid you through this Upwork job based on this payment summary. Let me know if you need anything else! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
When returning to the previous screen, the keyboard flashes
Actual Result:
After pressing the back arrow to the "Send money" or "Request money" screen, the keyboard flashes
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.4.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6028353_Screen_Recording_20230422_230654_Chrome.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: