Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-04] [HOLD for payment 2023-05-03] App crash in SFO Lounge room #17915

Closed
6 tasks
kavimuru opened this issue Apr 24, 2023 · 26 comments
Closed
6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Opened the lounge chat
  2. Saw some messages

Expected Result:

Chat are loaded fine

Actual Result:

App crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.4-0
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image (7)

Expensify/Expensify Issue URL:
Issue reported by: @johnmlee101
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682358290819999

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Apr 24, 2023
@MelvinBot
Copy link

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Christinadobrzyn
Copy link
Contributor

@sakluger
Copy link
Contributor

This just happened to me, @johnmlee101, and @neil-marcellini, all within a minute or two.

image

@johnmlee101 johnmlee101 added the DeployBlockerCash This issue or pull request should block deployment label Apr 25, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 25, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@pecanoro
Copy link
Contributor

My theory here is that after we stopped sending the participant list from the back-end to the front-end, personal details have to get up to date and during that delay, when someone that has never posted in a public room leaves a message, if their personal details are not stored in Onycx, it crashes.

@jasperhuangg
Copy link
Contributor

We need to provide some reasonable defaults in the front end wherever we're passing personal details around.

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Apr 25, 2023

taking a look at this right now.

    return (allPersonalDetails && allPersonalDetails[login]) || {
        login,
        displayName: Str.removeSMSDomain(login),
        avatar: getDefaultAvatar(login),
    };

this is called inside ReportUtils.getDisplayNameForParticipant() which is invoked in DetailsPage.js.

@jasperhuangg is my understanding correct that the login info of new users in the lounge chat room is not populated when the report chat is opened because of the delay?

@jasperhuangg jasperhuangg self-assigned this Apr 25, 2023
@jasperhuangg
Copy link
Contributor

@hayata-suenaga No, the login should be populated, I think the issue is that the new user's entry in the personal details doesn't exist yet because the bedrock job hasn't run yet. Looking into this now

@hayata-suenaga
Copy link
Contributor

   ` let details = lodashGet(this.props.personalDetails, login);`
   
   I think we can add a default here after login?

@hayata-suenaga
Copy link
Contributor

It's confusing. We're already giving default after the above line...

        if (!details) {
            details = {
                login,
                displayName: ReportUtils.getDisplayNameForParticipant(login),
                avatar: ReportUtils.getAvatar(lodashGet(details, 'avatar', ''), login),
            };
        }

@hayata-suenaga
Copy link
Contributor

I think here, we should return early if the personalDetails is undefined or null.

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Apr 25, 2023

This just happened to me, johnmlee101, and neil-marcellini, all within a minute or two.

@sakluger do you remember what you were trying to do when the app crashed? where you on the search page?

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Apr 25, 2023

Based on the stack traces provided (screenshot in OP, screenshot in Sasha's comment) we've merged and deployed two PRs to staging that should prevent the crashes from occurring:

To be clear, we were unable to reproduce either of those bugs on staging or production, since no reproduction steps were provided in this issue. But we're confident our changes should fix those issues since they address the points of failure in both stack traces.

@jasperhuangg
Copy link
Contributor

My theory here is that after we stopped sending the participant list from the back-end to the front-end, personal details have to get up to date and during that delay, when someone that has never posted in a public room leaves a message, if their personal details are not stored in Onycx, it crashes.

For posterity, I've tried this flow on both staging and production and haven't been able to trigger the crash.

@jasperhuangg jasperhuangg removed the DeployBlockerCash This issue or pull request should block deployment label Apr 25, 2023
@jasperhuangg
Copy link
Contributor

Removing deploy blocker label

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Apr 26, 2023
@melvin-bot melvin-bot bot changed the title App crash in SFO Lounge room [HOLD for payment 2023-05-03] App crash in SFO Lounge room Apr 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 26, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot

This comment was marked as duplicate.

@MelvinBot

This comment was marked as duplicate.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 27, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-05-03] App crash in SFO Lounge room [HOLD for payment 2023-05-04] [HOLD for payment 2023-05-03] App crash in SFO Lounge room Apr 27, 2023
@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.6-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@MelvinBot
Copy link

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@jasperhuangg / @hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
  • [@jasperhuangg / @hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@jasperhuangg / @hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@jasperhuangg / @hayata-suenaga] Determine if we should create a regression test for this bug.
  • [@jasperhuangg / @hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels May 2, 2023
@Christinadobrzyn
Copy link
Contributor

It doesn't look like this issue was handled by an external contributor or C+. So nothing to pay in Upwork.

@jasperhuangg do you think we need a regression test for this?

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented May 4, 2023

I think we couldn't find clear reproduction steps for this issue. Has the root cause of this identified? @jasperhuangg I read an post mortem email about issues with SF Lounge #announce room. Is that one related to this one?

@melvin-bot melvin-bot bot added the Overdue label May 8, 2023
@hayata-suenaga
Copy link
Contributor

@Christinadobrzyn I don't believe we need regression tests for this.

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2023
@Christinadobrzyn
Copy link
Contributor

Awesome! thanks @hayata-suenaga I'll close this one as complete since there's no regression test and no one external to pay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

9 participants