-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-05-04] [HOLD for payment 2023-05-03] App crash in SFO Lounge room #17915
Comments
Triggered auto assignment to @Christinadobrzyn ( |
Bug0 Triage Checklist (Main S/O)
|
Asking for a video to reproduce - https://expensify.slack.com/archives/C049HHMV9SM/p1682373378812259?thread_ts=1682358290.819999&cid=C049HHMV9SM |
This just happened to me, @johnmlee101, and @neil-marcellini, all within a minute or two. |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @hayata-suenaga ( |
My theory here is that after we stopped sending the participant list from the back-end to the front-end, personal details have to get up to date and during that delay, when someone that has never posted in a public room leaves a message, if their personal details are not stored in Onycx, it crashes. |
We need to provide some reasonable defaults in the front end wherever we're passing personal details around. |
taking a look at this right now.
this is called inside @jasperhuangg is my understanding correct that the login info of new users in the lounge chat room is not populated when the report chat is opened because of the delay? |
@hayata-suenaga No, the login should be populated, I think the issue is that the new user's entry in the personal details doesn't exist yet because the bedrock job hasn't run yet. Looking into this now |
|
It's confusing. We're already giving default after the above line...
|
I think here, we should return early if the personalDetails is undefined or null. |
@sakluger do you remember what you were trying to do when the app crashed? where you on the search page? |
Based on the stack traces provided (screenshot in OP, screenshot in Sasha's comment) we've merged and deployed two PRs to staging that should prevent the crashes from occurring:
To be clear, we were unable to reproduce either of those bugs on staging or production, since no reproduction steps were provided in this issue. But we're confident our changes should fix those issues since they address the points of failure in both stack traces. |
For posterity, I've tried this flow on both staging and production and haven't been able to trigger the crash. |
Removing deploy blocker label |
|
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.6-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-05-04. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
It doesn't look like this issue was handled by an external contributor or C+. So nothing to pay in Upwork. @jasperhuangg do you think we need a regression test for this? |
I think we couldn't find clear reproduction steps for this issue. Has the root cause of this identified? @jasperhuangg I read an post mortem email about issues with SF Lounge #announce room. Is that one related to this one? |
@Christinadobrzyn I don't believe we need regression tests for this. |
Awesome! thanks @hayata-suenaga I'll close this one as complete since there's no regression test and no one external to pay. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Chat are loaded fine
Actual Result:
App crashes
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: v1.3.4-0
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @johnmlee101
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682358290819999
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: