Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Pressing esc on small width, exits the chat report instead of closing context Menu. #18313

Closed
1 of 6 tasks
kavimuru opened this issue May 2, 2023 · 13 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kavimuru
Copy link

kavimuru commented May 2, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Reduce the width of the browser
  2. Right click on a report
  3. After the ContextMenu opens, press escape

Expected Result

The ContextMenu should close just like it does on full width

Actual Result

The report exits and goes back to the previous screen.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.8.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-03.at.12.52.05.AM.mov
Recording.462.mp4

Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683055303370669

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bea29b4225b75879
  • Upwork Job ID: 1653733127803699200
  • Last Price Increase: 2023-05-03
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 2, 2023
@MelvinBot
Copy link

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented May 2, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@laurenreidexpensify laurenreidexpensify added the External Added to denote the issue can be worked on by a contributor label May 3, 2023
@melvin-bot melvin-bot bot changed the title Pressing esc on small width, exits the chat report instead of closing context Menu. [$1000] Pressing esc on small width, exits the chat report instead of closing context Menu. May 3, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01bea29b4225b75879

@MelvinBot
Copy link

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @marcaaron (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@situchan
Copy link
Contributor

situchan commented May 3, 2023

Browser resizing issues are now on hold - #13971
And this might be fixed in navigation reboot - #11768

@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@parasharrajat
Copy link
Member

IMO, this is a duplicate issue. There should be a similar one already on GH.

@situchan
Copy link
Contributor

situchan commented May 3, 2023

I think #11930 was original issue and the behavior improved a bit in #12864 so at least prevents app stuck.

@marcaaron
Copy link
Contributor

Not a priority.

@DanutGavrus
Copy link
Contributor

DanutGavrus commented May 11, 2023

Hi, I was looking over a similar issue: 18419 and remembered about this one. As of 11/may, the reported bug seems fixed, and the modals which were causing problems(emoji, actions and message details ones), do not anymore.

But, the same bug still happens if someone opens the KeyboardShortcutsModal, and it's from a different reason than it was for the others, even if this one's also a modal. Also, we see the same bug if someone opens the DetailsPage which is not a modal, so I think here's a different root cause from the previous 2(general modals which was fixed, and KeyboardShortcuts one which still happens).

The bug for DetailsPage may get fixed after the navigation reboot, but the problem in KeyboardShortcutsModal seems to be related to manually calling hideKeyboardShortcutModal.

@marcaaron
Copy link
Contributor

If there is a similar issue then we should just let it get triaged and closed. It's up to the assignees to decide if they want to work on it or agree with the status as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

7 participants