Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Web/Desktop - Browser Resizing #13971

Closed
trjExpensify opened this issue Jan 4, 2023 · 26 comments
Closed

[Tracking] Web/Desktop - Browser Resizing #13971

trjExpensify opened this issue Jan 4, 2023 · 26 comments
Assignees
Labels
Monthly KSv2 Not a priority Planning Changes still in the thought process

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Jan 4, 2023

Coming from here and here. Creating this parent tracker to house a growing list of issues related to resizing the browser.

As a next step, we'd like someone to own addressing the plan for tackling this holistically in NewDot, such that we don't piecemeal solving individual bugs that crop up and end up with a disjointed implementation.

In the thread we agreed this is pretty low value right now as it's relatively niche and not something we expect many customers in practice to do. Nevertheless, they are repeatable bugs and worth solving if someone has spare cycles outside of higher value issues.

Known Issues
#13912
#13929
#13945
#13879
#13959
#14128
#15768
#17752
#31503

@roryabraham
Copy link
Contributor

Nice. As advocated in this thread, I think it would be great to enable landscape mode on mobile devices and tablets and support those aspect ratios as well.

@JmillsExpensify
Copy link

JmillsExpensify commented Jan 4, 2023

Interesting take. That definitely makes the project larger, but you make an good point that those are also just other aspect ratios.

@trjExpensify
Copy link
Contributor Author

Yeah, do they need to come together? That's my question really.

@sketchydroide
Copy link
Contributor

I think the resize part of it might be influenced byt the Navigation rework, since deciding what we show on a smaller screen cna be impacted by that work

@trjExpensify
Copy link
Contributor Author

Oh hm yeah, maybe. Curious what @mountiny thinks about that sentiment given that he's very close to that project?

@mountiny
Copy link
Contributor

mountiny commented Jan 7, 2023

We could hold on the navigation rework, there might be some change although after a quick look to some of the issues i am not completely sure it would be resolved.

But probably better to not spend much time on these if the situation could change after the navigation refactor

@JmillsExpensify JmillsExpensify self-assigned this Jan 12, 2023
@JmillsExpensify
Copy link

Ugh, I guess that means I need to assign myself, along with the mountain of other navigation reboot issues. 😆

@JmillsExpensify JmillsExpensify changed the title [Tracking] Web/Desktop - Browser Resizing [HOLD #11768] [Tracking] Web/Desktop - Browser Resizing Jan 12, 2023
@trjExpensify trjExpensify changed the title [HOLD #11768] [Tracking] Web/Desktop - Browser Resizing [HOLD Navigation - #11768] [Tracking] Web/Desktop - Browser Resizing Jan 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@JmillsExpensify
Copy link

Still held on navigation.

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2023
@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@melvin-bot melvin-bot bot added the Overdue label Mar 17, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@JmillsExpensify
Copy link

Still on hold.

@JmillsExpensify
Copy link

Coming off hold very soon!

@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2023
@mountiny
Copy link
Contributor

Added all the relevant issues to the https://github.com/orgs/Expensify/projects/39 and to those we need to go through and confirm if they are fixed are added to the TODO column.

@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@JmillsExpensify
Copy link

Still working to close the loop on these issues this week.

@melvin-bot melvin-bot bot removed the Overdue label Jul 12, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 14, 2023
@JmillsExpensify
Copy link

Still trying to make time for this

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@JmillsExpensify
Copy link

I'm going through the backlog of react navigation issues and this one is a doozy so I'm going to prioritize this one last.

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@JmillsExpensify
Copy link

JmillsExpensify commented Oct 12, 2023

So with the reaction navigation project over, we need to decide if this is worth tackling right now. My first instinct is no, and that this should remain on HOLD.

@trjExpensify
Copy link
Contributor Author

Yeah, I think that's fair. I kinda view it in the same bucket as the likes of supporting landscape for iPad etc.

@JmillsExpensify
Copy link

Yeah agreed. I think this is just not a priority.

@JmillsExpensify
Copy link

Very much not a priority still

@JmillsExpensify
Copy link

Still not a priority.

@JmillsExpensify
Copy link

Same

@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2024
@JmillsExpensify
Copy link

My two cents is that we should really close this issue and related issues, as we're not planning to address it anytime soon.

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
@trjExpensify
Copy link
Contributor Author

Yeah, makes sense. I agree this isn't a priority!

@JmillsExpensify
Copy link

Ok cool, thanks! I'll do the same in related issues.

@JmillsExpensify
Copy link

Also for posterity, I'm removing the HOLD given that the nav refactor has happened.

@JmillsExpensify JmillsExpensify changed the title [HOLD Navigation - #11768] [Tracking] Web/Desktop - Browser Resizing [Tracking] Web/Desktop - Browser Resizing Jan 22, 2024
@JmillsExpensify JmillsExpensify closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monthly KSv2 Not a priority Planning Changes still in the thought process
Projects
None yet
Development

No branches or pull requests

6 participants