-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracking] Web/Desktop - Browser Resizing #13971
Comments
Nice. As advocated in this thread, I think it would be great to enable landscape mode on mobile devices and tablets and support those aspect ratios as well. |
Interesting take. That definitely makes the project larger, but you make an good point that those are also just other aspect ratios. |
Yeah, do they need to come together? That's my question really. |
I think the resize part of it might be influenced byt the Navigation rework, since deciding what we show on a smaller screen cna be impacted by that work |
Oh hm yeah, maybe. Curious what @mountiny thinks about that sentiment given that he's very close to that project? |
We could hold on the navigation rework, there might be some change although after a quick look to some of the issues i am not completely sure it would be resolved. But probably better to not spend much time on these if the situation could change after the navigation refactor |
Ugh, I guess that means I need to assign myself, along with the mountain of other navigation reboot issues. 😆 |
Still held on navigation. |
Looks like something related to As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our Feel free to drop a note in #expensify-open-source with any questions. |
Still on hold. |
Coming off hold very soon! |
Added all the relevant issues to the https://github.com/orgs/Expensify/projects/39 and to those we need to go through and confirm if they are fixed are added to the TODO column. |
Still working to close the loop on these issues this week. |
Still trying to make time for this |
I'm going through the backlog of react navigation issues and this one is a doozy so I'm going to prioritize this one last. |
So with the reaction navigation project over, we need to decide if this is worth tackling right now. My first instinct is no, and that this should remain on HOLD. |
Yeah, I think that's fair. I kinda view it in the same bucket as the likes of supporting landscape for iPad etc. |
Yeah agreed. I think this is just not a priority. |
Very much not a priority still |
Still not a priority. |
Same |
My two cents is that we should really close this issue and related issues, as we're not planning to address it anytime soon. |
Yeah, makes sense. I agree this isn't a priority! |
Ok cool, thanks! I'll do the same in related issues. |
Also for posterity, I'm removing the HOLD given that the nav refactor has happened. |
Coming from here and here. Creating this parent tracker to house a growing list of issues related to resizing the browser.
As a next step, we'd like someone to own addressing the plan for tackling this holistically in NewDot, such that we don't piecemeal solving individual bugs that crop up and end up with a disjointed implementation.
In the thread we agreed this is pretty low value right now as it's relatively niche and not something we expect many customers in practice to do. Nevertheless, they are repeatable bugs and worth solving if someone has spare cycles outside of higher value issues.
Known Issues
#13912
#13929
#13945
#13879
#13959
#14128
#15768
#17752
#31503
The text was updated successfully, but these errors were encountered: