[HOLD for payment 2023-06-21] [$1000] Web - Chat - Copying messages and with marked unread generates '<_a Icon>' in the text

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #17838

Action Performed:

1. Go to https://staging.new.expensify.com/ and login and open any chat
2. Send several messages like 1,2,3,4,5,6
3. Mark as Unread somewhere in the middle of messages
4. Select all unread messages, copy and paste to compose box

Expected Result:

Messages should be copy-pasted without anything additional appearing

Actual Result:

Messages are copy-pasted with random icons and additional text appearing in between

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.9.14

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6041400_video_86__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01eab3690598891ae3
• Upwork Job ID: 1655574812209725440
• Last Price Increase: 2023-05-08

[MelvinBot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[anmurali]

I am getting a random set of icons but yes, can reproduce

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01eab3690598891ae3

[melvin-bot]

Current assignee @anmurali is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[melvin-bot]

Triggered auto assignment to @roryabraham (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[alitoshmatov]

I think this is a known issue, but I couldn't find existing one

[httol]

Reproduced. Another issue is the 'New' word also copied.

[Victor-Nyagudi]

@kbecciv The PR you've mention was reverted, but the bug still occurs in staging, so I'm not completely sure if that was the cause.

[koko57]

Hello 👋🏻 Callstack team - expert contributor group - is ready to help 🙂

[melvin-bot]

@anmurali, @roryabraham, @0xmiroslav Huh... This is 4 days overdue. Who can take care of this?

[burczu]

Hi I'm Bartek from Callstack - expert contributor group - I would like to work on this issue.

[burczu]

The PR is now ready to be reviewed!

[melvin-bot]

@burczu, @anmurali, @roryabraham, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[michaelhaxhiu]

Bumped in #expensify-open-source because the PR hasn't seen movement

[melvin-bot]

@burczu, @anmurali, @roryabraham, @0xmiroslav Still overdue 6 days?! Let's take care of this!

[0xmiros]

PR is in review

[melvin-bot]

@burczu, @anmurali, @roryabraham, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Preventing from copying contents of the Mini Report Action Context Menu #19518

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Victor-Nyagudi]

@mountiny Has this been paid out?

[mountiny]

Note for @anmurali we need to pay out $500 for original proposal help to @Victor-Nyagudi context is here thread_ts=1687503862.417719&cid=C01GTK53T8Q)

Otherwise there is $1000 to @0xmiroslav for C+ review

[0xmiros]

No PR caused regression. This issue always existed as this is the default behavior of browser selection & copy to clipboard.
But It would have been better to consider and fix this case while implementing quick reactions in mini context menu.

Regression Test Proposal

1. Go to any chat
2. Send multiple messages
3. Select part of messages with mouse drag & drop, crossing over multiple report actions
4. Hover anywhere on selected message to show mini context menu
5. press Ctrl + C
6. Paste it into composer
7. Verify that emojis or any other unnecessary text are not included in the copied text

[dylanexpensify]

Howdy all! @0xmiroslav @Victor-Nyagudi mind applying here?? 🙇‍♂️

[Victor-Nyagudi]

Hello, @dylanexpensify.

I've applied for the job.

[anmurali]

Everyone is paid

[melvin-bot]

@burczu, @anmurali, @roryabraham, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[roryabraham]

All done here