[HOLD for payment 2023-05-29] [$1000] ‘Message’ input field is not auto-focused even though it is the only input field in the page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on ‘Profile’ avatar
2. Click on ‘Workspaces’ link
3. Open an existing workspace
4. Click on ‘Manage members’ link
5. Click on ‘Invite’ button
6. Enter email address > select user > click on ‘Next’ button

Expected Result:

Message input field should be auto-focused

Actual Result:

Message input field is not auto-focused

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.9-14
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-03.04.42.18.mp4

Recording.470.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683078396397269

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0144056c8fb602a0e4
• Upwork Job ID: 1655570989713260544
• Last Price Increase: 2023-05-08

[MelvinBot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[PrashantMangukiya]

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

Within workspace invite message page, Message input field is not auto-focused even though it is the only input field in this page.

What is the root cause of that problem?

Message input field is rendered via this code.

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Lines 193 to 205 in c7a8a88

	<TextInput
	inputID="welcomeMessage"
	label={this.props.translate('workspace.inviteMessage.personalMessagePrompt')}
	autoCompleteType="off"
	autoCorrect={false}
	numberOfLines={4}
	textAlignVertical="top"
	multiline
	containerStyles={[styles.workspaceInviteWelcome]}
	defaultValue={this.state.welcomeNote}
	value={this.state.welcomeNote}
	onChangeText={text => this.setState({welcomeNote: text})}
	/>

We can see that text input component is not focused by any way on this page. This is the root cause of the problem.

What changes do you think we should make in order to solve the problem?

We have to create ref for text input and autofocus it at transition end. i.e. We have to pass onEntryTransitionEnd prop to ScreenWrapper component as shown below. Also there is default text value exist within text input, so we have to put cursor at end of the message via setSelectionRange() as shown below.

<ScreenWrapper
    onEntryTransitionEnd={() => {
        if (!this.welcomeMessageInputRef) {
            return;
        }
        this.welcomeMessageInputRef.focus();
        const length = this.welcomeMessageInputRef.value.length;
        this.welcomeMessageInputRef.setSelectionRange(length, length);
    }}
    ...
>
   ....
  <TextInput
      ref={el => this.welcomeMessageInputRef = el}
      ...
  />
   ...
</ScreenWrapper>

So this will solve the issue as shown in result video.

Note: We can also keep existing text as selected while focus the text input by using this.welcomeMessageInputRef.select() or this.welcomeMessageInputRef.setSelectionRange(0, length) if need.

What alternative solutions did you explore? (Optional)

We can also set autoFoucs and shouldDelayFocus as shown below, but it will not put cursor at the end of the existing message, so not suggested.

<TextInput
    autoFocus
    shouldDelayFocus
    ...
/>

Results

18371-InviteMemberAutoFocus.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0144056c8fb602a0e4

[melvin-bot]

Current assignee @abekkala is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[hayata-suenaga]

not overdue external label was just added now

[rasulkhan-work]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invite Message input field should be auto focussed at the end of the invite message.

What is the root cause of that problem?

No real autofocusing prop was used in the TextInput field where the message is rendered.

What changes do you think we should make in order to solve the problem?

The problem can be solved by adding 2 extra props on the faulty TextInput field.

<TextInput
   autoFocus
   selection={{ start: this.state.welcomeNote.length, end: this.state.welcomeNote.length }}
   ...
/>

expensifyrecord.mov

[melvin-bot]

📣 @rasulkhan-work! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[rasulkhan-work]

Contributor details
Your Expensify account email: rasulkhan.business@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b5b21debef186743

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[hayata-suenaga]

@mollfpr when you have chance, can you review the proposals?

[mollfpr]

Reviewing now!

[mollfpr]

@hayata-suenaga proposal from @PrashantMangukiya looks good to me! We should use the onEntryTransitionEnd; if not, it will have weird animation between transitioning the page and focusing on the input. I think we're not needed to select the text.

🎀 👀 🎀 C+ reviewed!

[hayata-suenaga]

@mollfpr thank you for the review. I agree. assigning @PrashantMangukiya

[hayata-suenaga]

reviewing now

[melvin-bot]

@PrashantMangukiya @abekkala @mollfpr @hayata-suenaga this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[hayata-suenaga]

ops forgot to update I'm approving the PR now

[hayata-suenaga]

@abekkala I belive this issue should be considered as a bonus issue as @PrashantMangukiya finished his PR within three days. I was taking time to check something in his PR but it turned out the PR is alright

if no regression arises during the wait period, that is

[hayata-suenaga]

merged!

[PrashantMangukiya]

@hayata-suenaga Thank you. I think there is some automation glitch here, because Reviewing label not applied by Melvin-bot, can you please apply the Reviewing label for the issue. Have a nice day.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.16-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Auto focus Message input field on workspace invite member page #18791

If no regressions arise, payment will be issued on 2023-05-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/287043

[abekkala]

Payments to be made on May 29:

• Issue reported by: @Natnael-Guchima [$250]
• Selected Proposal for fix: @PrashantMangukiya [$1000] + [$500 Bonus, if no regressions]
• C+ Review: @mollfpr [$1000] + [$500 Bonus, if no regressions]

[abekkala]

@mollfpr I have sent the contracts - once the checklist is done above and contracts accepted I can initiate the payments.

[mollfpr]

Thanks @abekkala

I will complete the checklist within hours.

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR. This is an improvement for the invite workspace member page; we have yet to set the autofocus before the form refactor here #18791.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough to catch this bug.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Propose regression step

1. Go to Settings > Workspace > Manage Members
2. Tap Invite button (Green)
3. Select member(s) to invite
4. Tap Next button
5. Verify that Message field is auto-focused
6. 👍 or 👎

[abekkala]

@mollfpr and @PrashantMangukiya Payments have been made and contracts ended - Thank you! 🎉

@Natnael-Guchima once you accept the contract offer in Upwork I can send your payment!

[Natnael-Guchima]

@abekkala it seems you have sent me a $1000 offer for bug reporting bonus. I think it should be 250.

[abekkala]

Hmm, ok, I thought I changed it to $250. I can redo it!

[abekkala]

@Natnael-Guchima updated to $250!

[Natnael-Guchima]

@abekkala accepted. Thanks.

[abekkala]

@Natnael-Guchima paid and contract ending - thank you! 🎉
Closing!