[HOLD for payment 2023-05-22] Payments - Paypal.me account isn't "strikethrough'ed" in App after go offline and deleted

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #17903

Action Performed:

1. Open the App
2. Sign in
3. Go to your Settings -> Payments and add a Paypal.me account
4. Go offline
5. Delete that Paypal.me account
6. Make sure that Paypal.me account still shows up but as grayed out and "strikethrough'ed"

Expected Result:

Paypal.me account is"strikethrough'ed" in all environments.

Actual Result:

Paypal.me account isn't "strikethrough'ed" in Android/iOS App

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.10.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6043215_Screen_Recording_20230505_003421_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016feb202f5cafece9
• Upwork Job ID: 1655605898197176320
• Last Price Increase: 2023-05-08

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jayeshmangwani]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Paypal.me account name/description isn't shown a strikethrough style in the Android/iOS App

What is the root cause of that problem?

We pass the strikethrough style to the parent View component and the web inherits Text styles from the View Component but the native does not
And for adding the strikethrough in native we added a code here for title, and here we are passing the strikethrough to the only title

App/src/components/MenuItem.js

Line 72 in 3585329

(_.contains(props.style, styles.offlineFeedback.deleted) ? styles.offlineFeedback.deleted : undefined),

What changes do you think we should make in order to solve the problem?

We have to check if the style prop contains the strikethrough styling that we pass from the OfflineWithFeedback component and if it contains then add the strikethrough to the Description Text, to achieve this we have to add these changes

define a const needsStrikeThrough= (_.contains(props.style, styles.offlineFeedback.deleted) ? styles.offlineFeedback.deleted : undefined)
to check if we need to show a strikethrough style for the Text
and pass the needsStrikeThrough to descriptionTextStyle

App/src/components/MenuItem.js

Lines 75 to 81 in 3585329

	const descriptionTextStyle = StyleUtils.combineStyles([
	styles.textLabelSupporting,
	(props.icon ? styles.ml3 : undefined),
	styles.lineHeightNormal,
	props.title ? descriptionVerticalMargin : undefined,
	props.descriptionTextStyle,
	]);

note: this change will affect all the pages and will add a strikethrough to the description of all the pages where we have used the MenuItem

What alternative solutions did you explore? (Optional)

If we want to add the strikethrough style on the Payment page then, here we can check if we have to show strikethrough(isOffline and deletion pending action) to the child and then pass the style to MenuItem for descriptionTextStyle

App/src/pages/settings/Payments/PaymentMethodList.js

Line 184 in 3585329

renderItem({item}) {

    const needsStrikeThrough = this.props.network.isOffline && item.pendingAction === 'delete';

App/src/pages/settings/Payments/PaymentMethodList.js

Lines 192 to 204 in 3585329

	<MenuItem
	onPress={item.onPress}
	title={item.title}
	description={item.description}
	icon={item.icon}
	disabled={item.disabled}
	iconFill={item.iconFill}
	iconHeight={item.iconSize}
	iconWidth={item.iconSize}
	badgeText={this.getDefaultBadgeText(item.isDefault)}
	wrapperStyle={item.wrapperStyle}
	shouldShowSelectedState={this.props.shouldShowSelectedState}
	isSelected={this.props.selectedMethodID === item.methodID}

    descriptionTextStyle={
        (needsStrikeThrough ? styles.offlineFeedback.deleted : undefined)  
    }

Result

[PauloGasparSv]

Hey @trjExpensify I'm assigning myself and will work on this today ok? As commented here this is related to #17903

[trjExpensify]

Hey @trjExpensify I'm assigning myself and will work on this today ok?

Sounds good!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016feb202f5cafece9

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[trjExpensify]

^^ @rushatgabhane is assigned to review the PR as a C+ already, so I've switched him on here.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix strike-through when offline and deleting Paypal for native Android/iOS #18524

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[PauloGasparSv]

Not overdue! Not sure if we should change this back to weekly though

[trjExpensify]

Daily is good now that payment is due. @rushatgabhane - I've sent a $1,000 offer to Satish for the C+ review on this job.

Can you please complete the checklist so we can close this out and issue payment? Thanks!

[trjExpensify]

Did you delete your commentary? 😅

[rushatgabhane]

@trjExpensify actually, this is a new feature! (PR: #18524)

We added strikethrough feature to MenuItem row when deleting it whilst being offline!

[rushatgabhane]

I believe that bugzero checklist isn't applicable since it's a new feature.

[rushatgabhane]

Nevermind ignore me. It clearly fails the offline tests here - #17903

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: If Paypal.me account is deleted while offline then show it as pending until back online #17903

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: If Paypal.me account is deleted while offline then show it as pending until back online #17903 (comment)

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: PR reviewers didn't follow the reviewer checklist, and are made aware of. No further discussion needed

4. Determine if we should create a regression test for this bug. No because QA caught it.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

[rushatgabhane]

checklist done! @trjExpensify

[trjExpensify]

Perfect. Works for me! Settled up!