-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix strike-through when offline and deleting Paypal for native Android/iOS #18524
Fix strike-through when offline and deleting Paypal for native Android/iOS #18524
Conversation
@rushatgabhane @neil-marcellini One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neil-marcellini all yours, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well and looks good. Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.13-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.13-5 🚀
|
Details
Payment methods were not being "striked-throughed" (but where grayed out) in Android or iOS when they were deleted offline.
This P.R. fixes that and so the strike-through is shown for offline deleted payment methods for native Android and iOS.
Why this was working on other platforms
Because the description of
MenuItem
doesn't have the styles fromstyles.offlineFeedback.deleted
but inherits them from a parent component.`MenuItem` description style inheritance before changes
Screen.Recording.2023-05-06.at.10.03.49.mov
Because of that, all the payment Methods seem to have the same problem. Also, any other component that uses
MenuItem
to display data and can be deleted probably has the same problem.Before changes:
After changes:
Fixed Issues
$ #18459
PROPOSAL: GH_LINK_ISSUE(COMMENT)
Tests
This P.R. modifies a generic component
MenuItem
so we should navigate through the App while testing. I tested pages that use that component and everything LGTM.Offline tests
This P.R. modifies a generic component
MenuItem
so we should also navigate through the App while testing offline. I tested pages that use that component and everything LGTM.QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-05-06.at.10.27.19.mov
Mobile Web - Chrome
Screen.Recording.2023-05-06.at.10.28.50.mov
Mobile Web - Safari
Can't test offline internet connectivity in the Simulator
Desktop
Screen.Recording.2023-05-06.at.10.33.21.mov
iOS
Can't test offline internet connectivity in the Simulator
Android
Screen.Recording.2023-05-06.at.10.09.10.mov