Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-06-07] Create read-only IOUConfirmationList and launch it from an IOUPreview split #18640

Closed
Julesssss opened this issue May 9, 2023 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement.

Comments

@Julesssss
Copy link
Contributor

Julesssss commented May 9, 2023

Problem

We introduced the IOUPreview for bill splits here. As the read-only IOUConfirmationList page wasn't ready we currently take the users to the IOUParticipants page when tapped. But this should be changed to launch the IOUConfirmationList as a read-only page where no edits can be made.

Solution

Yes please.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01018949f434339f12
  • Upwork Job ID: 1667164259747545088
  • Last Price Increase: 2023-06-09
@Julesssss Julesssss added Engineering Daily KSv2 Improvement Item broken or needs improvement. labels May 9, 2023
@Julesssss Julesssss self-assigned this May 9, 2023
@Julesssss Julesssss changed the title Tapping an IOUPreview split should launch read-only IOUConfirmationList [HOLD - on the IOUConfirmationList] Tapping an IOUPreview split should launch read-only IOUConfirmationList May 9, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 12, 2023

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Julesssss
Copy link
Contributor Author

Still held

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Julesssss
Copy link
Contributor Author

This is possibly unblocked now. Investigating today

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2023
@Julesssss Julesssss changed the title [HOLD - on the IOUConfirmationList] Tapping an IOUPreview split should launch read-only IOUConfirmationList Create read-only IOUConfirmationList and launch it from an IOUPreview split May 22, 2023
@JmillsExpensify
Copy link

Yeah, I think we should take this one off-hold.

@Julesssss
Copy link
Contributor Author

Okay, I just handed off another issue so will pick this one up.

@Julesssss
Copy link
Contributor Author

Made a lot of progress today. WIP PR

Remaining tasks

  • Improve URL path
  • Provide the action for amount details
  • Use action to build participants, NOT the chatReport\
  • Update the disabled fields styling (depending on the outcome of an ongoing discussion)

@Julesssss
Copy link
Contributor Author

Updated the PR today to use the real action data. Then I merged Carlos' PR into mine as it had some similar changes that further improved the solution. PR is in early review and I'll finish it tomorrow morning.

@Julesssss Julesssss added the Reviewing Has a PR in review label May 23, 2023
@Julesssss
Copy link
Contributor Author

Made lots of progress today after dealing with a particularly annoying conflict. Also made the payer item dynamic so that the component works for new and existing bill splits, as well as regular requests.

Will finish up the PR tomorrow and prepare it for review.

@Julesssss
Copy link
Contributor Author

I just resubmitted the PR for what is hopefully the final review

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 31, 2023
@melvin-bot melvin-bot bot changed the title Create read-only IOUConfirmationList and launch it from an IOUPreview split [HOLD for payment 2023-06-07] Create read-only IOUConfirmationList and launch it from an IOUPreview split May 31, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 31, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@sobitneupane
Copy link
Contributor

@Julesssss Can you please assign me the issue. I reviewed the PR.

@Julesssss
Copy link
Contributor Author

Assigned you @sobitneupane 👍

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 6, 2023
@Julesssss Julesssss added the External Added to denote the issue can be worked on by a contributor label Jun 9, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-06-07] Create read-only IOUConfirmationList and launch it from an IOUPreview split [$1000] [HOLD for payment 2023-06-07] Create read-only IOUConfirmationList and launch it from an IOUPreview split Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01018949f434339f12

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 9, 2023

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

@Julesssss
Copy link
Contributor Author

Hey @Christinadobrzyn, would you mind paying out for a C+ review from @sobitneupane? Thanks

@melvin-bot melvin-bot bot removed the Overdue label Jun 9, 2023
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Jun 9, 2023

Happy to! I just sent an invite to you @sobitneupane -

https://www.upwork.com/jobs/~01018949f434339f12

Let me know when you accept and I'll pay this out!
To confirm, I assume this was an Internal job so there's no speed bonus?

@sobitneupane
Copy link
Contributor

To confirm, I assume this was an Internal job so there's no speed bonus?

Yup

Accepted the offer @Christinadobrzyn

@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Jun 9, 2023

Thanks! Paid you in Upwork @sobitneupane. Are we good to close this?

@sobitneupane
Copy link
Contributor

Thanks @Christinadobrzyn. I believe we are good to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

4 participants