-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] [HOLD for payment 2023-06-07] Create read-only IOUConfirmationList and launch it from an IOUPreview split #18640
Comments
@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Still held |
@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
This is possibly unblocked now. Investigating today |
Yeah, I think we should take this one off-hold. |
Okay, I just handed off another issue so will pick this one up. |
Made a lot of progress today. WIP PR Remaining tasks
|
Updated the PR today to use the real action data. Then I merged Carlos' PR into mine as it had some similar changes that further improved the solution. PR is in early review and I'll finish it tomorrow morning. |
Made lots of progress today after dealing with a particularly annoying conflict. Also made the payer item dynamic so that the component works for new and existing bill splits, as well as regular requests. Will finish up the PR tomorrow and prepare it for review. |
I just resubmitted the PR for what is hopefully the final review |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.20-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-07. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
@Julesssss Can you please assign me the issue. I reviewed the PR. |
Assigned you @sobitneupane 👍 |
Job added to Upwork: https://www.upwork.com/jobs/~01018949f434339f12 |
Triggered auto assignment to @Christinadobrzyn ( |
Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new. |
Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new. |
Hey @Christinadobrzyn, would you mind paying out for a C+ review from @sobitneupane? Thanks |
Happy to! I just sent an invite to you @sobitneupane - https://www.upwork.com/jobs/~01018949f434339f12 Let me know when you accept and I'll pay this out! |
Yup Accepted the offer @Christinadobrzyn |
Thanks! Paid you in Upwork @sobitneupane. Are we good to close this? |
Thanks @Christinadobrzyn. I believe we are good to close this. |
Problem
We introduced the IOUPreview for bill splits here. As the read-only IOUConfirmationList page wasn't ready we currently take the users to the IOUParticipants page when tapped. But this should be changed to launch the IOUConfirmationList as a read-only page where no edits can be made.
Solution
Yes please.
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: