Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests - Split bill preview shows all group members even if split bill does not apply to all #19170

Closed
1 of 6 tasks
mvtglobally opened this issue May 18, 2023 · 9 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@mvtglobally
Copy link

mvtglobally commented May 18, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click the + icon in a Group conversation
  2. Open the DM create menu again and select Split Bill
  3. Enter an amount into the BNP
  4. Select part of the members of the group and tap "Split Bill"
  5. Tap to IOU preview for this request

Expected Result:

Showing only users who participate in this split bill as indicated in the IOU preview

Actual Result:

All users in the group are shown

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.15-12
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6059305_split-bill-half-group.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e5e1057110ef40b6
  • Upwork Job ID: 1659683355058298880
  • Last Price Increase: 2023-05-19
@mvtglobally mvtglobally added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@johncschuster
Copy link
Contributor

johncschuster commented May 18, 2023

@mvtglobally can you clarify what "BNP" stands for?

Also, I think the description of the issue isn't quite right.

For context, I created a Group between three users, and created a Split Bill between two of the three users.

Next, I created another Split Bill between all three users in the DM.

When I click into either Split Bill requests, I only see the two members of the first Split Bill request, so I think this is more like, "Split bill preview only shows all members of the first Split Bill request in the group DM".

Can you test for that and see if that's true?

2023-05-18_10-12-16.mp4

@luacmartins
Copy link
Contributor

@johncschuster this page is still under development. I have a draft PR here

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label May 19, 2023
@luacmartins
Copy link
Contributor

PR in review - #19196

@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e5e1057110ef40b6

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

@Nathan-Mulugeta
Copy link

Nathan-Mulugeta commented May 20, 2023

Hey team, I just want to let you know that I originally reported this issue here in slack before this GH issue was created. @luacmartins @johncschuster

@luacmartins
Copy link
Contributor

@Nathan-Mulugeta thanks for letting us know, however we had plans to completely refactor this page as part of this issue and in fact we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants