[HOLD for payment 2023-05-23] [$1000] DEV: Search items show weird undefined texts

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open search page
2. Click on the items

Expected Result:

Search item should show display name and alternate text correctly

Actual Result:

Empty display name and undefined alternate text, IOU reports disappear once opened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: DEV only
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

web.mov

iouReport.mov

bug.mov

Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683816514449429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b54ea2f8c5c60bc1
• Upwork Job ID: 1658052636709498880
• Last Price Increase: 2023-05-15

[melvin-bot]

Current assignees @JmillsExpensify and @trjExpensify are eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

@aimane-chnaif do you have a deeper idea of what's going on here? Also, is this something you want to take on? If we're opening this up external, I think we need to improve these steps. Presumably you need some iou/expenseReports etc?

1. Open search page
2. Click on the items

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[dhairyasenjaliya]

Even I can replicate with lots of undefined

[mountiny]

@dhairyasenjaliya I cannot repro in staging or locally, any idea to see what is special about these accounts?

[dhairyasenjaliya]

@mountiny What I can see from the log is if we have report type iou it shows as undefined I believe we don't have any parameter for that to display the name so the first line would show as blank since we are displaying fullName only if we have this condition satisfy this.props.option.isChatRoom || this.props.option.isPolicyExpenseChat which will never be true in this case

• We are getting undefined text in alternateText because we are not setting any alternateText in optimistic data we should set some message like Report or MoneyReport as alternateText if the report type is iou

Solution 1

• On OptionsListUtils.js we have the function createOption() here we can add one more parameter to result which is isIOUType

• Also we need to set alternateText if report type of iou in order to avoid an undefined value of the text, we need to decide message like Report or money report

• Then on OptionRow.js we can include this.props.option.isIOUType on shouldUseFullTitle props which is used inside <DisplayNames>

//OptionsListUtils.js

createOption(){

const result = {
+  isIOUType: false,
}

if (report) {
+  result.isIOUType = ReportUtils.isIOUReport(report);

        if (result.isChatRoom || result.isPolicyExpenseChat) {
            result.alternateText = showChatPreviewLine && !forcePolicyNamePreview && lastMessageText ? lastMessageText : subtitle;
+        } else if (result.isIOUType) {
+           result.alternateText = Localize.translate(preferredLocale, 'footer.expenseReports'); // might be needed new message
+        } else {
            result.alternateText = showChatPreviewLine && lastMessageText ? lastMessageText : LocalePhoneNumber.formatPhoneNumber(personalDetail.login);
        }
    }
}


//OptionRow.js

      <DisplayNames
-          shouldUseFullTitle={this.props.option.isChatRoom || this.props.option.isPolicyExpenseChat}
+          shouldUseFullTitle={this.props.option.isChatRoom || this.props.option.isPolicyExpenseChat || this.props.option.isIOUType}
       />

Result

Solution 2

• We can omit the search data report type of iou

[dhairyasenjaliya]

@mountiny

Correction on Solution 1

• In recent PR Display iou or expense in LHN #18537 we already added a function to check for isIOUReport or isExpenseReport which we have added in isMoneyRequestReport parameter we can simply use this.props.option.isMoneyRequestReport to display name

• But we still need to add alternateText inside isMoneyRequestReport parameter

[mountiny]

@dhairyasenjaliya Ok I think for now we can go with showing the report name same as in LHN of rmoney requests (expense + iou reports) and add the Expense report or something else instead of the alternate text as I am not sure if we return that from backend

Do you want to create a PR fro this?

[dhairyasenjaliya]

Yeah i think we are generating altertText from utlis helper so we can add text over there
Sure will create PR within few hours @mountiny

[mountiny]

Thank you @dhairyasenjaliya Lets get this out fast 🔥 appreciate you stepping up

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b54ea2f8c5c60bc1

[melvin-bot]

Current assignees @JmillsExpensify and @trjExpensify are eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[dhairyasenjaliya]

@mountiny @s77rt PR ready for initial review
do you think alternateText as Expense reports makes sense or we just named to other

[mountiny]

Discussing this with @trjExpensify

[trjExpensify]

Good to go here, related discussion was in the PR and here in slack.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[s77rt]

• The PR that introduced the bug has been identified: Display iou or expense in LHN #18537
• The offending PR has been commented on: Display iou or expense in LHN #18537 (comment)
• A discussion in #expensify-bugs has been started: https://expensify.slack.com/archives/C049HHMV9SM/p1684329891045849
• Determine if we should create a regression test for this bug: No

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix search preview #18941

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify / @trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

@MelvinBot Checklist provided already #18860 (comment)

[Julesssss]

Melvin's trying to double up the payment, bad bot!

[JmillsExpensify]

@trjExpensify Can you take payment on this one? I'm headed out of office the rest of this week.

[trjExpensify]

Yup, back and looking at it now.

[trjExpensify]

Okay, so payments due:

@aimane-chnaif - $250 for the bug report
@dhairyasenjaliya - $1,500 for the fix & #urgency bonus
@s77rt - $1,500 for C+ & #urgency bonus

Offers have been sent, let me know when you accept and I'll settle up. 👍

[dhairyasenjaliya]

Accepted thnx @trjExpensify

[s77rt]

Accepted!

[trjExpensify]

Settled up with all three of you, closing. Thanks everyone!