[HOLD App#18604] [$1000] Deleting a request money message shows a empty last message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open chat > Request money
2. After requesting delete it

Expected Result:

Deleting a request money message should not display a empty last message.

Actual Result:

Deleting a request money message shows a empty last message.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.13.1
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-12.20-50-13.mp4

Recording.584.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683906942740509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b71f19dcccb67b54
• Upwork Job ID: 1657138400751517696
• Last Price Increase: 2023-05-12

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

@trjExpensify @JmillsExpensify @luacmartins @mountiny @Julesssss @cristipaval tagging as per this comment in the slack

[joekaufmanexpensify]

Reproduced on staging.

2023-05-12_15-43-16.mp4

[joekaufmanexpensify]

@Julesssss LMK if your plan is to keep this internally, and I'll add that label to the issue.

[trjExpensify]

This can go external 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b71f19dcccb67b54

[melvin-bot]

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

[s-alves10]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Empty row is added when delete a request money message.

What is the root cause of that problem?

Now we don't show Reqeust bill actions with total = 0 as you can see below. We only show the latest action as shown in the description video(settled up).

App/src/components/ReportActionItem/IOUPreview.js

Lines 134 to 136 in 293f23b

	if (props.iouReport.total === 0) {
	return null;
	}

This works fine but the main reason for this issue is here.

App/src/pages/home/report/ReportActionItem.js

Lines 292 to 304 in 293f23b

	if (!this.props.displayAsGroup) {
	return (
	<ReportActionItemSingle
	action={this.props.action}
	showHeader={!this.props.draftMessage}
	wrapperStyles={[styles.chatItem, isWhisper ? styles.pt1 : {}]}
	shouldShowSubscriptAvatar={this.props.shouldShowSubscriptAvatar}
	report={this.props.report}
	>
	{content}
	</ReportActionItemSingle>
	);
	}

The content is empty, but we have its style styles.chatItem. Its value is:

App/src/styles/styles.js

Lines 1415 to 1422 in 293f23b

	chatItem: {
	display: 'flex',
	flexDirection: 'row',
	paddingTop: 8,
	paddingBottom: 8,
	paddingLeft: 20,
	paddingRight: 20,
	},

The padding style makes the empty row visible.

What changes do you think we should make in order to solve the problem?

1. Add isIOUActionNotShown function to ReportActionsUtils.js. This function would return true if the given action should be hidden.
2. In ReportActionItem.js, if the action should be hidden, the render function have to return null.

  if (ReportActionUtils.isIOUActionNotShown(this.props.report.reportID, this.props.reportActions, this.props.action)) {
     return null;
  }

4. These fixes would affect the group displaying. We need to fix the displayAsGroup props of ReportActionItem.
   

   App/src/pages/home/report/ReportActionsList.js

   Line 127 in 293f23b

   displayAsGroup={ReportActionsUtils.isConsecutiveActionMadeByPreviousActor(sortedReportActions, index)}

What alternative solutions did you explore? (Optional)

[mountiny]

I am not sure if this is best solution @s-alves10 because we will move the requests to the iou/expense reports with this PR

I will put this on hold for that PR so we can see if its reproducible there

[Julesssss]

Agree with holding.

[luacmartins]

I think this was solved here

[joekaufmanexpensify]

@luacmartins Awesome, does that mean we can close this?

[luacmartins]

@joekaufmanexpensify can we check if this is still reproducible before closing that PR should be in staging now?

[trjExpensify]

How can you delete @luacmartins when we don't have the transaction view sorted yet, it's just empty?

[luacmartins]

You can hover the IOUPreview in the IOU/Expense report and the context menu should show the delete option.

[trjExpensify]

Nada on staging:

[trjExpensify]

Okay, gave it a refresh and I can see the trash can now. Tested in a workspaceChat and a DM, still something wonky going on:

s6pcaW1SIj.mp4

[joekaufmanexpensify]

I agree it's still a bit wonky, but the bug reported in this issue is fixed, no? There is no longer an empty last message.

The settled up 0.00 alongside showing the cash request for 30.00 as completed feels a bit odd, but it feels like that's a different bug, if it is one.

[trjExpensify]

Correct, there is no longer an empty last message.

[luacmartins]

Yea, we can close this.