Use IOU/Expense reportID for IOU actions #18604

luacmartins · 2023-05-08T19:40:53Z

Add the IOU reportAction to the IOU/Expense report instead of the parent chatReport.

We are gonna start creating IOU reportActions directly in the IOU/Expense report and as part of the switch, we are temporarily skipping test so that Auth integration tests pass. The plan to make the switch is:

Merge https://github.com/Expensify/Web-Expensify/pull/37375 and CP to prod
Web-E Integrations tests in this https://github.com/Expensify/Auth/pull/7863 should pass
Merge the https://github.com/Expensify/Auth/pull/7863
Deploy the Auth PR
Merge https://github.com/Expensify/Web-Expensify/pull/37337 that re-enables tests using the correct reportID
CP the https://github.com/Expensify/Web-Expensify/pull/37337 PR to prod
Merge Use IOU/Expense reportID for IOU actions #18604, CPing it to staging to minimize the amount of time IOUs are broken
Run the bulkCQ from https://github.com/Expensify/Expensify/issues/282420 to change the reportID of all previous IOU actions

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/281893

Tests

In dev, pull these Auth and Web-E branches

Pre-requisites: 2 accounts you have access to

Request money

In accountA, go offline
Request money from a user you haven't chatted with before, + > Request money
Verify:

A new chat report is created between you and accountB. The chat should be greyed out (pending state)
A new iou report is created between you and accountB and is displayed in the LHN (this report has a different header showing the request total). The report should be greyed out (pending state)
In the iou report, you see the IOU request preview. The preview should be greyed out (pending state).

Go online and verify that all pending states are resolved, i.e. the reports and preview are no longer greyed out
From the chat report, request money again to the same user.
Verify that a new preview is added to the IOU report.

Delete request
8. Tap on the request preview and delete the request
9. Verify that a deleted the $X request message is added to the IOU report

Pay money request
10. In accountB, navigate to the IOU report with accountA
11. Tap on the pay button and settle elsewhere
12. Verify that a settled up $X message is added to the IOU report

Workspace case

In account A, create a new Workspace + > New workspace
Navigate to the Workspace chat
Repeat the steps for Request money, Delete request and Pay money request above.

Verify that no errors appear in the JS console

Offline tests

Covered above

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.mov

iOS

Android

aldo-expensify · 2023-05-12T02:15:49Z

What is the progress on this?

github-actions · 2023-05-13T13:28:13Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

melvin-bot · 2023-05-13T13:33:16Z

@eVoloshchak @amyevans One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2023-05-16T17:55:57Z

I'm not able to reproduce the delete error. What error are you getting back from the API?

As for the IOUPReview, it should still be shown.

s77rt · 2023-05-16T18:04:10Z

Error 401

{
    "jsonCode": 401,
    "message": "401 Unauthorized report NVP.",
    "onyxData": [
        {
            "onyxMethod": "merge",
            "key": "reportActions_6792924156649370",
            "value": {
                "errors": {
                    "1684260166419151": "Auth DeleteMoneyRequest returned an error"
                }
            }
        },
        {
            "onyxMethod": "merge",
            "key": "reportActions_6792924156649370",
            "value": {
                "errors": {
                    "1684260166419151": "Auth DeleteMoneyRequest returned an error"
                }
            }
        }
    ],
    "requestID": "7c8588974f9c9a17-SJC"
}

luacmartins · 2023-05-16T18:38:43Z

@s77rt that seems unrelated to the changes in this PR. We already have another internal issue to track that error.

s77rt · 2023-05-16T18:38:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.mp4

iOS

ios.mp4

Android

s77rt · 2023-05-16T18:39:50Z

@luacmartins Checklist is ready. Just waiting for a confirmation for the reported bug if it's something we should fix in this PR.

s77rt

LGTM! 🚀

melvin-bot · 2023-05-16T18:42:14Z

🎯 @s77rt, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #19057.

luacmartins · 2023-05-16T18:47:09Z

Thanks for the thorough review @s77rt

…enseReports Use IOU/Expense reportID for IOU actions (cherry picked from commit d20142b)

…-18604 🍒 Cherry pick PR #18604 to staging 🍒

OSBotify · 2023-05-16T20:06:50Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.14-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-17T00:17:40Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-05-25T23:53:22Z

src/components/ReportActionItem/MoneyRequestAction.js

-                props.chatReportID, // Needs to be changed to iouReportID
+                props.requestReportID,


@luacmartins Can you please explain why was this needed? We think this is causing this bug #19487

In case of a SPLIT action, the requestReportID is '0'. Building optimistic thread will not work as expected as the parentReportID will be '0'.

We should not be building a thread when clicking the preview on a Split action. We instead show a split details page that is being worked on here

it has to be for other cases, we should probably consider treating this a bit differntly for the split case, need to explore more there.

parasharrajat · 2023-06-09T01:56:40Z

There might be many PRs during the IOU actions to report transactions. I am not sure which one should be tagged but when these IOU reports were added, we should have also updated the LHN rendering logic to allow these reports to behave like normal chats causing this #19570 whose explanation is in #19570 (comment).

OSBotify · 2023-06-15T01:29:33Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:47:22Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

paultsimura · 2024-04-04T09:10:01Z

src/libs/actions/IOU.js

-            createdReportActionID: isNewChat ? optimisticCreatedAction.reportActionID : 0,
+            reportActionID: optimisticIOUAction.reportActionID,
+            createdChatReportActionID: isNewChatReport ? optimisticCreatedActionForChat.reportActionID : 0,
+            createdIOUReportActionID: isNewIOUReport ? optimisticCreatedActionForIOU.reportActionID : 0,


We should have added a similar logic for createdIOUReportActionID to the getSendMoneyParams function.
#38141

luacmartins added 2 commits May 8, 2023 22:27

update delete and split requests

654574d

update remaining commands

d834c6e

luacmartins self-assigned this May 8, 2023

luacmartins added 3 commits May 9, 2023 22:31

Merge branch 'main' into cmartins-createRequestsInExpenseReports

96e4d3c

resolve conflicts

e7c0c06

resolve conflicts

a0ae6e7

luacmartins added 5 commits May 12, 2023 13:20

Merge branch 'main' into cmartins-createRequestsInExpenseReports

76a878c

refactor requestMoney

bc231dd

update total

7046f6b

refactor deleteMoneyRequest

3a59bcd

create buildOnyxDataForMoneyRequest

7400977

luacmartins mentioned this pull request May 12, 2023

Use IOU/Expense reportID for IOU actions #18856

Closed

luacmartins changed the title ~~Use IOU/Expense reportID for IOU actions~~ Refactor MoneyRequest May 12, 2023

luacmartins added 6 commits May 13, 2023 11:27

fix requestMoneyTests

6e7078d

fix some splitbill test

f7f0025

fix splitBill success data

0463fee

fix tests

02458f6

rm unused vars

3056826

get default participants

d3d17c1

luacmartins changed the title ~~Refactor MoneyRequest~~ Use IOU/Expense reportID for IOU actions May 13, 2023

luacmartins added the CP Staging label May 13, 2023

luacmartins requested a review from aldo-expensify May 13, 2023 13:28

luacmartins marked this pull request as ready for review May 13, 2023 13:32

luacmartins requested a review from a team as a code owner May 13, 2023 13:32

melvin-bot bot requested review from amyevans and eVoloshchak and removed request for a team May 13, 2023 13:33

Merge branch 'main' into cmartins-createRequestsInExpenseReports

337707d

rushatgabhane mentioned this pull request May 16, 2023

[HOLD for payment 2023-05-29] [HOLD for payment 2023-05-25] Prevent creating new requests from within a settled expense report #19028

Closed

s77rt approved these changes May 16, 2023

View reviewed changes

melvin-bot bot mentioned this pull request May 16, 2023

Payment issue for E/App PR#18604 #19057

Closed

luacmartins merged commit d20142b into main May 16, 2023

luacmartins deleted the cmartins-createRequestsInExpenseReports branch May 16, 2023 18:45

OSBotify pushed a commit that referenced this pull request May 16, 2023

Merge pull request #18604 from Expensify/cmartins-createRequestsInExp…

aab4d31

…enseReports Use IOU/Expense reportID for IOU actions (cherry picked from commit d20142b)

OSBotify mentioned this pull request May 16, 2023

🍒 Cherry pick PR #18604 to staging 🍒 #19059

Merged

OSBotify added a commit that referenced this pull request May 16, 2023

Merge pull request #19059 from Expensify/OSBotify-cherry-pick-staging…

f5b54c1

…-18604 🍒 Cherry pick PR #18604 to staging 🍒

OSBotify mentioned this pull request May 16, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

OSBotify mentioned this pull request May 17, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

hoangzinh mentioned this pull request May 21, 2023

[HOLD 19119][$1000] Offline - Infinite loading in case of Send a money to the user you have never chatted before #19318

Closed

6 tasks

s77rt reviewed May 25, 2023

View reviewed changes

s77rt mentioned this pull request May 25, 2023

[$1000] Splitting bill shows deleted message for a brief moment of time #19487

Closed

6 tasks

allroundexperts mentioned this pull request Jun 8, 2023

[HOLD for payment 2023-06-07] [$1000] Pencil icon is not appearing in LHN of the Money Request/Owes chat. #19570

Closed

6 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

paultsimura reviewed Apr 4, 2024

View reviewed changes

paultsimura mentioned this pull request Apr 4, 2024

[HOLD for payment 2024-04-05] [$500] when sending money offline, the optimistically created IOU Report shows the top skeleton. #38141

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use IOU/Expense reportID for IOU actions #18604

Use IOU/Expense reportID for IOU actions #18604

luacmartins commented May 8, 2023 •

edited

Loading

aldo-expensify commented May 12, 2023

github-actions bot commented May 13, 2023

melvin-bot bot commented May 13, 2023

luacmartins commented May 16, 2023

s77rt commented May 16, 2023

luacmartins commented May 16, 2023

s77rt commented May 16, 2023

s77rt commented May 16, 2023

s77rt left a comment

melvin-bot bot commented May 16, 2023

luacmartins commented May 16, 2023

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

s77rt May 25, 2023 •

edited

Loading

luacmartins May 26, 2023

mountiny May 26, 2023

parasharrajat commented Jun 9, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

paultsimura Apr 4, 2024

		props.chatReportID, // Needs to be changed to iouReportID
		props.requestReportID,

Use IOU/Expense reportID for IOU actions #18604

Use IOU/Expense reportID for IOU actions #18604

Conversation

luacmartins commented May 8, 2023 • edited Loading

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

aldo-expensify commented May 12, 2023

github-actions bot commented May 13, 2023

melvin-bot bot commented May 13, 2023

luacmartins commented May 16, 2023

s77rt commented May 16, 2023

luacmartins commented May 16, 2023

s77rt commented May 16, 2023

Reviewer Checklist

Screenshots/Videos

s77rt commented May 16, 2023

s77rt left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 16, 2023

luacmartins commented May 16, 2023

OSBotify commented May 16, 2023

OSBotify commented May 17, 2023

s77rt May 25, 2023 • edited Loading

Choose a reason for hiding this comment

luacmartins May 26, 2023

Choose a reason for hiding this comment

mountiny May 26, 2023

Choose a reason for hiding this comment

parasharrajat commented Jun 9, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

paultsimura Apr 4, 2024

Choose a reason for hiding this comment

luacmartins commented May 8, 2023 •

edited

Loading

s77rt May 25, 2023 •

edited

Loading