Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IOU/Expense reportID for IOU actions #18604

Merged
merged 26 commits into from
May 16, 2023
Merged

Use IOU/Expense reportID for IOU actions #18604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
654574d
update delete and split requests
luacmartins May 8, 2023
d834c6e
update remaining commands
luacmartins May 8, 2023
96e4d3c
Merge branch 'main' into cmartins-createRequestsInExpenseReports
luacmartins May 9, 2023
e7c0c06
resolve conflicts
luacmartins May 10, 2023
a0ae6e7
resolve conflicts
luacmartins May 10, 2023
76a878c
Merge branch 'main' into cmartins-createRequestsInExpenseReports
luacmartins May 12, 2023
bc231dd
refactor requestMoney
luacmartins May 12, 2023
7046f6b
update total
luacmartins May 12, 2023
3a59bcd
refactor deleteMoneyRequest
luacmartins May 12, 2023
7400977
create buildOnyxDataForMoneyRequest
luacmartins May 12, 2023
6e7078d
fix requestMoneyTests
luacmartins May 13, 2023
f7f0025
fix some splitbill test
luacmartins May 13, 2023
0463fee
fix splitBill success data
luacmartins May 13, 2023
02458f6
fix tests
luacmartins May 13, 2023
3056826
rm unused vars
luacmartins May 13, 2023
d3d17c1
get default participants
luacmartins May 13, 2023
c0f8f76
use defined var
luacmartins May 13, 2023
4e13704
address some comments
luacmartins May 13, 2023
85e7e5b
refactor splitBill and buildOnyxDataForMoneyRequest
luacmartins May 13, 2023
7d180a2
address comments
luacmartins May 13, 2023
706f5a0
pass params
luacmartins May 13, 2023
a935158
use same naming
luacmartins May 13, 2023
a16b722
resolve conflicts
luacmartins May 15, 2023
3b7eb69
Merge branch 'main' into cmartins-createRequestsInExpenseReports
luacmartins May 15, 2023
6a35364
update reportID
luacmartins May 16, 2023
337707d
Merge branch 'main' into cmartins-createRequestsInExpenseReports
luacmartins May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ReportActionItem/MoneyRequestAction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const MoneyRequestAction = (props) => {
undefined,
CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
props.action.reportActionID,
props.chatReportID, // Needs to be changed to iouReportID
props.requestReportID,
Copy link
Contributor

@s77rt s77rt May 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luacmartins Can you please explain why was this needed? We think this is causing this bug #19487

In case of a SPLIT action, the requestReportID is '0'. Building optimistic thread will not work as expected as the parentReportID will be '0'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be building a thread when clicking the preview on a Split action. We instead show a split details page that is being worked on here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has to be for other cases, we should probably consider treating this a bit differntly for the split case, need to explore more there.

);

Report.openReport(thread.reportID, thread.participants, thread, props.action.reportActionID);
Expand Down
Loading
Loading