[HOLD for TestRail] [$2000] Web - Request - App crashes after user splits bills & requests money & then signs out for specific account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open www.staging.new.expensify.com
2. Sign into a valid account
3. Go to FAB menu & split bill with several user (User will be redirected to a DM)
4. Split bill within the same DM (I excluded one user)
5. Go to the FAB menu & request money to any user
6. Click on the IOU arrow within the DM with the user that was requested
7. Sign out of the account

Expected Result:

User expects to sign out with no issues

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14.4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers): emilio.utest@gmail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6056477_Crash_after_splitting_bill_and_requesting_money_and_signing_out.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013ec428eb4024725b
• Upwork Job ID: 1659231896255647744
• Last Price Increase: 2023-05-22

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jasperhuangg]

Looking into this

[jasperhuangg]

Unable to reproduce. Going to remove the deploy blocker label and add Needs Reproduction. No need to block deploy here.

Screen.Recording.2023-05-15.at.3.17.41.PM.mov

[kbecciv]

I was Only able to reproduce it with this emilio.utest@gmail.com specific account

[jasperhuangg]

@kbecciv Is there any chance you could DM the login information of this account to me so I could poke around with it?

[kbecciv]

@jasperhuangg I need to ask tester to share the magic code for this account.

[mvtglobally]

@jasperhuangg potentially related I am getting crash when settling with a different account mvtutest@gmail.com

RPReplay_Final1684383069.MP4

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013ec428eb4024725b

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

📣 @Thanos30 You have been assigned to this job by @jasperhuangg!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jasperhuangg]

Good stuff @Thanos30, nice job explaining the root of the problem clearly. You've been assigned!

[Thanos30]

Thank you @jasperhuangg , I sent a proposal on Upwork, I will have the PR ready by tonight!

[twisterdotcom]

Just waiting on a merge from @jasperhuangg: #19650 (comment)

[jasperhuangg]

@twisterdotcom It's on staging now!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.22-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make sure reportRecepient exists before rendering ParticipantLocalTime #19650

If no regressions arise, payment will be issued on 2023-06-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

Offers sent for $2k. I think I'm correct that there's no bonus here right?

[Thanos30]

Hey @twisterdotcom , thank you for the offer.

I think I am eligible for the bonus, I made the PR the same day I was assigned the job, and with a change we discussed, it was ready the following day.

Also, I believe the PR was merged within the time limit, since I was told that 29th of May is a global day off.

Correct me if I'm wrong though

[twisterdotcom]

All paid out, including bonus @Thanos30. @rushatgabhane and @jasperhuangg - do we need a test for this?

[Thanos30]

Much appreciated @twisterdotcom.

[twisterdotcom]

Bump @rushatgabhane on the question about testing? We need these steps completing: #18979 (comment)

[twisterdotcom]

Okay, nothing from @rushatgabhane or @jasperhuangg. Going to close.