-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-02] [$1000] Green icon on the left of share code is not turning white like others when hovered. #19067
Comments
Triggered auto assignment to @zanyrenney ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Green icon on the left of share code is not turning white like others when hovered. What is the root cause of that problem?The svg code of icon qrcode.svg has path as chlidren with inline fill color green, so when user hovers the icon, and change it's fill color, the new color is applied to parent SVG but the child path still with green color. Lines 1 to 5 in 811c0f3
What changes do you think we should make in order to solve the problem?remove Line 4 in 811c0f3
Result Screen.Recording.2023-05-17.at.1.18.22.AM.movWhat alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~01e7e23eb0ca73f31d |
Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Triggered auto assignment to @aldo-expensify ( |
Thanks for the proposal @ahmedGaber93. Proposal from @ahmedGaber93 looks good to me. 🎀👀🎀 C+ reviewed |
Awesome, thank you @sobitneupane @aldo-expensify - please give us the 👍🏼 when we can proceed. |
Looks good to me too. Hiring @ahmedGaber93 . |
📣 @ahmedGaber93 You have been assigned to this job by @aldo-expensify! |
@sobitneupane PR is ready for review. |
🎯 ⚡️ Woah @sobitneupane / @ahmedGaber93, great job pushing this forwards! ⚡️ The pull request got merged within 2 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀 |
Going OOO and this is pretty active so needs management by bug0 team member, as per the new process to stay assigned but assign another team member, please can you keep a watch of this. I am OOO until 8th June. Thanks! |
as a heads up, im OOO fri/mon |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.18-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-06-02. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
moving to daily since payment is due tomorrow 👍 |
Payments
|
@maddylewis applied at upwork. |
@maddylewis |
everyone is paid! @sobitneupane - will you confirm if we need a regression test for this one / review this checklist? thank you! #19067 (comment) |
just bumping @sobitneupane on the final step before we can close this one out - thanks! |
I don't think any change in review checklist is required. It is one-off case. We don't usually change items in Settings Menu. |
Regression Test Proposal:
Do we agree 👍 or 👎 |
update to regression test proposed - closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Icon on the left of share code should turn white like others when hovered.
Actual Result:
Green icon on the left of share code is not turning white like others when hovered.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.14-9
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
2.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684166606971679
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: