Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-02] [$1000] Green icon on the left of share code is not turning white like others when hovered. #19067

Closed
1 of 6 tasks
kavimuru opened this issue May 16, 2023 · 30 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented May 16, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open "Settings".
  2. Hover on share code option.

Expected Result:

Icon on the left of share code should turn white like others when hovered.

Actual Result:

Green icon on the left of share code is not turning white like others when hovered.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.14-9
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2.1.mp4
Untitled

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684166606971679

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e7e23eb0ca73f31d
  • Upwork Job ID: 1659497347649708032
  • Last Price Increase: 2023-05-19
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Sorry, something went wrong.

@ahmedGaber93
Copy link
Contributor

ahmedGaber93 commented May 16, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green icon on the left of share code is not turning white like others when hovered.

What is the root cause of that problem?

The svg code of icon qrcode.svg has path as chlidren with inline fill color green, so when user hovers the icon, and change it's fill color, the new color is applied to parent SVG but the child path still with green color.

<svg width="20" height="20" viewBox="0 0 15 14" fill="none" xmlns="http://www.w3.org/2000/svg">
<path
d="M0.666504 6H6.6665V0H0.666504V6ZM2.6665 2H4.6665V4H2.6665V2ZM8.6665 0V6H14.6665V0H8.6665ZM12.6665 4H10.6665V2H12.6665V4ZM0.666504 14H6.6665V8H0.666504V14ZM2.6665 10H4.6665V12H2.6665V10ZM13.6665 8H14.6665V12H11.6665V11H10.6665V14H8.6665V8H11.6665V9H13.6665V8ZM13.6665 13H14.6665V14H13.6665V13ZM11.6665 13H12.6665V14H11.6665V13Z"
fill="#03D47C" />
</svg>

What changes do you think we should make in order to solve the problem?

remove fill="#03D47C" from the child path here, and when the user hovers the icon, the parent SVG color with change and this path will inherit the new color.

fill="#03D47C" />

Result

Screen.Recording.2023-05-17.at.1.18.22.AM.mov

What alternative solutions did you explore? (Optional)

@melvin-bot melvin-bot bot added the Overdue label May 18, 2023
@zanyrenney zanyrenney added the External Added to denote the issue can be worked on by a contributor label May 19, 2023
@melvin-bot melvin-bot bot changed the title Green icon on the left of share code is not turning white like others when hovered. [$1000] Green icon on the left of share code is not turning white like others when hovered. May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01e7e23eb0ca73f31d

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Triggered auto assignment to @aldo-expensify (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@zanyrenney
Copy link
Contributor

Able to repro, forgot to add the screenshot:
2023-05-19_10-53-18

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2023
@sobitneupane
Copy link
Contributor

Thanks for the proposal @ahmedGaber93.

Proposal from @ahmedGaber93 looks good to me.

🎀👀🎀 C+ reviewed
cc: @aldo-expensify

@melvin-bot melvin-bot bot added the Overdue label May 22, 2023
@zanyrenney
Copy link
Contributor

Awesome, thank you @sobitneupane

@aldo-expensify - please give us the 👍🏼 when we can proceed.

@melvin-bot melvin-bot bot removed the Overdue label May 22, 2023
@aldo-expensify
Copy link
Contributor

Looks good to me too. Hiring @ahmedGaber93 .

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label May 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 23, 2023

📣 @ahmedGaber93 You have been assigned to this job by @aldo-expensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@ahmedGaber93
Copy link
Contributor

@sobitneupane PR is ready for review.

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

🎯 ⚡️ Woah @sobitneupane / @ahmedGaber93, great job pushing this forwards! ⚡️

The pull request got merged within 2 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

  • when @ahmedGaber93 got assigned: 2023-05-23 18:10:23 Z
  • when the PR got merged: 2023-05-24 20:33:37 UTC

On to the next one 🚀

@zanyrenney
Copy link
Contributor

Going OOO and this is pretty active so needs management by bug0 team member, as per the new process to stay assigned but assign another team member, please can you keep a watch of this. I am OOO until 8th June. Thanks!

@maddylewis
Copy link
Contributor

as a heads up, im OOO fri/mon

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 26, 2023
@melvin-bot melvin-bot bot changed the title [$1000] Green icon on the left of share code is not turning white like others when hovered. [HOLD for payment 2023-06-02] [$1000] Green icon on the left of share code is not turning white like others when hovered. May 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.18-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sorry, something went wrong.

@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
  • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@sobitneupane] Determine if we should create a regression test for this bug.
  • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@maddylewis / @zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Sorry, something went wrong.

@maddylewis maddylewis added Daily KSv2 and removed Weekly KSv2 labels Jun 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 1, 2023
@maddylewis
Copy link
Contributor

moving to daily since payment is due tomorrow 👍

@melvin-bot melvin-bot bot removed the Overdue label Jun 1, 2023
@maddylewis
Copy link
Contributor

maddylewis commented Jun 1, 2023

Payments

Job - https://www.upwork.com/jobs/~01e7e23eb0ca73f31d

@usmantariq96
Copy link

@maddylewis applied at upwork.

@ahmedGaber93
Copy link
Contributor

@maddylewis
This issue merged within 2 days, so I think it is eligible for a bonus.
Thanks!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Jun 1, 2023
@maddylewis
Copy link
Contributor

everyone is paid! @sobitneupane - will you confirm if we need a regression test for this one / review this checklist? thank you! #19067 (comment)

@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@maddylewis
Copy link
Contributor

just bumping @sobitneupane on the final step before we can close this one out - thanks!
#19067 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2023
@sobitneupane sobitneupane mentioned this issue Jun 6, 2023
57 tasks
@sobitneupane
Copy link
Contributor

sobitneupane commented Jun 6, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#18636

  • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#18636 (comment)

  • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

I don't think any change in review checklist is required. It is one-off case. We don't usually change items in Settings Menu.

Sorry, something went wrong.

@sobitneupane
Copy link
Contributor

Regression Test Proposal:

  1. Go to settings
  2. Hover over each menu item in the settings
  3. Verify that the icon in menu item turns white on hovering

Do we agree 👍 or 👎

@maddylewis
Copy link
Contributor

update to regression test proposed - closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants