[HOLD for payment 2023-07-21] Report preview action is not added optimistically when sending money

[mountiny]

Problem

When Sending money to another account the report preview action is not added optimistically

Why is it important

Its a bad UX as they take action and we create the request and iou report, but in the chat where they are at nothing happens

Solution

Make sure that we correctly create this action when sending money.

[luacmartins]

This is the issue for the backend https://github.com/Expensify/Expensify/issues/284588

[mountiny]

Thanks for taking this on Cristi

[melvin-bot]

@cristipaval Huh... This is 4 days overdue. Who can take care of this?

[cristipaval]

On hold for Auth PR #7976 which should be ready soon.

[melvin-bot]

@cristipaval Eep! 4 days overdue now. Issues have feelings too...

[cristipaval]

Addressing now the feedback received on the Auth PR.

[tienifr]

@cristipaval there was this External issue that has an accepted proposal, which is mostly similar to this GH. So just highlighting here in case we can make this issue External for contributors to work on since there was already a solution accepted there, unaware of this issue already created

cc @MonilBhavsar @fedirjh

[cristipaval]

This is still on hold. I wonder if we should update this issue to also add the logic for when the report action should show the workspace avatar and displayName, as stated here cc @mountiny

[mountiny]

@cristipaval I think we should do this in one go.

[cristipaval]

Alright, I feel like Auth PR is in good shape now after a few rounds of reviews. I'm going to open an App PR for this one tomorrow.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Optimistic report previews #21578

If no regressions arise, payment will be issued on 2023-07-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[maddylewis]

regression period ends on Friday - switching to daily to confirm all of the to-dos are handled 👍

[parasharrajat]

It is a new feature. BZ checklist does not apply.

[maddylewis]

hm, i'm not seeing an Upwork job link or a payment amount on this issue.

@cristipaval - is @parasharrajat the only person owed payment on this one? also, what's the payment amount?

[maddylewis]

@parasharrajat maybe you know the answer to this - #19119 (comment)

[maddylewis]

oh wait, @parasharrajat would be paid via NewDot so i think we can actually close this out.

[parasharrajat]

Payment requested.

[JmillsExpensify]

@maddylewis Can you please summarize the appropriate individual payments for all parties involved in this issue? This is holding up @parasharrajat's NewDot payments. More information on this compliance process in Slack.

[maddylewis]

yeah, i am also unsure on the payment amount (asked here - #19119 (comment)).

@parasharrajat - can you help confirm whether or not there was a bonus associated with this fix? thanks!

[parasharrajat]

There will be no bonus as it was worked internally so straight 1000.

[maddylewis]

Payments:

• no reporting bonus
• $1000 payment to @parasharrajat (paid via NewDot)

[JmillsExpensify]

Reviewed details for @parasharrajat. This is accurate based on summary from Business Reviewer and approved for payment in NewDot.