Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-12] [$1000] There is no current cell selection identifier on magic code input field once the field displays an error status #19314

Closed
3 of 6 tasks
kavimuru opened this issue May 19, 2023 · 36 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented May 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to Sign in page
  2. Enter email and click on 'continue' button
  3. Enter a wrong magic code
  4. Verify that magic code is marked red
  5. Select one of the 6 cells to correct the error

Expected Result:

Green dash should be displayed on the selected cell to give feedback on which cell is selected

Actual Result:

No selection identifier is applied on the selected cell. Alp cells look the same

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.16.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-20230517-115921.mp4
Recording.663.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684314424188259

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01975f5e132ef74741
  • Upwork Job ID: 1661387113474609152
  • Last Price Increase: 2023-05-24
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@allroundexperts
Copy link
Contributor

I think we'll need @shawnborton's feedback here on what's the best way to deal with this. Probably, a more dark red colour for the box where cursor is?

@shawnborton
Copy link
Contributor

Why is no cursor being shown?

@allroundexperts
Copy link
Contributor

Why is no cursor being shown?

I don't think that cursor is shown even for the input when its green.

@shawnborton
Copy link
Contributor

shawnborton commented May 20, 2023 via email

@melvin-bot melvin-bot bot added the Overdue label May 22, 2023
@shawnborton
Copy link
Contributor

But yeah, I would say we should fix the cursor issue first and start there. Perhaps we can even make the cursor red instead of green for these?

@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

@anmurali
Copy link

I am OOO, not sure why this got auto assigned to me. I am unassigning and rotating.

@melvin-bot melvin-bot bot removed the Overdue label May 24, 2023
@anmurali anmurali removed their assignment May 24, 2023
@anmurali anmurali added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@slafortune
Copy link
Contributor

Looks good!

@slafortune slafortune added the External Added to denote the issue can be worked on by a contributor label May 24, 2023
@melvin-bot melvin-bot bot changed the title There is no current cell selection identifier on magic code input field once the field displays an error status [$1000] There is no current cell selection identifier on magic code input field once the field displays an error status May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01975f5e132ef74741

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Triggered auto assignment to @PauloGasparSv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Expensify Expensify deleted a comment from melvin-bot bot May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 29, 2023

📣 @hoangzinh You have been assigned to this job by @PauloGasparSv!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@PauloGasparSv
Copy link
Contributor

I think @hoangzinh's proposal is good here. As soon as we update the digit it'll take the focused style.

Sorry for the delay, missed this comment!

@hoangzinh
Copy link
Contributor

@mananjadhav @PauloGasparSv PR is ready to review #19801

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 5, 2023
@melvin-bot melvin-bot bot changed the title [$1000] There is no current cell selection identifier on magic code input field once the field displays an error status [HOLD for payment 2023-06-12] [$1000] There is no current cell selection identifier on magic code input field once the field displays an error status Jun 5, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented Jun 5, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
  • [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@mananjadhav] Determine if we should create a regression test for this bug.
  • [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 11, 2023
@mananjadhav
Copy link
Collaborator

@slafortune This is ready for the payout today. Here's are the checklist items

  1. Offending PR: fix: add red border to the magic code input #18885
  2. Commented on the PR: https://github.com/Expensify/App/pull/18885/files#r1225948462
  3. I don't think any updates in the process are required or in the checklist. It's a miss. I would even classify this a feature request. We did add more than a few other behaviors related to button click and then the input focus.
  4. I recommend to add a regression test. The test steps from the PR are detailed, and also iterated to cover all the fixes. I think we should use those for regression test.

@slafortune
Copy link
Contributor

Regression test GH created -

Offers sent - @Natnael-Guchima @hoangzinh @mananjadhav

@mananjadhav
Copy link
Collaborator

Thanks. Accepted @slafortune

@Natnael-Guchima
Copy link

Accepted. Thanks @slafortune

@hoangzinh
Copy link
Contributor

Accepted. Thanks @slafortune

@slafortune
Copy link
Contributor

Paid!

@shawnborton
Copy link
Contributor

Sorry to bring this back up again, but it looks like we still aren't showing a cursor in the magic code input boxes. I thought this issue would fix that? Any ideas?

@hoangzinh
Copy link
Contributor

Screenshot 2023-07-18 at 18 19 09

This issue focused on fixed Green dash should be displayed on the selected cell in any cases. I just tested in my latest main code, and it still works. @shawnborton do you mind to share more about what cursor you mentioned above?

@hoangzinh
Copy link
Contributor

hoangzinh commented Jul 18, 2023

The only bug I found is the invalid magic codes are automatically cleared after validation failed.

@shawnborton
Copy link
Contributor

All of our inputs have a cursor in them:
image

So these should as well. This helps you identify which cell you are in.

@hoangzinh
Copy link
Contributor

@shawnborton I think we can log another issue to fix the cursor if we think it's a bug. This GH issue only fix the green dash

@shawnborton
Copy link
Contributor

I left a comment above specifically asking for the cursor to be fixed though. So I was anticipating that it would be included in this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

9 participants