-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-06-12] [$1000] There is no current cell selection identifier on magic code input field once the field displays an error status #19314
Comments
Triggered auto assignment to @anmurali ( |
I think we'll need @shawnborton's feedback here on what's the best way to deal with this. Probably, a more dark red colour for the box where cursor is? |
Why is no cursor being shown? |
I don't think that cursor is shown even for the input when its green. |
That seems like a bug as well.
…On Sat, May 20, 2023 at 3:05 PM Sibtain Ali ***@***.***> wrote:
Why is no cursor being shown?
I don't think that cursor is shown even for the input when its green.
—
Reply to this email directly, view it on GitHub
<#19314 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARWH5Q3WGATJHWXOXSSDL3XHC6R5ANCNFSM6AAAAAAYIFWP6Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
But yeah, I would say we should fix the cursor issue first and start there. Perhaps we can even make the cursor red instead of green for these? |
@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I am OOO, not sure why this got auto assigned to me. I am unassigning and rotating. |
Triggered auto assignment to @slafortune ( |
Bug0 Triage Checklist (Main S/O)
|
Looks good! |
Job added to Upwork: https://www.upwork.com/jobs/~01975f5e132ef74741 |
Current assignee @slafortune is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Triggered auto assignment to @PauloGasparSv ( |
📣 @hoangzinh You have been assigned to this job by @PauloGasparSv! |
Sorry for the delay, missed this comment! |
@mananjadhav @PauloGasparSv PR is ready to review #19801 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-12. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@slafortune This is ready for the payout today. Here's are the checklist items
|
Regression test GH created - Offers sent - @Natnael-Guchima @hoangzinh @mananjadhav |
Thanks. Accepted @slafortune |
Accepted. Thanks @slafortune |
Accepted. Thanks @slafortune |
Paid! |
Sorry to bring this back up again, but it looks like we still aren't showing a cursor in the magic code input boxes. I thought this issue would fix that? Any ideas? |
This issue focused on fixed Green dash should be displayed on the selected cell in any cases. I just tested in my latest main code, and it still works. @shawnborton do you mind to share more about what cursor you mentioned above? |
The only bug I found is the invalid magic codes are automatically cleared after validation failed. |
@shawnborton I think we can log another issue to fix the cursor if we think it's a bug. This GH issue only fix the green dash |
I left a comment above specifically asking for the cursor to be fixed though. So I was anticipating that it would be included in this fix. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Green dash should be displayed on the selected cell to give feedback on which cell is selected
Actual Result:
No selection identifier is applied on the selected cell. Alp cells look the same
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.16.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-20230517-115921.mp4
Recording.663.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684314424188259
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: