[HOLD for payment 2023-09-29] [$1000] Show different UI for a cancelled task

[thienlnam]

Right now, when a task is cancelled nothing about the task preview changes

Updates:

The task report is no longer archived. We will adjust the UI if a task parentReportID is deleted.

TODO:

• Update the taskPreview to show [Deleted task]
• Update the copy from Cancel task to Delete Task
• Show the task detailed view in a 'thread' view
• Update the header to also show [Deleted task]

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fbfabca6cddecf7f
• Upwork Job ID: 1665781150641840128
• Last Price Increase: 2023-06-05

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[shawnborton]

Can you start a Slack discussion for this? I think the strikethrough might not be a good idea because that's an offline pattern to indicate that something would be deleted

cc @JmillsExpensify @trjExpensify

Also, I'm curious why a task can even be cancelled in the first place? Why not just delete it?

[thienlnam]

Started thread here: https://expensify.slack.com/archives/C04QEB4MJEQ/p1685984349292879

Seems like what we need to do here is:
Update the taskPreview to show [deleted task]

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fbfabca6cddecf7f

[melvin-bot]

Triggered auto assignment to @greg-schroeder (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new.

[Vishrut19]

how to create a task?

[sethraj14]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show different UI for a cancelled task

What is the root cause of that problem?

We use this to show cancel task -
canceled: 'Canceled task'

What changes do you think we should make in order to solve the problem?

Change the UI for cancelled task to this

canceled: '[Deleted task]',

What alternative solutions did you explore? (Optional)

If we want to hide the task title, we can hide the title when task is deleted -

 {props.actionName !== CONST.REPORT.ACTIONS.TYPE.TASKCANCELED  && <Text style={[styles.chatItemMessage]}>{` ${taskReportName}`}</Text>}

[kushu7]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Show different UI for a cancelled task

What is the root cause of that problem?

Not a bug, its enchantment.

What changes do you think we should make in order to solve the problem?

For achieving this result. we need to refactor TaskPreview.js
We need to add childReportID prop to it. required to get current state of task.
will get report using withOnyx.

childTaskReport:{
    key:({childReportID})=> `${ONYXKEYS.COLLECTION.REPORT}${childReportID}`,
    }

then we can update component to check if task is cancelled or not.

const isTaskCancelled = props.childTaskReport.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && props.childTaskReport.statusNum === CONST.REPORT.STATUS.CLOSED
    if(isTaskCancelled) {
        return  <Text>{props.translate('task.messages.deleted')}</Text>
    }
    // other code
    return (
        ...
    )

and we need to pass childReportID prop to TaskPreview from ReportActionItem.

App/src/pages/home/report/ReportActionItem.js

Lines 239 to 245 in f104baa

	children = (
	<TaskPreview
	taskReportID={props.action.originalMessage.taskReportID.toString()}
	action={props.action}
	isHovered={hovered}
	/>
	);

we can update this to:

 <TaskPreview
    taskReportID={props.action.originalMessage.taskReportID.toString()}
    childReportID={props.action.childReportID.toString()}
    action={props.action}
    isHovered={hovered}
/>

Video

sScreen.Recording.2023-06-06.at.12.45.12.AM.mov

What alternative solutions did you explore? (Optional)

None

[aidear3]

Contributor details
Your Expensify account email: javsfdev323@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b7fc496875b2b3dd

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[spiderman128]

Contributor details
Your Expensify account email: talent111dev@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0199bfb95677b75486

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[greg-schroeder]

Hey @thienlnam is this issue complete? It seems the PR was deployed to Prod... and also seems like maybe it was 100% Internal?

[thienlnam]

The issue requires BE and FE changes - I'm currently working on the App (FE) changes in #24137

Mostly internal, but we'll still need to pay C+ for reviewing the App PR when it is ready

[greg-schroeder]

Gotcha 👍

[greg-schroeder]

Draft PR continues to be worked on

[thienlnam]

Heads down in wave 5 this week so haven't been able to get around to this

[greg-schroeder]

Sounds like Jack will get to this soon!

[greg-schroeder]

Sorry - can you help me understand where we're at on this one @thienlnam?

[thienlnam]

App PR in review!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update Canceled task flow #24137

If no regressions arise, payment will be issued on 2023-09-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[greg-schroeder]

This is internal and there's no issue reporter. So only @mollfpr requires payment. Looks like that'll be $1,000 - you can make a manual request!

[greg-schroeder]

I don't think we need the traditional C+ checklist for this, but please let me know if you disagree. Closing this out as payment will be handled via NewDot.

[JmillsExpensify]

$1,000 payment approved for @mollfpr based on comment above.