Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Assign task -Inconsistent name for button(Test Rail vs Expensify) #33192

Closed
5 of 6 tasks
izarutskaya opened this issue Dec 15, 2023 · 7 comments
Closed
5 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Dec 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: @

Action Performed:

Preconditions : User is a group member and was previously assigned a task.

  1. Log in to a Staging.new.expensify.com
  2. Navigate to task report
  3. Delete the task

Expected Result:

"cancelled task [task name]" is displayed in the task report

Actual Result:

"deleted task" is displayed in the task report

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6313301_1702571502614.bugDelete.mp4

Bug6313301_1702571502602!deltask

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c357d97ea979298a
  • Upwork Job ID: 1735756559976394752
  • Last Price Increase: 2023-12-15
@izarutskaya izarutskaya added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 15, 2023
@melvin-bot melvin-bot bot changed the title Assign task -Inconsistent name for button(Test Rail vs Expensify) [$500] Assign task -Inconsistent name for button(Test Rail vs Expensify) Dec 15, 2023
Copy link

melvin-bot bot commented Dec 15, 2023

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Dec 15, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c357d97ea979298a

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 15, 2023
Copy link

melvin-bot bot commented Dec 15, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Dec 15, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Dec 15, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

Assign task -Inconsistent name for button(Test Rail vs Expensify)

What is the root cause of that problem?

We use different translate

What changes do you think we should make in order to solve the problem?

We can update the translation here or create new translation (since this translation is used in several places)

canceled: 'deleted task',

And add the ability to pass custom params to pass custom names here

return Localize.translateLocal('task.messages.canceled');

<Text style={[styles.chatItemMessage, styles.colorMuted]}>{TaskUtils.getTaskReportActionMessage(actionName)}</Text>

Additional information we can get from props.report

For task name we can use props.report.reportName

children = <TaskAction actionName={props.action.actionName} />;

since this translation is used in several places, we can update the translation there too

What alternative solutions did you explore? (Optional)

NA

@parasharrajat
Copy link
Member

It seems intentional #19504. @bfitzexpensify

@bfitzexpensify
Copy link
Contributor

Agreed. Let's close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

4 participants