[HOLD for payment 2023-06-21] [HOLD for payment 2023-06-13] [$1000] Web - Chat - Tiny dots displayed in link name for message/link [([some])](https://google.com)

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #19216

Action Performed:

1. Login to NewDot
2. open any chat
3. Send a message ([some])

Expected Result:

Link name should be properly displayed

Actual Result:

Link name has tiny dots y each side

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• Windows/ Chrome
• MacOS / Desktop

Version Number: 1.3.18.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/e3fdf4ff0f7cba80fbc71cca478f3bd9258dc24d7581d2e73445d43a8de640fe

https://platform.applause.com/services/links/v1/external/71f0c644a8455e916d3e34302c5cbee88f362afa2462b29c500071edbee95ba4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ba74c4f4301a7d85
• Upwork Job ID: 1663970460633702400
• Last Price Increase: 2023-05-31

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

that's dot is actually the text decoration line, because by default browsers will “skip” areas where the “ink” of a character crosses an underline. We can fix this issue by adding the text-decoration-skip-ink: none; to our a tag but this property is not really supportive all the browsers so I'm not sure if we should fix this issue.

Browser compatibility

[spcheema]

Proposed solution

Please re-state the problem that we are trying to solve in this issue.

Tiny dots displayed in link name for message/link ([some])

What is the root cause of that problem?

Dots appear because of text decoration line text underline is cut by special characters due to their height.

What changes do you think we should make in order to solve the problem?

It can fixed with text-underline-position: under css property. Solution This way browser’s rendering engine will take care of it. It’s supported by all latest browsers.

Additionally, set text-decoration-skip-ink: none; to make sure extended height char like j, g,p, y also renders perfectly.

• https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-line
• https://caniuse.com/?search=text-underline-position

Browser support

Also see Can I Use

What alternative solutions did you explore? (Optional)
N/A

[melvin-bot]

📣 @spcheema! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ba74c4f4301a7d85

[melvin-bot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[melvin-bot]

Triggered auto assignment to @PauloGasparSv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[michaelhaxhiu]

Weird, let's fix it. Should be low effort and already got some proposals above.

[towkir]

@michaelhaxhiu is this available for external contributors?
If so, do I have to submit a new proposal or can work / submit PR based on the existing ones?
Thanks

[narefyev91]

@michaelhaxhiu @PauloGasparSv proposal of @spcheema looks good to me

[melvin-bot]

📣 @spcheema You have been assigned to this job by @michaelhaxhiu!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[michaelhaxhiu]

@towkir check out this page for guidance on how it works to propose a solution for a job. Contributor only work on a PR after being selected for their proposal.

https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md

[spcheema]

Hi @michaelhaxhiu I have applied for the job on upwork yesterday. I will have PR ready in soon (ideally 1-2 days)

[spcheema]

Contributor details
Your Expensify account email: mannecheema@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01f7b921c5dd619819

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Pujan92]

@spcheema @narefyev91 @PauloGasparSv Seems a regression issue from this PR. Slack link

[spcheema]

@Pujan92 it's warning (not error) from react native compiler that text property isn't supported since anchor is rendering as a text element on iOS platform. That's why this wasn't fixed in iOS devices. As explained here #20147 (comment)

[spcheema]

@spcheema @narefyev91 @PauloGasparSv otherwise we can exclude styles for iOS explicitly but when these properties are supported in future we need to raise a new PR.

[Pujan92]

@spcheema I think this needs to be resolved as we usually avoid warnings too. For the cursor prop warnings solution, we do have separate style files.

[PauloGasparSv]

@spcheema I think this needs to be resolved as we usually avoid warnings too. For the cursor prop warnings solution, we do have separate style files.

I agree, thks for the help here @Pujan92! I don't think we caught that warning in reviews : )

we can exclude styles for iOS explicitly but when these properties are supported in future we need to raise a new PR.

@spcheema I think that's the way to go! Could you please create a follow up P.R. that fixes that warning on iOS?

[spcheema]

@PauloGasparSv PR is on the way. Testing android right now. We may have to exclude Android along with iOS

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix native style warnings #20462

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[spcheema]

@narefyev91 @michaelhaxhiu @PauloGasparSv friendly reminder about this issue. Thank you 🙏🏼

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR: Fix native style warnings #20462
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - [HOLD for payment 2023-06-21] [HOLD for payment 2023-06-13] [$1000] Web - Chat - Tiny dots displayed in link name for message/link [([some])](https://google.com) #19646 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1686163862186549
• Determine if we should create a regression test for this bug - no needs - it was mostly clean up for warnings

[spcheema]

@PauloGasparSv I am still new to the process. This is my first issue. I am not sure what's the next step once PR is merged and pushed to prod #19646 (comment).

[PauloGasparSv]

@PauloGasparSv I am still new to the process. This is my first issue. I am not sure what's the next step once PR is merged and pushed to prod #19646 (comment).

Since the last "deployed to production" message states payment should be due today I think we just need to wait on @michaelhaxhiu for compensation

[michaelhaxhiu]

Ok so just to be clear... there was 1 regression is that right? I am asking so that I can sort out the correct payment amounts.

[PauloGasparSv]

Ok so just to be clear... there was 1 regression is that right? I am asking so that I can sort out the correct payment amounts.

Yes @michaelhaxhiu, we had 1 regression mentioned here and fixed by #20462!

[michaelhaxhiu]

Ok so the payout would be:

• contributor = $1000
• C+ = $500 (50% dock for regression) jk no payment because Nicolay is contracted via callstack

[spcheema]

@michaelhaxhiu I am not sure about but referring to @narefyev91 comment here

Determine if we should create a regression test for this bug - no needs - it was mostly clean up for warnings

But yet @narefyev91 @PauloGasparSv can answer this question since I am new to this one.

[spcheema]

@michaelhaxhiu I have already applied to the job on Upwork

[michaelhaxhiu]

paid.

[spcheema]

Thank you Michael @PauloGasparSv @narefyev91