Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-15] [Navigation Refactor] Implement the Stack navigation into NewDot #19665

Closed
mountiny opened this issue May 26, 2023 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

Last step of #11768

The last PR which entails all the navigation changes so it will deprecate drawer navigation and move to using stack navigation throughout the app.

Thoroughly tested with full regression suite of QA. Tested with contributors too.

@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. labels May 26, 2023
@mountiny mountiny self-assigned this May 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 26, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 26, 2023
@mountiny mountiny added the Reviewing Has a PR in review label May 26, 2023
@sakluger
Copy link
Contributor

Hey @mountiny, need me to do anything here? Looks like the reviewer is from one of Software Mansion which I assume we pay outside of Upwork.

@WoLewicki
Copy link
Contributor

Commenting 😅

@mountiny
Copy link
Contributor Author

@sakluger nothing yet, there might be C+ review payment required at the end, thanks!

@sakluger
Copy link
Contributor

sakluger commented Jun 4, 2023

@mountiny I'm OOO for a week and a half. If any payments need to be made before that, please remove me and add the Bug label to assign another BZ team member.

@mountiny
Copy link
Contributor Author

mountiny commented Jun 5, 2023

PR should be merged this week

@mountiny
Copy link
Contributor Author

mountiny commented Jun 6, 2023

Alright, this is done!

@mountiny mountiny closed this as completed Jun 6, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 8, 2023
@melvin-bot melvin-bot bot changed the title [Navigation Refactor] Implement the Stack navigation into NewDot [HOLD for payment 2023-06-15] [Navigation Refactor] Implement the Stack navigation into NewDot Jun 8, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 8, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.25-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants