[HOLD for payment 2023-06-13] [$1000] Dev: Not able to run storybook

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to the app folder on terminal
2. Run command: npm run storybook

Expected Result:

Not able to run storybook

Actual Result:

Crash during building storybook

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: n/a

Reproducible in staging?: n/a

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Robert Kozik (@robertKozik)

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685043545129419

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ba9220f901f5a917
• Upwork Job ID: 1664323419533189120
• Last Price Increase: 2023-06-01

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Storybook not running on dev

What is the root cause of that problem?

The root cause of the issue is that this function returns undefined because the envFile parameter as supplied here, gets converted to '' when split by . as seen here.

What changes do you think we should make in order to solve the problem?

We just need to change this to:

.env.production

What alternative solutions did you explore? (Optional)

None

[sakluger]

I don't have a dev environment, but @neil-marcellini was able to reproduce. Marking as external.

[sakluger]

Oh wait, this is a duplicate of #15042. Closing.

[allroundexperts]

Oh wait, this is a duplicate of #15042. Closing.

@sakluger I don't think that the two are related.

[neil-marcellini]

Oh yeah this is different from #15042, where the problem is opening storybook on staging.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ba9220f901f5a917

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Triggered auto assignment to @francoisl (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[sakluger]

Sorry about that, thanks for reopening! I've added the external label, looks like we already have a few proposals which is great.

[fedirjh]

@allroundexperts I think the root cause is that we pass the wrong envFile path as a parameter

App/.storybook/webpack.config.js

Line 7 in 145dd4b

envFile: '../.env.production',

Why don't we simply update it as follows?

const custom = require('../config/webpack/webpack.common')({
    envFile: '.env.production',
});

[allroundexperts]

@allroundexperts I think the root cause is that we pass the wrong envFile path as a parameter

App/.storybook/webpack.config.js

Line 7 in 145dd4b

envFile: '../.env.production',

Why don't we simply update it as follows?

const custom = require('../config/webpack/webpack.common')({
    envFile: '.env.production',
});

I think because this statement will fail. Although this statement won't get executed for storybook, but still I think we should not pass in a wrong path.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jliexpensify]

Hi @sakluger you want to take this one as B0? I notice you re-assigned yourself.

[sakluger]

@jliexpensify when we are headed OOO, we're supposed to assign another team member but also leave ourself assigned according to this Slack post: https://expensify.slack.com/archives/C01SKUP7QR0/p1684185896898599?thread_ts=1684163684.524419&cid=C01SKUP7QR0

[jliexpensify]

Hmm I see your OOO comment now, but it weirdly didn't show up when I glanced at this issue the other day. Sorry about that!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] feat: fix storybook #20097

If no regressions arise, payment will be issued on 2023-06-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts / @fedirjh] Determine if we should create a regression test for this bug.
• [@allroundexperts / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger / @jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fedirjh]

@sakluger I think the BZ is not required for this bug , we added CI check for storybook in this PR #19998 , so this issue won't pass the PR review. Let me know if we should fill the checklist.

[jliexpensify]

Hi, I can pay this if Sasha is OOO. Looks like it was merged within a day so there's a bonus applicable.

@francoisl - is there any need to fill out the checklist?

[francoisl]

Yeah, since we added automated tests, I agree we don't need to add other regression tests.

Maybe let's at least identify the PR that added the regression and make sure that it was tested properly? So basically do the first two checkboxes of the checklist.

[fedirjh]

• Link to the PR: This introduced the bug is Fix storybook build #7955 but it remained hidden.
• This PR caused a bug to arise : Animate splash screen #17477
• Link to comment: Animate splash screen #17477 (comment)
• Link to discussion: We have a checklist item to verify that storybook works as expected. This bug should have been caught during PR review.

[jliexpensify]

@robertKozik I can't seem to find you on Upworks, can you apply here for the $250 reporting bonus?

https://www.upwork.com/jobs/~01ba9220f901f5a917

[jliexpensify]

@fedirjh and @allroundexperts - have paid you with bonus. Waiting on @robertKozik

[robertKozik]

Hi! Im contributor from Software Mansion agency so I'm not eligible to payment 😄

[jliexpensify]

Yeah that'd explain it, thanks Robert!

[jliexpensify]

Job removed, closing!