Deploy Checklist: New Expensify 2023-05-29

[OSBotify]

Release Version: 1.3.20-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix Edited Line Through Alignment #17781
• Open report for anonymous users #18293
• Personal details - DOB field updating once year or month has been changed #18577
• Migrate BasePreRenderer to PressableWithoutFeedback #19083
• Added go to room menu items to workspace #19295
• 17010 — migrate BaseTextInput to PressableWithoutFeedback #19322
• Build read-only bill split details page #19390
• 17012 migrate BankAccountStep to PressableWithoutFeedback #19436
• Combine Split Bill details page PRs #19452
• Fix - bank account user goes to connect manually flow after start over offline #19491
• Fix QR image show OldDot avatar for a moment after profile avatar being removed #19521
• Truncate Task assignee email with ellipses when using long email when create a new Task #19547
• Use actor avatar for all threads #19551
• Fix text not center in QRPage #19566
• Fix 18686 no message below the email field after close account #19579
• Fix: Workspace's invite member message text area does not auto scroll #19582
• fix: show correct copy to clipboard option for linked emails #19599
• Fix missing markdown style on mention #19610
• 17022 — migrate BaseValidateCodeForm to PressableWithFeedback #19622
• 18113 holding down on plus fab releasing does not open drawer #19625
• fix left part of conditional rendering not boolean on SignInPage, TaskHeader components #19639
• feat: allow chatReportSelector to return the object for IOU reports #19644
• Bypass policyRooms beta when trying to access policy rooms #19649
• Fix emoji reaction picker and tooltip wrong position #19659
• 17030 - migrate ReportActionItemCreated to PressableWithoutFeedback #19663
• [NoQA] Add more files to .prettierignore instead of running prettier against *.js files only. #19666
• 17025 - migrate ModalHeader to PressableWithFeedback #19668
• 17026 - migrate CurrencySymbolButton to PressableWithoutFeedback #19674
• Reverting EmojiPicker Animation #19680
• Fix 19362: Show green line on top when the first thread message is mark as unread #19719
• Migrate AttachmentPicker/index.js to functional component #19734
• Fix unit rates #19748
• Include chat and iou reports in options search #19758
• Add welcomeMessage default #19759
• fix crash when open report for anonymous user #19818
• fix blank screen appears for a moment when logout #19841
• Fix chat loading after anonymous user clicks on sign-in #19866

Internal QA:

• Add DeviceID property on device info on sign in #19739 - @danieldoglas

Deploy Blockers:

• [$1000] [Awaiting bug report payment on June 5th] Blank page is displayed on closing account #19814
• [HOLD for payment 2023-06-07] [Awaiting bug report payment on June 5th] App crashes when opening report as anonymous user #19823
• [HOLD for payment 2023-06-08] [HOLD for payment 2023-06-07] [$1000] Black screen appears for moment when logout of the android app #19839

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.20-1 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.20-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.20-2 has been deployed to staging 🎉

[Julesssss]

Checked off the only current internal QA issue: #19739

[Julesssss]

A PR was CP'd to resolve the two blockers.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.20-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.20-3 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.20-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.20-4 has been deployed to staging 🎉

[mvtglobally]

@Julesssss Regression is completed

PR #18577 is failing #19852. pls double check as we cant repro in prod.
PR #19295 is failing #19813
PR #19390 is failing #19855
PR #19491 is failing #19863. repro in PROD checking off
PR #19521 is blocked on Desktop. rest platforms are pass. OK to check it off?
PR #19579 is failing #19814
PR #19582 is failing #18918
PR #19610 is failing #19857. repro in PROD checking off
PR #19639 is failing #19848. repro in PROD checking off
PR #19818 & #18293 is failing #19856

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.20-5 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.20-5 has been deployed to staging 🎉

[Julesssss]

Thanks @mvtglobally. I've reviewed all of these and think the only actionable issues are the three below. Could you please check my comments for these three? I think we're good to deploy but just want to confirm the following points:

---

Remaining questions

PR #19521 is blocked on Desktop. rest platforms are pass. OK to check it off?

A) Is testing blocked? It seems okay in the contributors video, so I think we're good ✅

PR #19579 is failing #19814

B) 🚧 - We CP'd this fix. And I can confirm it's working now on staging-- could you please retest though?

PR #19582 is failing #18918

C) ❓is that the correct link? It shows a two-week old issue

---

Checked items

PR #18577 is failing #19852. pls double check as we cant repro in prod.

✅ - Not a blocker, but we'll need to fix the issue you raised

PR #19295 is failing #19813

✅ - Not a blocker

PR #19390 is failing #19855

✅ - Dupe of this one, but it's also not a blocker

PR #19491 is failing #19863. repro in PROD checking off

✅

PR #19610 is failing #19857. repro in PROD checking off

✅

PR #19639 is failing #19848. repro in PROD checking off

✅

PR #19818 & #18293 is failing #19856

✅ - Nice find and we'll fix this, but it's not a blocker

[Julesssss]

• Blockers are cleared
• App timing shows some slow down over the past few weeks, but this is likely due to AddComment regression -- we should keep an eye on this
• No new Firebase exceptions on iOS or Android

[mvtglobally]

@Julesssss
We are good with #19521. Testers retested and it can be checked off
#19579 - retesting
#19582 this is good to check off. Old issue still repro

[Julesssss]

That's great, thank you

[mvtglobally]

@Julesssss #19579 is pass
#19866 is pass on all but Desktop. Can you check Desktop on your side? It will take me a bit longer to validate

[Julesssss]

Okay, so I'm unable to verify on Desktop. But I think this is fine and not a blocker. The single desktop app issue is far less important than having the feature live in staging for our Render ATL demo.

I'm going to check off #19866 and leave a note on the issue

[Julesssss]