Added go to room menu items to workspace #19295

alitoshmatov · 2023-05-19T15:31:52Z

Details

In workspace three dot menu, added items to go to #announce and #admins page

Fixed Issues

$ #18896
PROPOSAL: #18896 (comment)

Tests

Go to Workspace page
Press three dots
Make sure that followings are present a)Go to #admins room b)Go to #announce room
Press any one of them
Make sure it navigates to corresponding workspace room

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

18896-web.mov

Mobile Web - Chrome

18896-mweb.mp4

Mobile Web - Safari

18896-safari.mp4

Desktop

18896-desktop.mov

iOS

18896-ios.mp4

Android

18896-android.mp4

melvin-bot · 2023-05-19T15:31:58Z

@marcaaron @abdulrahuman5196 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-05-20T09:57:35Z

@alitoshmatov There are 2 issues I am seeing

On mobile web, after navigating to the admins/announce room, if i press on the top left back button it leads to homepage, but hardware back leads to workspace initial page which is inconsitent. I assume the same should be happening for native as well.
I am seeing this weird bug in Firefox web browser with this change. Could you kindly check on this?

screen-recording-2023-05-20-at-24933-pm_3LuM8F1z.mp4

alitoshmatov · 2023-05-20T17:48:52Z

@abdulrahuman5196
The first issue is not present in native app. It is caused by how we handle navigation in our app. We use react-navigation and it handle navigation difirent from how it is done by browser itself. When we open settings page and close it is not recorded to history in react navigation but it is recorded in browser, thus when we navigate to room and trigger browser's navigation it is opening workspace.

alitoshmatov · 2023-05-20T17:54:20Z

Issue 2. I couldn't find what is causing this. When we navigate to room, immidiately navigate to settings/workspace is also happening. And it is not happening everytime, and sometimes it is working as expected.

Tried to find similar scenario where navigation happened to outside from settings drawer, but couldn't find it.

abdulrahuman5196 · 2023-05-20T18:01:26Z

@alitoshmatov The issue 2 happens to me everytime. Only time it doesn't happen is when I am already in the workspace room and navigate again to the same room.

abdulrahuman5196 · 2023-05-21T11:56:56Z

@alitoshmatov I did a quick dive deep check and it seems both the issues I have pointed out is available in main as well. So I think we should good for this PR since this doesn't create those issues. I will file the issues in our bugs channel. It should be related to react navigation anyway.

abdulrahuman5196 · 2023-05-21T13:47:15Z

@marcaaron The changes looks good and have verified at platforms at added the reviewers checklist as well.
If you could confirm on the translation - #18896 (comment).
We should be good.

alitoshmatov · 2023-05-24T10:23:27Z

@abdulrahuman5196 Updated spanish version of message based on slack response https://expensify.slack.com/archives/C01GTK53T8Q/p1684872852297929?thread_ts=1684826176.793429&cid=C01GTK53T8Q

abdulrahuman5196 · 2023-05-24T16:19:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Untitled.20.mp4

Mobile Web - Chrome

Untitled.17.mp4

Mobile Web - Safari

Untitled.21.mp4

Desktop

Untitled.18.mp4

iOS

Untitled.19.mp4

Android

Untitled.22.mp4

abdulrahuman5196

Changes looks good and checklist is also complete

hayata-suenaga

LGTM

OSBotify · 2023-05-26T23:32:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-30T00:28:05Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.20-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-31T16:35:18Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.20-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

0xmiros · 2023-07-28T14:08:54Z

src/pages/workspace/WorkspaceInitialPage.js

+     */
+    const goToRoom = useCallback(
+        (type) => {
+            const room = _.find(props.reports, (report) => report && report.policyID === policy.id && report.chatType === type);


Thread reports were not considered in this filter condition, which caused this regression:

[Hold for Miro][HOLD for payment 2023-07-28] [$1000] Web - user is navigated to thread when clicking on “Go to #admins” or "Go to #announce room" in the workspace settings #21961

wait I'm confused here why did I self request a review???

ah I see Marc was OOO

anyway, thank you for reporting Miroslav 🙇

allroundexperts · 2023-12-19T11:17:34Z

src/pages/workspace/WorkspaceInitialPage.js

+            icon: Expensicons.Hashtag,
+            text: props.translate('workspace.common.goToRoom', {roomName: CONST.REPORT.WORKSPACE_CHAT_ROOMS.ADMINS}),
+            onSelected: () => goToRoom(CONST.REPORT.CHAT_TYPE.POLICY_ADMINS),
+        },
+        {
+            icon: Expensicons.Hashtag,
+            text: props.translate('workspace.common.goToRoom', {roomName: CONST.REPORT.WORKSPACE_CHAT_ROOMS.ANNOUNCE}),
+            onSelected: () => goToRoom(CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE),
+        },


We missed an edge case here. This showed up even when the data was not loaded. This resulted in a crash. #30381

Added go to room menu items to workspace

31dd191

alitoshmatov requested a review from a team as a code owner May 19, 2023 15:31

melvin-bot bot requested review from abdulrahuman5196 and marcaaron and removed request for a team May 19, 2023 15:31

alitoshmatov mentioned this pull request May 19, 2023

[PAID] [$1000] Feature Request: Implement an option to go to #admin room from the workspace editor #18896

Closed

Fixed prettier problem

90a6efb

This comment was marked as outdated.

Sign in to view

Updated es string based slack response

1486ea8

abdulrahuman5196 approved these changes May 24, 2023

View reviewed changes

hayata-suenaga self-requested a review May 26, 2023 22:59

hayata-suenaga approved these changes May 26, 2023

View reviewed changes

hayata-suenaga merged commit 37163b0 into Expensify:main May 26, 2023

OSBotify mentioned this pull request May 29, 2023

Deploy Checklist: New Expensify 2023-05-29 #19785

Closed

44 tasks

lanitochka17 mentioned this pull request May 30, 2023

Web - Workspace - Clicking on "Go to #admins room" the WS setting page appears for a moment. #19813

Closed

6 tasks

0xmiros reviewed Jul 28, 2023

View reviewed changes

0xmiros mentioned this pull request Jul 28, 2023

[Hold for Miro][HOLD for payment 2023-07-28] [$1000] Web - user is navigated to thread when clicking on “Go to #admins” or "Go to #announce room" in the workspace settings #21961

Closed

6 tasks

allroundexperts reviewed Dec 19, 2023

View reviewed changes

allroundexperts mentioned this pull request Dec 19, 2023

[HOLD for payment 2023-12-11] [$500] Workspace - When going to "Announcement" room on Specific account, app crashes #30381

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added go to room menu items to workspace #19295

Added go to room menu items to workspace #19295

alitoshmatov commented May 19, 2023

melvin-bot bot commented May 19, 2023

This comment was marked as outdated.

abdulrahuman5196 commented May 20, 2023 •

edited

Loading

alitoshmatov commented May 20, 2023

alitoshmatov commented May 20, 2023

abdulrahuman5196 commented May 20, 2023

abdulrahuman5196 commented May 21, 2023 •

edited

Loading

abdulrahuman5196 commented May 21, 2023

alitoshmatov commented May 24, 2023

abdulrahuman5196 commented May 24, 2023 •

edited

Loading

abdulrahuman5196 left a comment •

edited

Loading

hayata-suenaga left a comment

OSBotify commented May 26, 2023

OSBotify commented May 30, 2023

OSBotify commented May 31, 2023

0xmiros Jul 28, 2023

hayata-suenaga Jul 28, 2023

hayata-suenaga Jul 28, 2023

allroundexperts Dec 19, 2023

Added go to room menu items to workspace #19295

Added go to room menu items to workspace #19295

Conversation

alitoshmatov commented May 19, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 19, 2023

This comment was marked as outdated.

abdulrahuman5196 commented May 20, 2023 • edited Loading

alitoshmatov commented May 20, 2023

alitoshmatov commented May 20, 2023

abdulrahuman5196 commented May 20, 2023

abdulrahuman5196 commented May 21, 2023 • edited Loading

abdulrahuman5196 commented May 21, 2023

alitoshmatov commented May 24, 2023

abdulrahuman5196 commented May 24, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment • edited Loading

Choose a reason for hiding this comment

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented May 26, 2023

OSBotify commented May 30, 2023

OSBotify commented May 31, 2023

0xmiros Jul 28, 2023

Choose a reason for hiding this comment

hayata-suenaga Jul 28, 2023

Choose a reason for hiding this comment

hayata-suenaga Jul 28, 2023

Choose a reason for hiding this comment

allroundexperts Dec 19, 2023

Choose a reason for hiding this comment

abdulrahuman5196 commented May 20, 2023 •

edited

Loading

abdulrahuman5196 commented May 21, 2023 •

edited

Loading

abdulrahuman5196 commented May 24, 2023 •

edited

Loading

abdulrahuman5196 left a comment •

edited

Loading