[Hold for Miro][HOLD for payment 2023-07-28] [$1000] Web - user is navigated to thread when clicking on “Go to #admins” or "Go to #announce room" in the workspace settings

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Prerequisites:

• one of the default workspace rooms (#announce / #admins) needs to have a thread to reproduce

1. Login as user A
2. Click on account’s avatar on LHN to view account setting
3. Select Workspaces
4. Click on a workspace to view details
5. Click on More menu (three dots icon on the top right corner)
6. Select “Go to #admins room” or “Go to #announces” room

Expected Result:

User should be taken to the #admins or #announce room

Actual Result:

If the room contains a thread, the user is navigated to the threadReport in the room.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.33-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Go-to-room-issue.mov.mov

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688019228481189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01916b494f3ed66140
• Upwork Job ID: 1675847212932358144
• Last Price Increase: 2023-07-10

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[samh-nl]

The attached video relates to a different issue.

[tranvantoan-qn]

@samh-nl Thank you for pointing that out
Please check the following video:

Go-to-room-issue.mov.mov

[tranvantoan-qn]

The issue still persists with 2 of my 3 workspaces, If someone is having trouble reproducing it, please pm me, so I will share my secondary login. It will help you investigate the issue easier!

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In workspace information, user is taken to sub-sub thread/replies when clicking on “Go to #admins room” or "Go to #announce room".

What is the root cause of that problem?

If user click on “Go to #admins room” or "Go to #announce room", goToRoom is called.

App/src/pages/workspace/WorkspaceInitialPage.js

Lines 105 to 111 in c0ece67

	const goToRoom = useCallback(
	(type) => {
	const room = _.find(props.reports, (report) => report && report.policyID === policy.id && report.chatType === type);
	Navigation.navigate(ROUTES.getReportRoute(room.reportID));
	},
	[props.reports, policy],
	);

If a user creates a thread on the workspace, the thread has a CONST.REPORT.CHAT_TYPE.POLICY_ADMINS chatType, and policyID is equal to workspace's policyID.
So the thread is selected, and user is taken to the thread.

What changes do you think we should make in order to solve the problem?

We should select correct workspace room in goToRoom.
Workspace's admin or announce room have null parentReportID and parentReportActionID, and thread have non-null ID.
We should check parentReportID and parentReportActionID in this line.

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[trjExpensify]

The video in the OP is not related to this bug btw, switching it out for one from the slack thread.

I can reproduce this one. The prerequisite is that the default room contains a threadReport, so I've also updated the OP to reflect that:

Y7OMAWq13U.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01916b494f3ed66140

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[trjExpensify]

@0xmiroslav - what do you think of this proposal?

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - user is navigated to thread when clicking on “Go to #admins” or "Go to #announce room" in the workspace settings

What is the root cause of that problem?

When we are calling goToRoom there is no check to verify if it's workspace thread. Workspace Threads will also have the same chat type as their parent room.

What changes do you think we should make in order to solve the problem?

Solution 1

we have a utility function

App/src/libs/ReportUtils.js

Line 578 in 60f4817

function isWorkspaceThread(report) {

We can use it to verify if it's !isWorkspaceThread
change goToRoom From this

App/src/pages/workspace/WorkspaceInitialPage.js

Line 107 in 60f4817

const room = _.find(props.reports, (report) => report && report.policyID === policy.id && report.chatType === type);

to this

const room = _.find(props.reports, (report) => report && report.policyID === policy.id && report.chatType === type && !ReportUtils.isWorkspaceThread(report));

Don't forget to export the function. Currently, we are using this function inside the ReportUtils, which is why it has not been exported yet.
Solution 2
We have other utility functions
isDefaultRoom
isAnnounceRoom
isAdminRoom

Currently all of them will return true if it's a workspace thread because Workspace Threads will also have the same chat type as their parent room. We can fix them and use isDefaultRoom to check if it's a default room.

What alternative solutions did you explore? (Optional)

We can simply use isThread utility function to check if it's the thread

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.43-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix navigating to thread when clicking on go to #admins or #announce room #23030

If no regressions arise, payment will be issued on 2023-07-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @0xmiroslav requires payment
• @StevenKKC requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 @0xmiroslav can you get to the checklist please? :)

[0xmiros]

• The PR that introduced the bug has been identified. Link to the PR: Added go to room menu items to workspace #19295
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/19295/files#r1277591208
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Send any message in #admins or #announce room in any workspace
2. Reply that message in thread
3. Go to Settings > Workspaces > that workspace
4. Click 3 dots menu on top right corner and go to #admins or #announce room
5. Verify that is taken to correct #admins or #announce room, not thread

[trjExpensify]

Thanks! Looks like Applause added a test case for this on July 3rd (link you won't be able to access), so we should be good there!

[trjExpensify]

Proceeding with the payments due. I have those calculated as follows:

@tranvantoan-qn - $250 for the bug report (offer sent)
@StevenKKC - $1,500 for the fix & #urgency bonus (paid!)
@0xmiroslav - $1,500 for C+ review & #urgency bonus (offer sent)

[trjExpensify]

@tranvantoan-qn paid!

[0xmiros]

@trjExpensify can you please hold my payment until further notice? I am working on some stuff due to recent measurements in my region. And update issue to Monthly. Thanks

[trjExpensify]

Sure thing!

[trjExpensify]

@0xmiroslav what's the deal here now to issue payment?

[0xmiros]

Still in discussion. Waiting for confirmation in email thread

[trjExpensify]

Okay, sounds good. Let me know here once resolved!

[trjExpensify]

@0xmiroslav, I'm going to close these!